Any better way to do this?

[longhollow]

I'm not a PHP guy, just cut and paste code sometimes.  This works but it isn't very elegant.  My page gets lots of views and I would like to reduce machine overhead and deliver the page as fast as possible.  Any suggestions?  Thanks!

 

I'm creating a list of links on a page.  Each day the link thats 7 days old drops off and a new one appears.  The .txt files have the html link code for one day.

 

<?$today = date("z",(time()-3600))+1;?>

<?$today1 = date("z",(time()-3600));?>

<?$today2 = date("z",(time()-3600))-1;?>

<?$today3 = date("z",(time()-3600))-2;?>

<?$today4 = date("z",(time()-3600))-3;?>

<?$today5 = date("z",(time()-3600))-4;?>

<?$today6 = date("z",(time()-3600))-5;?>

 

<ul>

<li><?INCLUDE "/usr/home/bcmurray/public_html/features/$today.txt";?></li>

<li><?INCLUDE "/usr/home/bcmurray/public_html/features/$today1.txt";?></li>

<li><?INCLUDE "/usr/home/bcmurray/public_html/features/$today2.txt";?></li>

<li><?INCLUDE "/usr/home/bcmurray/public_html/features/$today3.txt";?></li>

<li><?INCLUDE "/usr/home/bcmurray/public_html/features/$today4.txt";?></li>

<li><?INCLUDE "/usr/home/bcmurray/public_html/features/$today5.txt";?></li>

<li><?INCLUDE "/usr/home/bcmurray/public_html/features/$today6.txt";?></li>

</ul></li>

 

[Mchl]

This should do the same.

 

<ul>
<?php

for ($i =1; $i >= -5; $i--) {
  echo "\t<li>";
  include ("/usr/home/bcmurray/public_html/features/".date("z",(time()-3600))+$i.".txt");
  echo "</li>\n";
}

?>
</ul>

[samshel]

not sure if u can make it faster, but u can definitely reduce the lines of code..

 

<ul>
<?php 
for($i=1; $i>=-5; $i--) {
$today = date("z",(time()-3600))+$i;
?>
 <li><? INCLUDE "/usr/home/bcmurray/public_html/features/$today.txt";?></li>
<?php 
}
?>
</ul>

 

PS: the code is not tested..

 

beaten by Mchl

[longhollow]

Thanks,  Worked fine.  My less code.

 

Wish I could find out if this loop method has less machine overhead than the original line by line approach.

 

Anyone have any idea?

[redarrow]

There both near to same speed.

 

looping and using arrays just quicker.

 

[Mchl]

You can easily check using microtime

 

<?php
$timeStart = microtime(true);
//code to test
$timeStop = microtime(true);
echo "total execution time: ".$timeStop - $timeStart;
?>

 

The difference will most likely be negligible.