problem using echo and variables with spaces

[pasturepool]

Hello,

 

I'm trying to dynamically display a URL which contains a variable pulled from a query.  I can get the link to display properly except that if the variable value in question contains a space, then the value is truncated. 

 

For example,

 

if($whcty='US') {

 

echo ("<a href=page.php?value=");

echo "$variableis;";

echo (">Click Here</a>");

 

} else

 

{

echo ("<a href=/dir/page.php?value=");

echo "$variableis;";

echo (">Click Here</a>");

}

 

 

Everything works fine if the $variableis does not contain spaces.  For example,

 

If $variableis = Some Value

 

  the resulting URL = page.php?value=Some

 

How do i get the URL to show:

 

page.php?value=Some Value

 

 

thank you!!!

 

 

 

 

 

[papaface]

I'll excuse the fact your code is awful, but you need to use:

echo urlencode("$variableis;");

[pasturepool]

Thanks.  Any other suggestions on how to improve it rather than criticize blindly? 

[trq]

To start with, if ($whcty='US') { assigns 'US' to $whcty, so it will always equal true.

 

Secondly, your php is outputting invalid html

 

Thridly, you code could be allot more consise. eg;

 

if ($whcty == 'US') {
  echo "<a href='page.php?value={$variables}'>Click Here</a>";                   
} else {
  echo "<a href='/dir/page.php?value={$variables}'>Click Here</a>";      
}