pasturepool Posted May 5, 2009 Share Posted May 5, 2009 Hello, I'm trying to dynamically display a URL which contains a variable pulled from a query. I can get the link to display properly except that if the variable value in question contains a space, then the value is truncated. For example, if($whcty='US') { echo ("<a href=page.php?value="); echo "$variableis;"; echo (">Click Here</a>"); } else { echo ("<a href=/dir/page.php?value="); echo "$variableis;"; echo (">Click Here</a>"); } Everything works fine if the $variableis does not contain spaces. For example, If $variableis = Some Value the resulting URL = page.php?value=Some How do i get the URL to show: page.php?value=Some Value thank you!!! Quote Link to comment Share on other sites More sharing options...
papaface Posted May 5, 2009 Share Posted May 5, 2009 I'll excuse the fact your code is awful, but you need to use: echo urlencode("$variableis;"); Quote Link to comment Share on other sites More sharing options...
pasturepool Posted May 6, 2009 Author Share Posted May 6, 2009 Thanks. Any other suggestions on how to improve it rather than criticize blindly? Quote Link to comment Share on other sites More sharing options...
trq Posted May 6, 2009 Share Posted May 6, 2009 To start with, if ($whcty='US') { assigns 'US' to $whcty, so it will always equal true. Secondly, your php is outputting invalid html Thridly, you code could be allot more consise. eg; if ($whcty == 'US') { echo "<a href='page.php?value={$variables}'>Click Here</a>"; } else { echo "<a href='/dir/page.php?value={$variables}'>Click Here</a>"; } Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.