tail Posted June 7, 2009 Share Posted June 7, 2009 I started working on the site 3-4 months ago. Using it as a tool to enhance my knowledge of PHP and to fill some spare time. Please let me know what you think! Edit: Forgot link... oops http://perks.kicks-ass.org:78 Quote Link to comment https://forums.phpfreaks.com/topic/161279-please-critique/ Share on other sites More sharing options...
gevans Posted June 7, 2009 Share Posted June 7, 2009 where's the website link? Quote Link to comment https://forums.phpfreaks.com/topic/161279-please-critique/#findComment-851036 Share on other sites More sharing options...
tail Posted June 7, 2009 Author Share Posted June 7, 2009 Haha that was dumb. I guess that's what 3 hours of sleep does to you. The link is in the first post now. Quote Link to comment https://forums.phpfreaks.com/topic/161279-please-critique/#findComment-851038 Share on other sites More sharing options...
gevans Posted June 7, 2009 Share Posted June 7, 2009 As you mentioned, it's just a random site for your own improvement. So the content of the site isn't really important. The html is pretty good, could be one or two lists, but apart from that you have the correct use of divs/tables/spans, the standard places where people go wrong. I'd suggest a security measure on your shout box if it's going to be available to everyone, captcha perhaps. Realistically you should resctric it for logged in users. The design is pretty bad, probably what I'd come up with if I didn't have a designer, but I have a feeling that wasn't what you were striving for. When you search games it goes to a games page rather than a search page, which is what the other two categories do. Also you should hide errors in an online environment; Warning: mktime() expects parameter 4 to be long, string given in /var/www/users/signup.php on line 27 You could do a lot of work on the usability of the register page. Quote Link to comment https://forums.phpfreaks.com/topic/161279-please-critique/#findComment-851046 Share on other sites More sharing options...
tail Posted June 7, 2009 Author Share Posted June 7, 2009 Thank you for the feedback. As of now the security measure on the shoutbox is a session called flood. If it's set then you can't post. Yes, the design is pretty much as simple has it gets. About the search, I just put a label of the selected category at the top. Would you suggest just having it say "Search"? Quote Link to comment https://forums.phpfreaks.com/topic/161279-please-critique/#findComment-851054 Share on other sites More sharing options...
gevans Posted June 7, 2009 Share Posted June 7, 2009 Whichever you prefer, but at the momemt 2 of the categories just say search, and the third has its own title. I'd recommend some level of consistency, so all 'search' or all using their own title with a similar style across them all. Quote Link to comment https://forums.phpfreaks.com/topic/161279-please-critique/#findComment-851058 Share on other sites More sharing options...
tail Posted June 7, 2009 Author Share Posted June 7, 2009 Ahh, I see. Fixed! Quote Link to comment https://forums.phpfreaks.com/topic/161279-please-critique/#findComment-851060 Share on other sites More sharing options...
nrg_alpha Posted June 7, 2009 Share Posted June 7, 2009 - You may want to look into validating your markup and css. - You shouldn't use tables for layout purposes.. I would learn how to do that all in css instead. - Regarding SEO, you have a single <h3> tag, which contains today's date? I wouldn't use heading tags for those.. I would use 1 <h1> tag for the most important 'headline' on the page, then use some <h2> tags for sub headings, and so forth. You have a good description meta tag, but you title tag should be more detailed than simply 'perks's page'. According to this book, the title tag is one of the most important places to put your keywords and phrases (and no, this doesn't mean a dumping ground for keyword stuffing). The point of the title tag is to educate visitors and search engines about the page, site and what it's about. Title tags should be a short concise yet descriptive sentence. An example of a better title tag in your case could be: <title>Home | Perk's Page | Where you'll find music, games, tools, and more.</title> (borrowed from the description). Obviously, custom it to be more accurate if need be. Keep it short to reduce the odds of truncation. - Using Yahoo's smushit!, you can shave some memory off of images (your home page can shave off ~2.33 KB... not much.. but better than nothing.) From a visual standpoint: - I can't say I'm a fan TBH. A lot of wasted space on the sides of the content in the central column. - Today's date could be removed from that awkward position and placed at the top right hand side of the central column. - The header graphic and the header background could use some polish IMO (easier said than done if being artistic isn't your strength, I know). - The rounded corners for the panels that contain 'Status Updates' for example look rough around the edges. I would make them smoother with anti-aliasing. - I can see you like tightly containing content in their sections (no space between text and their surrounding square regions.. I would add some padding / margins to give content more breathing room. Overall, while light weight and fast, it could use some more 'pizzaz' and better use of layout IMO. Quote Link to comment https://forums.phpfreaks.com/topic/161279-please-critique/#findComment-851092 Share on other sites More sharing options...
tail Posted June 7, 2009 Author Share Posted June 7, 2009 Thank you for the tips. Quote Link to comment https://forums.phpfreaks.com/topic/161279-please-critique/#findComment-851106 Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.