error in code ?

Porkie · June 17, 2009

hi when i try submit this form i get this problem can someone help please?

Code

<?php

$con = mysql_connect("localhost","","");
if (!$con)
  {
  die('Could not connect: ' . mysql_error());
  }

mysql_select_db("", $con);

$sql="INSERT INTO Users (UF_Username, UF_Password, UF_Email, UF_Country, UF_DD, UF_MM, UF_YY, UF-Unique, UF_TC, UF_Mailing)
VALUES
('$_POST[uF_Username]','$_POST[uF_Password]','$_POST[uF_Email]','$_POST[uF_Country]','$_POST[uF_DD]','$_POST[uF_MM]','$_POST[uF_YY]','$_POST[uF_Unique]','$_POST[uF_TC]','$_POST[uF_Mailing]')";

if (!mysql_query($sql,$con))
  {
  die('Error: ' . mysql_error());
  }
echo "1 record added";

mysql_close($con)
?>

Error

Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '-Unique, UF_TC, UF_Mailing) VALUES ('dfsfdsf','sdfsdf','[email protected]','' at line 1

Any help?

Cheers

EDITED BY akitchin: USE CODE TAGS.

June 17, 2009

Is this a constant?: UF_Username

Because when you access the post value, you don't put quotes/apostrophes around the key.

Porkie · June 17, 2009

heres the form code

Code

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Untitled Document</title>
</head>

<body>
<form id="UserRegister" name="UserRegister" method="post" action="mail.php">
   
  <label>Username :</label>
  <input name="Username" type="text" id="Username" />
  <p>
  <label>Password :</label>
    <input name="Password" type="text" id="Password" />
   <label>Repeat Password:</label>
  <input name="PasswordRepeat" type="text" id="PasswordRepeat" />
  <p>
  <label>Email Address:</label>
    <input name="Email" type="text" id="Email" />
  <p>
<label>Country:</label>
    <select name="Country" id="Country">
      <option value="England" selected="selected">England</option>
      <option value="Wales">Wales</option>
      <option value="Ireland">Ireland</option>
      <option value="Scotland">Scotland</option>
      <option value="America">America</option>
  </select>  
  <p>
    <label>Date Of Birth:</label>
    
    <label>
    <select name="DD" id="DD">
      <option value="1" selected="selected">1</option>
      <option value="2">2</option>
      <option value="3">3</option>
      <option value="4">4</option>
      <option value="5">5</option>
      <option value="6">6</option>
      <option value="7">7</option>
      <option value="8">8</option>
      <option value="9">9</option>
      <option value="10">10</option>
      <option value="11">11</option>
      <option value="12">12</option>
      <option value="13">13</option>
      <option value="14">14</option>
      <option value="15">15</option>
      <option value="16">16</option>
      <option value="17">17</option>
      <option value="18">18</option>
      <option value="19">19</option>
      <option value="20">20</option>
      <option value="21">21</option>
      <option value="22">22</option>
      <option value="23">23</option>
      <option value="24">24</option>
      <option value="25">25</option>
      <option value="26">26</option>
      <option value="27">27</option>
      <option value="28">28</option>
      <option value="29">29</option>
      <option value="30">30</option>
      <option value="31">31</option>
    </select>
    </label>
    <select name="MM" id="MM">
      <option value="January" selected="selected">January</option>
      <option value="February">February</option>
      <option value="March">March</option>
      <option value="April">April</option>
      <option value="May">May</option>
      <option value="June">June</option>
      <option value="July">July</option>
      <option value="August">August</option>
      <option value="September">September</option>
      <option value="October">October</option>
      <option value="November">Novermber</option>
      <option value="December">December</option>
    </select>
    <select name="YY" id="YY">
      <option value="1950">1950</option>
      <option value="1951">1951</option>
      <option value="1952">1952</option>
      <option value="1953">1953</option>
  <option value="1954">1954</option>
      <option value="1955">1955</option>
  <option value="1956">1956</option>
      <option value="1957">1957</option>
  <option value="1958">1958</option>
      <option value="1959">1959</option>
  <option value="1960">1960</option>
      <option value="1961">1961</option>
  <option value="1962">1962</option>
      <option value="1963">1963</option>
      <option value="1964">1964</option>
      <option value="1965">1965</option>
  <option value="1966">1966</option>
      <option value="1967">1967</option>
  <option value="1968">1968</option>
      <option value="1969">1969</option>
  <option value="1970">1970</option>
      <option value="1971">1971</option>
  <option value="1972">1972</option>
      <option value="1973">1973</option>
  <option value="1974">1974</option>
      <option value="1975">1975</option>
  <option value="1976">1976</option>
      <option value="1977">1977</option>
  <option value="1978">1978</option>
      <option value="1979">1979</option>
      <option value="1980">1980</option>
      <option value="1981">1981</option>
  <option value="1982">1982</option>
      <option value="1983">1983</option>
  <option value="1984">1984</option>
      <option value="1985">1985</option>
  <option value="1986">1986</option>
      <option value="1987">1987</option>
  <option value="1988">1988</option>
      <option value="1989">1989</option>
  <option value="1990" selected="selected">1990</option>
      <option value="1991">1991</option>
  <option value="1992">1992</option>
      <option value="1993">1993</option>
      <option value="1994">1994</option>
      <option value="1995">1995</option>
  <option value="1996">1996</option>
      <option value="1997">1997</option>
  <option value="1998">1998</option>
      <option value="1999">1999</option>
  <option value="2000">2000</option>
      <option value="2001">2001</option>
  <option value="2002">2002</option>
      <option value="2003">2003</option>
  <option value="2004">2004</option>
      <option value="2005">2005</option>
  <option value="2006">2006</option>
      <option value="2007">2007</option>
  <option value="2008">2008</option>
      <option value="2009">2009</option>
    </select>
  <p>Unique Number:</p>
  <p>
    <?php
  $unique=rand(1000,99000);
  {
  echo $unique;
  }
  
  ?> 
  </p>
  <p>
    <label>
    <input name="TC" type="checkbox" id="TC" value="Yes" />
    </label>
  I agree to the T&C pointed out by # </p>
  <p>
    <label>
    <input name="Mailing" type="checkbox" id="Mailing" value="Yes" />
    </label>
    I would like to join the # mailing list 
  </p>
  <p>
    <label>
    <input type="submit" name="Submit" value="Submit" />
    </label>
  </p>
  <p> </p>
</form>

</body>
</html>

EDITED BY akitchin: please for the love of all things holy, use code tags.

June 18, 2009

Unless I am not looking at this right, all of your POST keys are incorrect. You have to use the form name. Right now you have $_POST['UF_username']; That needs to be simply $_POST['username'];

Also...can you echo $sql so I can see what the entire query looks like?

DavidAM · June 18, 2009

947740 is on the right track of another problem you will have once you get the sql syntax fixed. So, pay attention.

As for the actual error message, in your list of columns to be inserted you have:

UF_YY, UF-Unique, UF_TC,

UF-Unique that is a minus sign (read: UF minus Unique). If that is an actual column name, you will need to enclose it in backticks (`UF-Unique`). Looking at the rest of your statement, I suspect it is a typo and should actually be an underscore (UF_Unique).

Once you fix that, you will find that you are using the wrong key names for your POST variables, just as 947740 said.

Sign In

error in code ?

Recommended Posts

Porkie

Link to comment

Share on other sites

947740

Link to comment

Share on other sites

Porkie

Link to comment

Share on other sites

947740

Link to comment

Share on other sites

DavidAM

Link to comment

Share on other sites

Archived

Browse

Activity

Important Information