toggle menu help (logic problem)

[Q695]

the menu code:

    <?php
    if ($u_row[char_mnu]=1){
    echo "
    <a href='?page=menus&contract=char_mnu&type=charicter'>Character</a>
    	<br>
    working
    ";
    }
else if($u_row[char_mnu]=0){
echo "
    <a href='?page=menus&expand=char_mnu&type=charicter'>Character</a>
    ";
}
    ?>

 

operating code:

<?php
$expand=$_GET[expand];
$contract=$_GET[contract];
if($expand){
$sql="UPDATE players SET $expand = '1' WHERE id='$id' ;";

}
if($contract){
$sql="UPDATE players SET $contract = '0' WHERE id='$id' ;";

}

echo $sql;
?>
<form name='wipe' method='get'>
<input type='hidden' name='page' value="<?php echo $_GET[type] ;?>">//page address info
</form>
<script>
document.wipe.submit();
</script>

 

The bug is a logic issue, but I don't know what I'm doing wrong.

[Bendude14]

What is happeming? and what were you expecting?

[Q695]

it's staying expanded, and should be able to shrink to one line.

[Q695]

think of a start menu that doesn't automatically close on it's own.

[Q695]

Does anyone see what I'm doing wrong?

[haku]

if ($u_row[char_mnu]=1){

 

This will always be true. Echo out $u_row[char_mnu] after this line of code.

[Q695]

Why won't it ever be 0 again?

[J.Daniels]

if ($u_row[char_mnu]=1){

 

and

 

else if($u_row[char_mnu]=0){

 

are assigning values, which will always return true (which is why haku wanted to you echo them out)

 

 

They need to be changed to:

 

if ($u_row[char_mnu]==1){

 

and

 

else if($u_row[char_mnu]==0){

[Q695]

it's been a while since I've dealt with PHP , that should help

[Q695]

I also just noticed that I forgot to call the statement