Jump to content

[SOLVED] favicon icon in header?


gwolff2005

Recommended Posts

Hi guys I need your help.

 

I created a subdomain: forum.xxxxx.com and installed a forum. When people go on that site it does not show the favicon icon. So I wanted to bring the link into the index, but then it tells me the whole time that the output of the headers already started. Where do I need to put the code for the icon in the following index code? Thanks so much in advance... I am at the moment desperate!

 

<link rel="shortcut icon" href="favicon.ico" >
<link rel="icon" href="animated_favicon1.gif" type="image/gif" >

 

<?php
/**
*
* @package phpBB3
* @version $Id: index.php 8987 2008-10-09 14:17:02Z acydburn $
* @copyright (c) 2005 phpBB Group
* @license http://opensource.org/licenses/gpl-license.php GNU Public License
*
*/

/**
*/

/**
* @ignore
*/
define('IN_PHPBB', true);
$phpbb_root_path = (defined('PHPBB_ROOT_PATH')) ? PHPBB_ROOT_PATH : './';
$phpEx = substr(strrchr(__FILE__, '.'), 1);
include($phpbb_root_path . 'common.' . $phpEx);
include($phpbb_root_path . 'includes/functions_display.' . $phpEx);

// Start session management
$user->session_begin();
$auth->acl($user->data);
$user->setup('viewforum');

display_forums('', $config['load_moderators']);

// Set some stats, get posts count from forums data if we... hum... retrieve all forums data
$total_posts	= $config['num_posts'];
$total_topics	= $config['num_topics'];
$total_users	= $config['num_users'];

$l_total_user_s = ($total_users == 0) ? 'TOTAL_USERS_ZERO' : 'TOTAL_USERS_OTHER';
$l_total_post_s = ($total_posts == 0) ? 'TOTAL_POSTS_ZERO' : 'TOTAL_POSTS_OTHER';
$l_total_topic_s = ($total_topics == 0) ? 'TOTAL_TOPICS_ZERO' : 'TOTAL_TOPICS_OTHER';

// Grab group details for legend display
if ($auth->acl_gets('a_group', 'a_groupadd', 'a_groupdel'))
{
$sql = 'SELECT group_id, group_name, group_colour, group_type
	FROM ' . GROUPS_TABLE . '
	WHERE group_legend = 1
	ORDER BY group_name ASC';
}
else
{
$sql = 'SELECT g.group_id, g.group_name, g.group_colour, g.group_type
	FROM ' . GROUPS_TABLE . ' g
	LEFT JOIN ' . USER_GROUP_TABLE . ' ug
		ON (
			g.group_id = ug.group_id
			AND ug.user_id = ' . $user->data['user_id'] . '
			AND ug.user_pending = 0
		)
	WHERE g.group_legend = 1
		AND (g.group_type <> ' . GROUP_HIDDEN . ' OR ug.user_id = ' . $user->data['user_id'] . ')
	ORDER BY g.group_name ASC';
}
$result = $db->sql_query($sql);

$legend = array();
while ($row = $db->sql_fetchrow($result))
{
$colour_text = ($row['group_colour']) ? ' style="color:#' . $row['group_colour'] . '"' : '';
$group_name = ($row['group_type'] == GROUP_SPECIAL) ? $user->lang['G_' . $row['group_name']] : $row['group_name'];

if ($row['group_name'] == 'BOTS' || ($user->data['user_id'] != ANONYMOUS && !$auth->acl_get('u_viewprofile')))
{
	$legend[] = '<span' . $colour_text . '>' . $group_name . '</span>';
}
else
{
	$legend[] = '<a' . $colour_text . ' href="' . append_sid("{$phpbb_root_path}memberlist.$phpEx", 'mode=group&g=' . $row['group_id']) . '">' . $group_name . '</a>';
}
}
$db->sql_freeresult($result);

$legend = implode(', ', $legend);

// Generate birthday list if required ...
$birthday_list = '';
if ($config['load_birthdays'] && $config['allow_birthdays'])
{
$now = getdate(time() + $user->timezone + $user->dst - date('Z'));
$sql = 'SELECT user_id, username, user_colour, user_birthday
	FROM ' . USERS_TABLE . "
	WHERE user_birthday LIKE '" . $db->sql_escape(sprintf('%2d-%2d-', $now['mday'], $now['mon'])) . "%'
		AND user_type IN (" . USER_NORMAL . ', ' . USER_FOUNDER . ')';
$result = $db->sql_query($sql);

while ($row = $db->sql_fetchrow($result))
{
	$birthday_list .= (($birthday_list != '') ? ', ' : '') . get_username_string('full', $row['user_id'], $row['username'], $row['user_colour']);

	if ($age = (int) substr($row['user_birthday'], -4))
	{
		$birthday_list .= ' (' . ($now['year'] - $age) . ')';
	}
}
$db->sql_freeresult($result);
}

// Assign index specific vars
$template->assign_vars(array(
'TOTAL_POSTS'	=> sprintf($user->lang[$l_total_post_s], $total_posts),
'TOTAL_TOPICS'	=> sprintf($user->lang[$l_total_topic_s], $total_topics),
'TOTAL_USERS'	=> sprintf($user->lang[$l_total_user_s], $total_users),
'NEWEST_USER'	=> sprintf($user->lang['NEWEST_USER'], get_username_string('full', $config['newest_user_id'], $config['newest_username'], $config['newest_user_colour'])),

'LEGEND'		=> $legend,
'BIRTHDAY_LIST'	=> $birthday_list,

'FORUM_IMG'				=> $user->img('forum_read', 'NO_NEW_POSTS'),
'FORUM_NEW_IMG'			=> $user->img('forum_unread', 'NEW_POSTS'),
'FORUM_LOCKED_IMG'		=> $user->img('forum_read_locked', 'NO_NEW_POSTS_LOCKED'),
'FORUM_NEW_LOCKED_IMG'	=> $user->img('forum_unread_locked', 'NO_NEW_POSTS_LOCKED'),

'S_LOGIN_ACTION'			=> append_sid("{$phpbb_root_path}ucp.$phpEx", 'mode=login'),
'S_DISPLAY_BIRTHDAY_LIST'	=> ($config['load_birthdays']) ? true : false,

'U_MARK_FORUMS'		=> ($user->data['is_registered'] || $config['load_anon_lastread']) ? append_sid("{$phpbb_root_path}index.$phpEx", 'hash=' . generate_link_hash('global') . '&mark=forums') : '',
'U_MCP'				=> ($auth->acl_get('m_') || $auth->acl_getf_global('m_')) ? append_sid("{$phpbb_root_path}mcp.$phpEx", 'i=main&mode=front', true, $user->session_id) : '')
);

// Output page
page_header($user->lang['INDEX']);

$template->set_filenames(array(
'body' => 'index_body.html')
);

page_footer();

?>

Link to comment
Share on other sites

Hi thanks for that help. I found a file which ias called functions.php and a part of teh code is this here

	header('Content-type: text/html; charset=UTF-8');
header('Cache-Control: private, no-cache="set-cookie"');
header('Expires: 0');
header('Pragma: no-cache');

I guess that this is the right place where to insert the tag. But when I try it it just tell me that there is a mistake I tried the following: What did I do wrong?

	header('Content-type: text/html; charset=UTF-8');
header('Cache-Control: private, no-cache="set-cookie"');
header('Expires: 0');
header('Pragma: no-cache');
header <link rel="shortcut icon" href="favicon.ico" >;
    header <link rel="icon" href="animated_favicon1.gif" type="image/gif" >;

Link to comment
Share on other sites

You went wrong because you are not setting a header, you are setting a tag inside the head. Headers are extra information sent to the browser telling the browser information about the document it is receiving.

 

As for your problem, you are using phpbb which uses a templating system. If you are using phpbb3, I believe the file you need to edit is:

 

styles/your_style_name/template/overall_header.html

 

where your_style_name is the name of the style you are using on your forum.

 

Open it up and put it between the <head> tags. You will then need to go into the admin panel and clear the template cache for the changes to be effected.

Link to comment
Share on other sites

Hi Haku thanks so much! I really thought that that was the solution and it sounds pretty logical. However I insert

<head>
<link rel="shortcut icon" href="favicon.ico" >
<link rel="icon" href="animated_favicon1.gif" type="image/gif" >
<meta http-equiv="content-type" content="text/html; charset={S_CONTENT_ENCODING}" />
<meta http-equiv="content-style-type" content="text/css" />
<meta http-equiv="content-language" content="{S_USER_LANG}" />

in overall_header and simple header and after that I cleared the cache in admin panel. Still nothing changes. Can you see if I made a mistake?? Thanks so much!

Link to comment
Share on other sites

You are missing the trailing slash at the end of the <link> tags. Look at the tags below that for examples.

 

That being said, favicons are finnicky as hell. Add the trailing slashes and leave it for a day and come back, sometimes that cleans things up.

 

Also, what browser are you using? If it's IE6, it's doubtful you will see it anytime soon. If it's firefox, it should probably already appear.

Link to comment
Share on other sites

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.