[SOLVED] while loop within a function

[razta]

Hello,

Im having a little trouble with the following:

 

function Guestbook(){

$query  = "SELECT name, comment FROM guestbook";
$result = mysql_query($query);

while($row = mysql_fetch_array($result, MYSQL_ASSOC)){
	return "<b>Name</b> : {$row['name']} <br>" .
	"<b>Message</b> : {$row['comment']} <br><br>";
} 

}

 

When I call the Guestbook() function it only returns one comment and omits the rest. I have been playing with the code for hours, im sure theres a simple solution.

 

Thanks in advance!

[roopurt18]

return causes the function to end immediately.

 

You need to build the list of results inside the function and issue return after the list is built.

[razta]

Thank you for the reply roopurt18. I think im on the right track however theres still something im missing. 

 

function Guestbook(){

$query  = "SELECT name, comment FROM guestbook";
$result = mysql_query($query);

while($row = mysql_fetch_row($result)){	
	$name    = $row[0];
	$comment = $row[1];
} 
	return "<b>Name</b> : {$name} <br>" .
			"<b>Message</b> : {$comment} <br><br>";
}

 

Should I also stick the return in a loop?!

 

Thanks again! 

 

[akitchin]

no - you still need to construct the message list within the while() loop. what roopurt meant was that you return this string AFTER constructing it:

 

function Guestbook(){

  $guestbook = '';

   $query  = "SELECT name, comment FROM guestbook";
   $result = mysql_query($query);

   while($row = mysql_fetch_row($result)){   
      $name    = $row[0];
      $comment = $row[1];
      $guestbook .= "<b>Name</b> : {$name} <br>" .
            "<b>Message</b> : {$comment} <br><br>";
   }

   return $guestbook;
}

[razta]

Works great!! Thanks to everyone for the help!