preg_match http problem

[greenheart]

Hello I am using preg_match to find a http address in a string. Here is my code:

 

preg_match_all("#href=\"(http://[^']+)\"#", $string, $matches);          
print_r($matches);	

 

 

Problem is it gives e.g

http://www.example.com/review">

 

followed by images (which are in img tags next to the address in the string)

 

when I want 

 

http://www.example.com/review

 

without the ">. I tried to specify it ends in " but it goes on past the " and onto the next ".

 

Please help me, thank you.

 

 

[cags]

You start your href with a double quote and say anything but single quote repeat. Without really looking at the main logic of the regex I would have thought it should be more along the lines of...

 

'#href="(http://[^"]+)#'

[greenheart]

That works perfectly. I'll have to look at that carefully.

 

Thanks so much!

[cags]

Basically it says find instances of href="http:// and any other characters untill you encounter another double quote.