Why is this query failing?

[ghurty]

Why is this not working?

$query = "SELECT *  FROM `users` WHERE `userid` = " . $USERID AND `pin` = " . $PIN;

$result = mysql_query($query)

    or die("Web site query failed");

 

When I all I have is:

$query = "SELECT *  FROM `users` WHERE `userid` = " . $USERID;

$result = mysql_query($query)

    or die("Web site query failed");

 

It does work. But when I ad the PIN, it just fails. I have the variable $PIN assigned and I have a field called pin.

 

Thanks

[mikesta707]

you are concatenating incorrectly. you should use an editor with syntax highlighting, because the error will become very apparent.

$query = "SELECT *  FROM `users` WHERE `userid` = " . $USERID AND `pin` = " . $PIN;//bad query

$query = "SELECT *  FROM `users` WHERE `userid` = " . $USERID . " AND `pin` = " . $PIN; //fixed

[trq]

Are both userid and pin non numeric data types?