Trying to create a image upload script

[deansaddigh]

Hi guys, i have a form with appropriate tags etc.

it then send the data to the process page to upload the image.

When i test it, the process page does absolutely nothing doesn't even give the error message that the upload was unsuccessful.

I dont know whats going on.

 

Form Code

		<form id="form" name="form" method="post" enctype="multipart/form-data" action="process_product.php">
		<fieldset>
		<legend>Use this form to add a product</legend>
		<h1>Add Product</h1>
		<p>Please use this form to add a product</p>

		<label>Product Name</label>
		<input type="text" name="name"/><br /><br />

		<label>Product Catagory</label>
		<select>
		  <option value="LPS frags">LPS frags</option>
		  <option value="SPS frags">LPS frags</option>
		  <option value="Soft Coral frags">Soft Coral frags</option>
		  <option value="Coral Frag packs">Coral Frag packs</option>
		  <option value="SPS Coral Colonies">SPS Coral Coloniesi</option>
		  <option value="LPS Coral Colonies">LPS Coral Colonies</option>
		  <option value="Anemones">Anemones</option>
		</select><br /><br />

		<label>Product Quantity</label>
		<input type="text" name="quantity"/><br /><br />

		<label>Product Price</label>
		<input type="text" name="price"/><br /><br />

		<label>Product Description</label>
		<textarea cols="30" rows="4" name="description"></textarea><br /><br />

		 <input type="hidden" name="MAX_FILE_SIZE" value="500000000" />
             <label>Add Picture:</label>  <input name="image" type="file"  /><br /><br />
                    


		<button type="submit" class="submit">Add Product</button>

		</fieldset>
		</form>

 

And the process form code.

 

	<?php
//define a maxim size for the uploaded images in Kb
define ("MAX_SIZE","100"); 

//This function reads the extension of the file. It is used to determine if the file  is an image by checking the extension.
function getExtension($str) {
         $i = strrpos($str,".");
         if (!$i) { return ""; }
         $l = strlen($str) - $i;
         $ext = substr($str,$i+1,$l);
         return $ext;
}

//This variable is used as a flag. The value is initialized with 0 (meaning no error  found)  
//and it will be changed to 1 if an errro occures.  
//If the error occures the file will not be uploaded.
$errors=0;
//checks if the form has been submitted
if(isset($_POST['Submit'])) 
{
	//reads the name of the file the user submitted for uploading
	$image=$_FILES['image']['name'];
	//if it is not empty
	if ($image) 
	{
	//get the original name of the file from the clients machine
		$filename = stripslashes($_FILES['image']['name']);
	//get the extension of the file in a lower case format
  		$extension = getExtension($filename);
		$extension = strtolower($extension);
	//if it is not a known extension, we will suppose it is an error and will not  upload the file,  
//otherwise we will do more tests
if (($extension != "jpg") && ($extension != "jpeg") && ($extension != "png") && ($extension != "gif")) 
		{
	//print error message
			echo '<h1>Unknown extension!</h1>';
			$errors=1;
		}
		else
		{
//get the size of the image in bytes
//$_FILES['image']['tmp_name'] is the temporary filename of the file
//in which the uploaded file was stored on the server
$size=filesize($_FILES['image']['tmp_name']);

//compare the size with the maxim size we defined and print error if bigger
if ($size > MAX_SIZE*1024)
{
echo '<h1>You have exceeded the size limit!</h1>';
$errors=1;
}

//we will give an unique name, for example the time in unix time format
$image_name=time().'.'.$extension;
//the new name will be containing the full path where will be stored (images folder)
$newname="..Product_image/".$image_name;
//we verify if the image has been uploaded, and print error instead
$copied = copy($_FILES['image']['tmp_name'], $newname);
if (!$copied) 
{
echo '<h1>Copy unsuccessfull!</h1>';
$errors=1;
}}}}

//If no errors registred, print the success message
if(isset($_POST['Submit']) && !$errors) 
{
	echo "<h1>File Uploaded Successfully! Try again!</h1>";
}

?>

[JonnoTheDev]

This is not the correct code for file upload. You are missing a core function

http://uk2.php.net/move_uploaded_file

 

Follow this tutorial

http://www.tizag.com/phpT/fileupload.php

[deansaddigh]

Thanks so much ill do that.

 

Cheers again

[deansaddigh]

Ok so i have followed that tutorial.

 

im getting these errors

Notice: Undefined index: uploadedfile in C:\wamp\www\Php Shoping cart\html\process_product.php on line 38

Notice: Undefined index: uploadedfile in C:\wamp\www\Php Shoping cart\html\process_product.php on line 43

Notice: Undefined index: uploadedfile in C:\wamp\www\Php Shoping cart\html\process_product.php on line 45
There was an error uploading the file, please try again! 

 

heres my form

 

	<form id="form" name="form" method="post" enctype="multipart/form-data" action="process_product.php">
		<fieldset>
		<legend>Use this form to add a product</legend>
		<h1>Add Product</h1>
		<p>Please use this form to add a product</p>

		<label>Product Name</label>
		<input type="text" name="name"/><br /><br />

		<label>Product Catagory</label>
		<select>
		  <option value="LPS frags">LPS frags</option>
		  <option value="SPS frags">LPS frags</option>
		  <option value="Soft Coral frags">Soft Coral frags</option>
		  <option value="Coral Frag packs">Coral Frag packs</option>
		  <option value="SPS Coral Colonies">SPS Coral Coloniesi</option>
		  <option value="LPS Coral Colonies">LPS Coral Colonies</option>
		  <option value="Anemones">Anemones</option>
		</select><br /><br />

		<label>Product Quantity</label>
		<input type="text" name="quantity"/><br /><br />

		<label>Product Price</label>
		<input type="text" name="price"/><br /><br />

		<label>Product Description</label>
		<textarea cols="30" rows="4" name="uploadedfile"></textarea><br /><br />

		 <input type="hidden" name="MAX_FILE_SIZE" value="500000000" />
             <label>Add Picture:</label>  <input name="image" type="file"  /><br /><br />
                    


		<button type="submit" class="submit">Add Product</button>

		</fieldset>
		</form>

 

Heres my process form page.

 

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<?php
include '../includes/connection.php';
?>

<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<link rel="shortcut icon" href="../images/animated_favicon1.gif" />
<link rel="stylesheet" type="text/css" href="../css/layout.css" /> 


<title>Nextdayfrags.co.uk</title>
</head>

<body>
<!--wrapper to hold site-->
    <div id="wrapper">
    	
      <!--Logo holder-->
      <div id="header"></div>
        
        <div id="left">       		 
       <div align="center">	
       	<img src="../images/paypal.png" alt="Paypal verified" /> 
       </div>
        </div>
        
        <div id="right">
       <?php 
       
// Where the file is going to be placed 
       
$target_path = "../Product_image/";

/* Add the original filename to our target path.  
Result is "uploads/filename.extension" */
$target_path = $target_path . basename( $_FILES['uploadedfile']['name']); 
        
        
   		 $target_path = "../Product_image//";

$target_path = $target_path . basename( $_FILES['uploadedfile']['name']); 

if(move_uploaded_file($_FILES['uploadedfile']['tmp_name'], $target_path)) {
    echo "The file ".  basename( $_FILES['uploadedfile']['name']). 
    " has been uploaded";
} else{
    echo "There was an error uploading the file, please try again!";
}
?>


	</div>
   			
        	
       
          		
     </div>        
      

    
    
   

</body>
</html>

 

anyone any ideas?

[PFMaBiSmAd]

The name="..." of your form field no longer matches the name being used in the php code, hence the Undefined index: uploadedfile message. The form is not setting uploadedfile. You need to match the names where data is produced and where it is used.