Implode failing, but why?

[jfulbrook]

Hello there,

 

I am using an 'Implode' to separete my array with commas. Pretty standard I thought, but if fails every time, but why, I don't know? Any suggestions would be greatfully recieved, please see code below:

 

 
$row_getJournalAuthors = mysql_fetch_array($query_getJournalAuthors);
$arr = array($row_getJournalAuthors['name']);
$str = implode(", ",$arr);
echo $str;

 

The result is just the names, but no commas or spaces; like this - John SmithJoe BloggsBurt Reynolds

 

Any clues anyone?

 

Thanks in advance!!

[Alex]

It's because implode() takes an array and separates each element and makes a string using the first parameter as a delimiter. In your code $arr only contains one element( $row_getJournalAuthors['name'] ), so nothing is actually done. Can you show us an example of what $row_getJournalAuthors['name'] contains?

[JasonLewis]

You'll need to explode() the variable at the spaces by the looks of it, then use implode. Or you could just use str_replace() on the spaces and put in commas.

[Alex]

Actually, judging by the output the OP stated there's no delimiters used in the database record. The spaces you're seeing are actually the spaces separating first and last names.

[jfulbrook]

Hello,

 

Thanks for the response so far.

 

The data for $row_getJournalAuthors['name'] is a first and second name in one field. i.e. John Smith.

The other field is an author ID.

 

When i use a for each loop like this:

 

$row_getJournalAuthors = mysql_fetch_array($query_getJournalAuthors);
foreach($row_getJournalAuthors as $author){
   $arr[] = $author;}
$str = implode(", ",$arr);
echo $str;

 

I get:

 

144, 144, Paul smith, Paul smith, 1, 1144, 144, Paul smith, Paul smith, 1, 1, 147, 147, Lynne marks, Lynne marks, 1, 1

 

Please note there is a While loop going on behind the for each loop

[9three]

I think you're over complicating the situation. Try this:

 

$results = array();
while ($row = mysql_fetch_array($query_getJournalAuthors))
  $results[] = $row['name'];

echo implode(', ', $results);