Quick Strpos Problem

[cursed]

Apologies for the stupid q in advance.

 

 

Why doesn't strpos find the keyword?

 

<?
$test = "hi";
$page = file_get_contents("http://www.google.com");
function destroyiffound($keyword) {
if(strpos($page, $keyword))
{
$test = "bye";
echo $test;
}
else
echo "wtf";
}
echo $test;
destroyiffound("b");
?>

[cags]

It does, it's just that strpos returns 0 (the position that it's in), which the if statement evaluates as being == FALSE. Proof...

 

$page = file_get_contents("http://www.google.com");
function destroyiffound($keyword) {
if(strpos($page, $keyword)===FALSE) {
   $test = "bye";
   echo $test;
} else
   echo "wtf";
}
echo $test;
destroyiffound("b");

 

EDIT: Ok ignore that, I've put the PEACE PIPE down now. Your right it doesn't find it, because you assign $page outside the function, it's not in scope inside the function. I'd recommend passing it in as a second value.

[cursed]

 

Thanks again cags for solving yet another one of my problems. 

 

I wonder where the solved button went..

 

edit: in your opinion, do you think setting it as a global variable is any good? file_get_contents increases load time by quite a bit, especially with large websites.

especially if I do

destroyiffound("a");

destroyiffound("b");

destroyiffound("c");

 

[cags]

Global variables are best avoided as much as possible. The exact solution depends on the rest of your code. Personally given the basic example you have their I would pass the url to the function as a second parameter and call file_get_contents from inside the function. But if $page is also used outside of the function simply pass $page as a second parameter.

 

$page = file_get_contents("http://www.google.com");
function destroyiffound($keyword, $page) {
if(strpos($page, $keyword)) {
   $test = "bye";
   echo $test;
} else
   echo "wtf";
}
echo $test;
destroyiffound("b", $page);

[cursed]

alright, thanks!