Highlight Function Issue

[Canman2005]

Hi all

 

I have the following function code to highlight text on a page

 

function highlight_words($str, $keywords = '')
{
$keywords = preg_replace('/\s\s+/', ' ', strip_tags(trim($keywords)));
$style = 'highlight';
$var = '';
foreach(explode(' ', $keywords) as $keyword)
{
$replacement = '<span class="highlight">'.$keyword.'</span>';
$var .= $replacement." ";
$str = eregi_replace($keyword, $replacement, $str);
}
print eregi_replace(rtrim($var), '<span class="highlight">'.$keywords.'</span>', $str);
}

 

and I use the function like

 

<?php highlight_words(''.$row_contents['title'].'',''.$_GET['q'].''); ?>

 

this works fine, but I have found an issue.

 

Basically I have a entry in my database titled

 

get a quote

 

If I use my highlight function and set the value of $_GET['q'] as

 

?q=get+a

 

then

 

Instead of simply doing

 

<span class="highlight">get</span> <span class="highlight">a</span> quote

 

like it should, it returns instead

 

<sp><span class="highlight">a</span>n cl<span class="highlight">a</span>ss="highlight">get</sp><span class="highlight">a</span>n> <span class="highlight">a</span> quote

 

Any ideas why this is happening?

 

Looks like it's treating the html tags are text to highlight

 

Any help would be magic

 

Thanks

 

Mark

[Canman2005]

any ideas anyone?

[JAY6390]

Try changing

$str = eregi_replace($keyword, $replacement, $str);

to

$str = preg_replace('%\b'.preg_quote($keyword).'\b%', $replacement, $str);

[lemmin]

Yes, it is finding "a" inside of the html code that you are adding for each additional keyword. One way around this is to make a string (or character) that is unlikely to occur to mark each area as being ready to highlight:

<?php
function highlight_words($str, $keywords = '')
{
   $keywords = preg_replace('/\s\s+/', ' ', strip_tags(trim($keywords)));
   $keywords = explode(' ', $keywords);
   foreach($keywords as $i => $keyword)
      $keywords[$i] = "/(".$keyword.")/";
      
   $str = preg_replace($keywords, '{[:[|$1|]:]}', $str);
   return preg_replace("/{\[:\[\|(.+?)\|\]:\]}/", '<span class="highlight">$1</span>', $str);
}

echo highlight_words("get a quote", "get a");
?>