Is this Safe or Unsafe?

LearningKid · December 2, 2009

Hi i made a few pages with lots of peoples help now i just want to know if they are safe or not can anyone help me?

here are the codes

Register

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

<html>
<head>
<title>luCa Prints Sign Up</title>
<Style>
BODY, P,TD{ font-family: Arial,Verdana,Helvetica, sans-serif; font-size: 10pt }
A{font-family: Arial,Verdana,Helvetica, sans-serif;}
B {	font-family : Arial, Helvetica, sans-serif;	font-size : 12px;	font-weight : bold;}
.error_strings{ font-family:Verdana; font-size:10px; color:#660000;}
</Style>
<script language="JavaScript" src="gen_validatorv31.js" type="text/javascript"></script>
</head>
<body>


<form name="myform" ACTION="regi.php" METHOD=get>
<table cellspacing="2" cellpadding="2" border="0" align="center">
<tr>
    <td align="right">*Username</td>
    <td><input type="text" name="username"></td>
</tr>
<tr>
    <td align="right">*Password</td>
    <td><input type="password" name="password1"></td>
</tr>
<tr>
    <td align="right">*Re-enter Password</td>
    <td><input type="password" name="password2"></td>
</tr>
<tr>
    <td align="right">*First Name</td>
    <td><input type="text" name="FirstName"></td>
</tr>
<tr>
    <td align="right">*Last Name</td>
    <td><input type="text" name="LastName"></td>
</tr>
<tr>
    <td align="right">Company</td>
    <td><input type="text" name="company"></td>
</tr>
<tr>
    <td align="right">Position</td>
    <td><input type="text" name="position"></td>
</tr>
<tr>
    <td align="right">*EMail</td>
    <td><input type="text" name="Email"></td>
</tr>
<tr>
    <td align="right">*Re-enter EMail</td>
    <td><input type="text" name="Email1"></td>
</tr>
<tr>
    <td align="right">*Daytime Number</td>
    <td><input type="text" name="Phone"></td>
</tr>
<tr>
    <td align="right">Other Number</td>
    <td><input type="text" name="Phone2"></td>
</tr>
<tr>
    <td align="right">*Address</td>
    <td><textarea cols="20" rows="5" name="Address"></textarea></td>
</tr>
<tr>
    <td align="right">*City</td>
    <td>
   <SELECT name="City">
	<option value="" selected>[choose yours]
	<option>Parika
	<option>Georgetown
	<option>New Amsterdam
	</SELECT>
</td>
</tr>
<tr>
    <td align="right">*County</td>
    <td>
   <SELECT name="County">
	<option value="" selected>[choose yours]
	<option>Essequibo
	<option>Demerara
	<option>Berbice
	</SELECT>
</td>
</tr>
<tr>
    <td align="right">*Security Question</td>
    <td>
   <SELECT name="sec_ques">
	<option value="" selected>[choose yours]
	<option>What is my name?
	<option>Where do I live?
	<option>My Favourite Pet
	</SELECT>
</td>
</tr>

<tr>
    <td align="right">*Answer</td>
    <td><input type="password" name="sec_ans"></td>
</tr>
<tr>
    <td align="right"><input type="checkbox" name="ckb"></td>
    <td>Please check here if you would like to receive special offers,<br>notification of valuable promotions via company mailings,<br>email contact, telemarketing, catalogues, etc., from us.<br>(Note: You can unsubscribe at any time.)</td>
</tr>
<tr>
    <td align="right"><input type="checkbox" name="ckb2"></td>
    <td>Please check here if you are a business customer</td>
</tr>

<tr>
    <td align="right"></td>
    <td>
<div id='myform_errorloc' class='error_strings'>
                              </div>
</td>
</tr>
<tr>
    <td align="right"></td>
    <td><input type="submit" value="Submit"></td>
</tr>
</table>
</form>
<script language="JavaScript" type="text/javascript">
//You should create the validator only after the definition of the HTML form
  var frmvalidator  = new Validator("myform");
frmvalidator.EnableOnPageErrorDisplaySingleBox();
frmvalidator.EnableMsgsTogether();
  
  frmvalidator.addValidation("username","req","Please enter your Username");
  frmvalidator.addValidation("username","maxlen=20","For Username, Max length is 20");
  
  frmvalidator.addValidation("FirstName","req","Please enter your First Name");
  frmvalidator.addValidation("FirstName","maxlen=30",	"Max length for FirstName is 30");
  frmvalidator.addValidation("FirstName","alpha_s","Name can contain alphabetic chars only");
  
  frmvalidator.addValidation("LastName","req","Please enter your Last Name");
  frmvalidator.addValidation("LastName","maxlen=40","For LastName, Max length is 40");
  
  frmvalidator.addValidation("Email","maxlen=100");
  frmvalidator.addValidation("Email","req");
  frmvalidator.addValidation("Email","email");
  
  frmvalidator.addValidation("Phone","maxlen=11");
  frmvalidator.addValidation("Phone","numeric");
  frmvalidator.addValidation("Phone","req","Please Enter a Daytime Number");
  frmvalidator.addValidation("City","req");  
  frmvalidator.addValidation("Address","maxlen=50");
  frmvalidator.addValidation("County","req","Please select your County");
  frmvalidator.addValidation("sec_ques","req","Please enter your Security Question");
  frmvalidator.addValidation("sec_ans","req","Please enter your Answer");
  
 function DoCustomValidation()
{
  var frm = document.forms["myform"];
  if(frm.FirstName.value == 'Anil')
  {
    sfm_show_error_msg("Anil, you can't submit this form. Go away! ");
    return false;
  }
  else
  {
    return true;
  }
}

  frmvalidator.setAddnlValidationFunction("DoCustomValidation");
</script>


</body>
</html>

Java validator

/*
  -------------------------------------------------------------------------
	      JavaScript Form Validator (gen_validatorv31.js)
              Version 3.1.2
Copyright (C) 2003-2008 JavaScript-Coder.com. All rights reserved.
You can freely use this script in your Web pages.
You may adapt this script for your own needs, provided these opening credit
    lines are kept intact.

The Form validation script is distributed free from JavaScript-Coder.com
For updates, please visit:
http://www.javascript-coder.com/html-form/javascript-form-validation.phtml

Questions & comments please send to form.val at javascript-coder.com
  -------------------------------------------------------------------------  
*/
function Validator(frmname)
{
  this.formobj=document.forms[frmname];
if(!this.formobj)
{
  alert("Error: couldnot get Form object "+frmname);
	return;
}
if(this.formobj.onsubmit)
{
 this.formobj.old_onsubmit = this.formobj.onsubmit;
 this.formobj.onsubmit=null;
}
else
{
 this.formobj.old_onsubmit = null;
}
this.formobj._sfm_form_name=frmname;
this.formobj.onsubmit=form_submit_handler;
this.addValidation = add_validation;
this.setAddnlValidationFunction=set_addnl_vfunction;
this.clearAllValidations = clear_all_validations;
    this.disable_validations = false;//new
    document.error_disp_handler = new sfm_ErrorDisplayHandler();
    this.EnableOnPageErrorDisplay=validator_enable_OPED;
this.EnableOnPageErrorDisplaySingleBox=validator_enable_OPED_SB;
    this.show_errors_together=true;
    this.EnableMsgsTogether=sfm_enable_show_msgs_together;
    document.set_focus_onerror=true;
    this.EnableFocusOnError=sfm_validator_enable_focus;

}

function sfm_validator_enable_focus(enable)
{
    document.set_focus_onerror = enable;
}

function set_addnl_vfunction(functionname)
{
  this.formobj.addnlvalidation = functionname;
}

function sfm_set_focus(objInput)
{
    if(document.set_focus_onerror)
    {
        objInput.focus();
    }
}

function sfm_enable_show_msgs_together()
{
    this.show_errors_together=true;
    this.formobj.show_errors_together=true;
}
function clear_all_validations()
{
for(var itr=0;itr < this.formobj.elements.length;itr++)
{
	this.formobj.elements[itr].validationset = null;
}
}

function form_submit_handler()
{
   var bRet = true;
    document.error_disp_handler.clear_msgs();
for(var itr=0;itr < this.elements.length;itr++)
{
	if(this.elements[itr].validationset &&
   !this.elements[itr].validationset.validate())
	{
	  bRet = false;
	}
        if(!bRet && !this.show_errors_together)
        {
          break;

        }
}

if(this.addnlvalidation)
{
  str =" var ret = "+this.addnlvalidation+"()";
  eval(str);

     if(!ret) 
     {
       bRet=false; 
     }

}

   if(!bRet)
    {
      document.error_disp_handler.FinalShowMsg();
      return false;
    }
return true;
}

function add_validation(itemname,descriptor,errstr)
{
var condition = null;
if(arguments.length > 3)
{
 condition = arguments[3]; 
}
  if(!this.formobj)
{
	alert("Error: The form object is not set properly");
	return;
}//if
var itemobj = this.formobj[itemname];
    if(itemobj.length && isNaN(itemobj.selectedIndex) )
    //for radio button; don't do for 'select' item
{
	itemobj = itemobj[0];
}	
  if(!itemobj)
{
	alert("Error: Couldnot get the input object named: "+itemname);
	return;
}
if(!itemobj.validationset)
{
	itemobj.validationset = new ValidationSet(itemobj,this.show_errors_together);
}
itemobj.validationset.add(descriptor,errstr,condition);
    itemobj.validatorobj=this;
}
function validator_enable_OPED()
{
    document.error_disp_handler.EnableOnPageDisplay(false);
}

function validator_enable_OPED_SB()
{
document.error_disp_handler.EnableOnPageDisplay(true);
}
function sfm_ErrorDisplayHandler()
{
  this.msgdisplay = new AlertMsgDisplayer();
  this.EnableOnPageDisplay= edh_EnableOnPageDisplay;
  this.ShowMsg=edh_ShowMsg;
  this.FinalShowMsg=edh_FinalShowMsg;
  this.all_msgs=new Array();
  this.clear_msgs=edh_clear_msgs;
}
function edh_clear_msgs()
{
    this.msgdisplay.clearmsg(this.all_msgs);
    this.all_msgs = new Array();
}
function edh_FinalShowMsg()
{
    this.msgdisplay.showmsg(this.all_msgs);
}
function edh_EnableOnPageDisplay(single_box)
{
if(true == single_box)
{
	this.msgdisplay = new SingleBoxErrorDisplay();
}
else
{
	this.msgdisplay = new DivMsgDisplayer();		
}
}
function edh_ShowMsg(msg,input_element)
{

   var objmsg = new Array();
   objmsg["input_element"] = input_element;
   objmsg["msg"] =  msg;
   this.all_msgs.push(objmsg);
}
function AlertMsgDisplayer()
{
  this.showmsg = alert_showmsg;
  this.clearmsg=alert_clearmsg;
}
function alert_clearmsg(msgs)
{

}
function alert_showmsg(msgs)
{
    var whole_msg="";
    var first_elmnt=null;
    for(var m=0;m < msgs.length;m++)
    {
        if(null == first_elmnt)
        {
            first_elmnt = msgs[m]["input_element"];
        }
        whole_msg += msgs[m]["msg"] + "\n";
    }

    alert(whole_msg);

    if(null != first_elmnt)
    {
        sfm_set_focus(first_elmnt);
    }
}
function sfm_show_error_msg(msg,input_elmt)
{
    document.error_disp_handler.ShowMsg(msg,input_elmt);
}
function SingleBoxErrorDisplay()
{
this.showmsg=sb_div_showmsg;
this.clearmsg=sb_div_clearmsg;
}

function sb_div_clearmsg(msgs)
{
var divname = form_error_div_name(msgs);
show_div_msg(divname,"");
}

function sb_div_showmsg(msgs)
{
var whole_msg="<ul>\n";
for(var m=0;m < msgs.length;m++)
    {
        whole_msg += "<li>" + msgs[m]["msg"] + "</li>\n";
    }
whole_msg += "</ul>";
var divname = form_error_div_name(msgs);
show_div_msg(divname,whole_msg);
}
function form_error_div_name(msgs)
{
var input_element= null;

for(var m in msgs)
{
 input_element = msgs[m]["input_element"];
 if(input_element){break;}
}

var divname ="";
if(input_element)
{
 divname = input_element.form._sfm_form_name + "_errorloc";
}

return divname;
}
function DivMsgDisplayer()
{
this.showmsg=div_showmsg;
this.clearmsg=div_clearmsg;
}
function div_clearmsg(msgs)
{
    for(var m in msgs)
    {
        var divname = element_div_name(msgs[m]["input_element"]);
        show_div_msg(divname,"");
    }
}
function element_div_name(input_element)
{
  var divname = input_element.form._sfm_form_name + "_" + 
                   input_element.name + "_errorloc";

  divname = divname.replace(/[\[\]]/gi,"");

  return divname;
}
function div_showmsg(msgs)
{
    var whole_msg;
    var first_elmnt=null;
    for(var m in msgs)
    {
        if(null == first_elmnt)
        {
            first_elmnt = msgs[m]["input_element"];
        }
        var divname = element_div_name(msgs[m]["input_element"]);
        show_div_msg(divname,msgs[m]["msg"]);
    }
    if(null != first_elmnt)
    {
        sfm_set_focus(first_elmnt);
    }
}
function show_div_msg(divname,msgstring)
{
if(divname.length<=0) return false;

if(document.layers)
{
	divlayer = document.layers[divname];
        if(!divlayer){return;}
	divlayer.document.open();
	divlayer.document.write(msgstring);
	divlayer.document.close();
}
else
if(document.all)
{
	divlayer = document.all[divname];
        if(!divlayer){return;}
	divlayer.innerHTML=msgstring;
}
else
if(document.getElementById)
{
	divlayer = document.getElementById(divname);
        if(!divlayer){return;}
	divlayer.innerHTML =msgstring;
}
divlayer.style.visibility="visible";	
}

function ValidationDesc(inputitem,desc,error,condition)
{
  this.desc=desc;
this.error=error;
this.itemobj = inputitem;
this.condition = condition;
this.validate=vdesc_validate;
}
function vdesc_validate()
{
if(this.condition != null )
{
	if(!eval(this.condition))
	{
		return true;
	}
}
if(!validateInput(this.desc,this.itemobj,this.error))
{
	this.itemobj.validatorobj.disable_validations=true;

	sfm_set_focus(this.itemobj);

	return false;
}
return true;
}
function ValidationSet(inputitem,msgs_together)
{
    this.vSet=new Array();
this.add= add_validationdesc;
this.validate= vset_validate;
this.itemobj = inputitem;
    this.msgs_together = msgs_together;
}
function add_validationdesc(desc,error,condition)
{
  this.vSet[this.vSet.length]= 
  new ValidationDesc(this.itemobj,desc,error,condition);
}
function vset_validate()
{
    var bRet = true;
    for(var itr=0;itr<this.vSet.length;itr++)
    {
        bRet = bRet && this.vSet[itr].validate();
        if(!bRet && !this.msgs_together)
        {
            break;
        }
    }
    return bRet;
}
function validateEmail(email)
{
    var splitted = email.match("^(.+)@(.+)$");
    if(splitted == null) return false;
    if(splitted[1] != null )
    {
      var regexp_user=/^\"?[\w-_\.]*\"?$/;
      if(splitted[1].match(regexp_user) == null) return false;
    }
    if(splitted[2] != null)
    {
      var regexp_domain=/^[\w-\.]*\.[A-Za-z]{2,4}$/;
      if(splitted[2].match(regexp_domain) == null) 
      {
    var regexp_ip =/^\[\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}\]$/;
    if(splitted[2].match(regexp_ip) == null) return false;
      }// if
      return true;
    }
return false;
}

function IsCheckSelected(objValue,chkValue)
{
    var selected=false;
var objcheck = objValue.form.elements[objValue.name];
    if(objcheck.length)
{
	var idxchk=-1;
	for(var c=0;c < objcheck.length;c++)
	{
	   if(objcheck[c].value == chkValue)
	   {
	     idxchk=c;
		 break;
	   }//if
	}//for
	if(idxchk>= 0)
	{
	  if(objcheck[idxchk].checked=="1")
	  {
	    selected=true;
	  }
	}//if
}
else
{
	if(objValue.checked == "1")
	{
		selected=true;
	}//if
}//else	

return selected;
}
function TestDontSelectChk(objValue,chkValue,strError)
{
var pass = true;
pass = IsCheckSelected(objValue,chkValue)?false:true;

if(pass==false)
{
     if(!strError || strError.length ==0) 
        { 
        	strError = "Can't Proceed as you selected "+objValue.name;  
        }//if			  
  sfm_show_error_msg(strError,objValue);
  
}
    return pass;
}
function TestShouldSelectChk(objValue,chkValue,strError)
{
var pass = true;

pass = IsCheckSelected(objValue,chkValue)?true:false;

if(pass==false)
{
     if(!strError || strError.length ==0) 
        { 
        	strError = "You should select "+objValue.name;  
        }//if			  
  sfm_show_error_msg(strError,objValue);
  
}
    return pass;
}
function TestRequiredInput(objValue,strError)
{
var ret = true;
var val = objValue.value;
val = val.replace(/^\s+|\s+$/g,"");//trim
    if(eval(val.length) == 0) 
    { 
       if(!strError || strError.length ==0) 
       { 
         strError = objValue.name + " : Required Field"; 
       }//if 
       sfm_show_error_msg(strError,objValue); 
       ret=false; 
    }//if 
return ret;
}
function TestMaxLen(objValue,strMaxLen,strError)
{
var ret = true;
    if(eval(objValue.value.length) > eval(strMaxLen)) 
    { 
      if(!strError || strError.length ==0) 
      { 
        strError = objValue.name + " : "+ strMaxLen +" characters maximum "; 
      }//if 
      sfm_show_error_msg(strError,objValue); 
      ret = false; 
    }//if 
return ret;
}
function TestMinLen(objValue,strMinLen,strError)
{
var ret = true;
    if(eval(objValue.value.length) <  eval(strMinLen)) 
    { 
      if(!strError || strError.length ==0) 
      { 
        strError = objValue.name + " : " + strMinLen + " characters minimum  "; 
      }//if               
      sfm_show_error_msg(strError,objValue); 
      ret = false;   
    }//if 
return ret;
}
function TestInputType(objValue,strRegExp,strError,strDefaultError)
{
   var ret = true;

    var charpos = objValue.value.search(strRegExp); 
    if(objValue.value.length > 0 &&  charpos >= 0) 
    { 
     if(!strError || strError.length ==0) 
      { 
        strError = strDefaultError;
      }//if 
      sfm_show_error_msg(strError,objValue); 
      ret = false; 
    }//if 
return ret;
}
function TestEmail(objValue,strError)
{
var ret = true;
     if(objValue.value.length > 0 && !validateEmail(objValue.value)	 ) 
     { 
       if(!strError || strError.length ==0) 
       { 
          strError = objValue.name+": Enter a valid Email address "; 
       }//if                                               
       sfm_show_error_msg(strError,objValue); 
       ret = false; 
     }//if 
return ret;
}
function TestLessThan(objValue,strLessThan,strError)
{
var ret = true;
  if(isNaN(objValue.value)) 
  { 
    sfm_show_error_msg(objValue.name +": Should be a number ",objValue); 
    ret = false; 
  }//if 
  else
  if(eval(objValue.value) >=  eval(strLessThan)) 
  { 
    if(!strError || strError.length ==0) 
    { 
      strError = objValue.name + " : value should be less than "+ strLessThan; 
    }//if               
    sfm_show_error_msg(strError,objValue); 
    ret = false;                 
   }//if   
return ret;          
}
function TestGreaterThan(objValue,strGreaterThan,strError)
{
var ret = true;
     if(isNaN(objValue.value)) 
     { 
       sfm_show_error_msg(objValue.name+": Should be a number ",objValue); 
       ret = false; 
     }//if 
 else
     if(eval(objValue.value) <=  eval(strGreaterThan)) 
      { 
        if(!strError || strError.length ==0) 
        { 
          strError = objValue.name + " : value should be greater than "+ strGreaterThan; 
        }//if               
        sfm_show_error_msg(strError,objValue);  
        ret = false;
      }//if  
return ret;           
}
function TestRegExp(objValue,strRegExp,strError)
{
var ret = true;
    if( objValue.value.length > 0 && 
        !objValue.value.match(strRegExp) ) 
    { 
      if(!strError || strError.length ==0) 
      { 
        strError = objValue.name+": Invalid characters found "; 
      }//if                                                               
      sfm_show_error_msg(strError,objValue); 
      ret = false;                   
    }//if 
return ret;
}
function TestDontSelect(objValue,dont_sel_index,strError)
{
var ret = true;
    if(objValue.selectedIndex == null) 
    { 
      sfm_show_error_msg("ERROR: dontselect command for non-select Item"); 
      ret =  false; 
    } 
    if(objValue.selectedIndex == eval(dont_sel_index)) 
    { 
     if(!strError || strError.length ==0) 
      { 
      strError = objValue.name+": Please Select one option "; 
      }//if                                                               
      sfm_show_error_msg(strError,objValue); 
      ret =  false;                                   
     } 
return ret;
}
function TestSelectOneRadio(objValue,strError)
{
var objradio = objValue.form.elements[objValue.name];
var one_selected=false;
for(var r=0;r < objradio.length;r++)
{
  if(objradio[r].checked)
  {
  	one_selected=true;
	break;
  }
}
if(false == one_selected)
{
      if(!strError || strError.length ==0) 
       {
    strError = "Please select one option from "+objValue.name;
   }	
  sfm_show_error_msg(strError,objValue);
}
return one_selected;
}

function validateInput(strValidateStr,objValue,strError) 
{ 
    var ret = true;
    var epos = strValidateStr.search("="); 
    var  command  = ""; 
    var  cmdvalue = ""; 
    if(epos >= 0) 
    { 
     command  = strValidateStr.substring(0,epos); 
     cmdvalue = strValidateStr.substr(epos+1); 
    } 
    else 
    { 
     command = strValidateStr; 
    } 
    switch(command) 
    { 
        case "req": 
        case "required": 
         { 
	   ret = TestRequiredInput(objValue,strError)
           break;             
         }//case required 
        case "maxlength": 
        case "maxlen": 
          { 
		 ret = TestMaxLen(objValue,cmdvalue,strError)
             break; 
          }//case maxlen 
        case "minlength": 
        case "minlen": 
           { 
		 ret = TestMinLen(objValue,cmdvalue,strError)
             break; 
            }//case minlen 
        case "alnum": 
        case "alphanumeric": 
           { 
			ret = TestInputType(objValue,"[^A-Za-z0-9]",strError, 
					objValue.name+": Only alpha-numeric characters allowed ");
			break; 
           }
        case "alnum_s": 
        case "alphanumeric_space": 
           { 
			ret = TestInputType(objValue,"[^A-Za-z0-9\\s]",strError, 
					objValue.name+": Only alpha-numeric characters and space allowed ");
			break; 
           }		   
        case "num": 
        case "numeric": 
           { 
                ret = TestInputType(objValue,"[^0-9]",strError, 
					objValue.name+": Only digits allowed ");
                break;               
           }
        case "dec": 
        case "decimal": 
           { 
                ret = TestInputType(objValue,"[^0-9\.]",strError, 
					objValue.name+": Only numbers allowed ");
                break;               
           }
        case "alphabetic": 
        case "alpha": 
           { 
                ret = TestInputType(objValue,"[^A-Za-z]",strError, 
					objValue.name+": Only alphabetic characters allowed ");
                break; 
           }
        case "alphabetic_space": 
        case "alpha_s": 
           { 
                ret = TestInputType(objValue,"[^A-Za-z\\s]",strError, 
					objValue.name+": Only alphabetic characters and space allowed ");
                break; 
           }
        case "email": 
          { 
		   ret = TestEmail(objValue,strError);
               break; 
          }
        case "lt": 
        case "lessthan": 
         { 
    	      ret = TestLessThan(objValue,cmdvalue,strError);
              break; 
         }
        case "gt": 
        case "greaterthan": 
         { 
		ret = TestGreaterThan(objValue,cmdvalue,strError);
            break; 
         }//case greaterthan 
        case "regexp": 
         { 
		ret = TestRegExp(objValue,cmdvalue,strError);
           break; 
         }
        case "dontselect": 
         { 
		 ret = TestDontSelect(objValue,cmdvalue,strError)
             break; 
         }
	case "dontselectchk":
	{
		ret = TestDontSelectChk(objValue,cmdvalue,strError)
		break;
	}
	case "shouldselchk":
	{
		ret = TestShouldSelectChk(objValue,cmdvalue,strError)
		break;
	}
	case "selone_radio":
	{
		ret = TestSelectOneRadio(objValue,strError);
	    break;
	}		 
    }//switch 
return ret;
}
function VWZ_IsListItemSelected(listname,value)
{
for(var i=0;i < listname.options.length;i++)
{
  if(listname.options[i].selected == true &&
   listname.options[i].value == value) 
   {
     return true;
   }
}
return false;
}
function VWZ_IsChecked(objcheck,value)
{
if(objcheck.length)
{
     for(var c=0;c < objcheck.length;c++)
     {
       if(objcheck[c].checked == "1" && 
     objcheck[c].value == value)
       {
        return true; 
       }
     }
}
else
{
  if(objcheck.checked == "1" )
   {
    return true; 
   }    
}
return false;
}
/*
Copyright (C) 2003-2009 JavaScript-Coder.com . All rights reserved.
*/

regi

<?php
$host="localhost"; // Host name
$username="root"; // Mysql username
$password=""; // Mysql password
$db_name="test"; // Database name
$tbl_name="customers"; // Table name
// Connect to server and select databse.
mysql_connect("$host", "$username", "$password")or die("cannot connect");
mysql_select_db("$db_name")or die("cannot select DB");

if($_GET["username"] && $_GET["password1"] && $_GET["password2"] && $_GET["FirstName"] && $_GET["LastName"] && $_GET["Email"] && $_GET["Email1"]
&& $_GET["Phone"] && $_GET["Phone2"] && $_GET["Address"] && $_GET["County"] && $_GET["City"] && $_GET["sec_ques"] 
&& $_GET["sec_ans"] )
{
  $sql=mysql_query("SELECT * FROM customers WHERE username='$_GET[username]'");
$result = mysql_fetch_row($sql);
if($result==0){

  
   if($_GET["password1"]==$_GET["password2"])
    {
     if ($_GET["Email"]==$_GET["Email1"]) 
      {
   
    $servername="localhost";
      $username="root";
      $conn=  mysql_connect($servername,$username)or die(mysql_error());
      mysql_select_db("test",$conn);
      $sql="insert into customers (username,password,email,first_name,last_name,county,city,street_address,tel_number,second_number,security_quest,security_answer)
      values('$_GET[username]','$_GET[password1]','$_GET[Email]','$_GET[FirstName]','$_GET[LastName]','$_GET[County]','$_GET[City]',
      '$_GET[Address]','$_GET[Phone]','$_GET[Phone2]','$_GET[sec_ques]','$_GET[sec_ans]')";
      
      $result=mysql_query($sql,$conn) or die(mysql_error());		
      print "<h1>you have registered sucessfully</h1>";
   
      print "<a href='login.php'>go to login page</a>";
   }
      else print "Email doesnt match";
   }
    else print "passwords doesnt match";
  }
   else print "username already in use please select another";
}
   else print "try again";

$query = "SELECT * FROM customers order by id DESC LIMIT 0, 1";     //Assuming your ID is set to id  
$result = mysql_query($query) or die(mysql_error());
     while($row = mysql_fetch_array($result)){
            $users_id = $row['id'];   
     }
?>

login

<table width="300" border="0" align="center" cellpadding="0" cellspacing="1" bgcolor="#CCCCCC">
<tr>
<form name="form1" method="post" action="cheklog.php">
<td>
<table width="100%" border="0" cellpadding="3" cellspacing="1" bgcolor="#FFFFFF">
<tr>
<td colspan="3"><strong>Member Login </strong></td>
</tr>
<tr>
<td width="78">Username</td>
<td width="6">:</td>
<td width="294"><input name="myusername" type="text" id="myusername"></td>
</tr>
<tr>
<td>Password</td>
<td>:</td>
<td><input name="mypassword" type="password" id="mypassword"></td>
</tr>
<tr>
<td> </td>
<td> </td>
<td><input type="submit" name="Submit" value="Login">    <a href="register.php">Sign Up</a></td>
</tr>
</table>
</td>
</form>
</tr>
</table>

check login

<?php
$host="localhost"; // Host name
$username=""; // Mysql username
$password=""; // Mysql password
$db_name="test"; // Database name
$tbl_name="customers"; // Table name

// Connect to server and select databse.
mysql_connect("$host", "$username")or die("cannot connect");
mysql_select_db("$db_name")or die("cannot select DB");

// username and password sent from form
$myusername=$_POST['myusername'];
$mypassword=$_POST['mypassword'];

// To protect MySQL injection (more detail about MySQL injection)
$myusername = stripslashes($myusername);
$mypassword = stripslashes($mypassword);
$myusername = mysql_real_escape_string($myusername);
$mypassword = mysql_real_escape_string($mypassword);

$sql="SELECT * FROM $tbl_name WHERE username='$myusername' and password='$mypassword'";
$result=mysql_query($sql);

// Mysql_num_row is counting table row
$count=mysql_num_rows($result);
// If result matched $myusername and $mypassword, table row must be 1 row

if($count==1){
// Register $myusername, $mypassword and redirect to file "login_success.php"
session_register("myusername");
session_register("mypassword");
header("location:main.php");
}
else {
echo "Wrong Username or Password";
}
?>

Would greatly apprecviate any help or comments

Thank You

KevinM1 · December 2, 2009

Not safe.

First, and this is only because it's a pet peeve of mine, JavaScript != Java. The two have nothing to do with each other. JavaScript is a version of ECMAScript, developed by Netscape, and later, Mozilla. The 'Java' in its name was a marketing decision made when the actual Java language was hyped to be the best thing ever in the mid-to-late 90's. Java is a full-fledged OOP programming language that runs on a virtual machine. It was developed by Sun Microsystems.

So, with that out of the way...

You need server side validation. Why? Because JavaScript can be turned off in the browser. That's as safe as guarding Fort Knox with bad language. JavaScript validation should only be viewed as a courtesy to your users, as it facilitates a more interactive experience. Server side validation is a must.

Also, I suggest passing your values by post rather than get. While nothing is stopping a malicious person from making their own form and posting values from it to your script, at least they won't be tweaking values right in the address bar.

Sign In

Is this Safe or Unsafe?

Recommended Posts

LearningKid

Link to comment

Share on other sites

KevinM1

Link to comment

Share on other sites

Join the conversation

Browse

Activity

Important Information