str_replace Help!

[stuckwithcode]

I am trying to make sure that all line breaks in a piece of text are converted to \r\n.  When I use the code below for:

 

a

b

c

 

$text = str_replace(array("\r\n","\r","\n"), "\r\n", $text);

 

 

After using mysql_real_escape_string the output shows:

 

a\r\r\n\r\nb\r\r\n\r\nc

 

Where am I going wrong? I expected it to remain at a\r\nb\r\nc

 

If I use $text = str_replace(array("\r\n","\r","\n"), "\r", $text); , it works.

 

 

[rajivgonsalves]

I am not sure what could be wrong with the code but you can use preg_replace instead

 

$text = preg_replace('#[\r\n]+#', "\r\n", $text);

 

[oni-kun]

Your code is of error, say there already is an \r\n on the page, You'll be replacing it in order, so \r\n = \r\n = \r\r\n\r\n ...

 

The order of the array is important, so you should use something like Rajivgonsalvas' code.

[stuckwithcode]

oni-kun Thanks for the reply but I didn't quite understand your explanation of how I got

 

a\r\r\n\r\nb\r\r\n\r\nc

 

and could someone explain how

 

$text = preg_replace('#[\r\n]+#', "\r\n", $text);

 

works.

[oni-kun]

oni-kun Thanks for the reply but I didn't quite understand your explanation of how I got

 

a\r\r\n\r\nb\r\r\n\r\nc

 

and could someone explain how

 

$text = preg_replace('#[\r\n]+#', "\r\n", $text);

 

works.

 

You're using an array in your str_replace function. What the array does, is essentially iterates through each one and replaces it.

(\r, \n, \r\n)

 

\r \n and \r\n will be replaced. So if on the page there is '\n', it'll become '\r\n'. Then what?  There's more elements in the array you have. the '\r' in '\r\n' will become '\r\n\r', and again, '\r\r\n\r'. The array makes you replace the replacement's replacement in other words, you're overwriting your result.

[stuckwithcode]

thanks for the help.

[salathe]

To avoid replacing already replaced values, you could instead use the strtr function.