problem with $_GET and foreach(glob())

[arbitter]

So I have 2 columns, one on the left hand side with:

foreach (glob('*',GLOB_ONLYDIR) as $map)
			{ echo "<tr><td><a href='?month=$map'>$map</a></td></tr>";}

So that all my maps with images (January '10, February '10,...) get shown with link as "uploads/January '10"

Now some problems are with the space, as the script returns

http://localhost/depypere/uploads/uploads.php?month=January

instead of

http://localhost/depypere/uploads/uploads.php?month=January '10

logical, but nevertheless, I tried to fix that. This goes n the right-hand column:

 

$month = $_GET["month"];
$month .= " '10";
foreach (glob('$month/*.jpg') as $image)
{ echo "<center><img src='$image' style='max-width: 70%'></br>";}

 

But that doesn't work at all...

any help?

[salathe]

foreach (glob('*',GLOB_ONLYDIR) as $map)
{
    $qmap = urlencode($map);
    echo "<tr><td><a href='?month=$qmap'>$map</a></td></tr>";
}

 

The single quote in the variable's value was causing your HTML to be broken. Values going into URLs should be urlencoded so that the constructed URL contains only URL-safe characters (and has the added bonus of fixing your HTML issue).

[arbitter]

now the url shipped back to my form is

uploads.php?month=January+'10

so that's not right eather...

[arbitter]

Okay I so the url that goes back to my php file is still"/January+'10" (is that bad?)

BUT I do get broken images in my right-column, though the images don't show, they are the right amount of broken-images... I have 10 images in my uploads/ file and I get 10 small boxes as if the files are missing...

[laffin]

nope, in your processing script use urldecode.

$month=urldecode($_GET['month']);

[salathe]

$_GET values are automatically decoded. Unless the query string contains double-encoded values, calling urldecode is not necessary.

[laffin]

the '+' is a sign that the url parameter is still encoded.

[salathe]

The OP never said that value was visible in his script or as the URL being visited. arbitter, are you still having problems and if so can you give us more precise details in order to help us help you.

[arbitter]

The problem is that the images I want do not get shown...

There are boxes, the same amount as there are photo's, but it's a box as if the image is not in place, though I do get the right amount of boxes as there are images...

$month = $_GET["month"];
			foreach (glob($month . '/*.jpg') as $image)
				{ echo "<center><img src='$image'></br>";}

 

before clicking january; this part is good (if I add directory february '10 it gets shown too)

 

After clicking january '10

url: http://localhost/depypere/uploads/uploads.php?month=January+'10

 

another question, how do I get jpg/jpeg/gif/pjpeg in one glob?

 

 

[arbitter]

Ok, I think to know the problem; it is echo "<img src='$image'></br>"

but the $image returns "January '10"

the ' in the $image breaks off the src for the image, so the images don't get displayed.

How do I get around this?

[arbitter]

fixed it; echo "<img src=\"$image\"></br>"

 

only one question, how do you put multiple formats in the glob() function? I suppose there's an easier way than glob($month./*.jpg, $month . /*.gif, ....

[salathe]

Look in the manual for GLOB_BRACE.

[arbitter]

GLOB_BRACE lijkt me niet te werken, hoe ik het ook draai of keer...

heb andere fora onderzocht voor een polossing; ze zeggen meestal dat:

glob($upload_dir."*.{gif,JPG,jpg,GIF}", GLOB_BRACE)

werkt, maar bij mij precies niet...

[salathe]

Have you tried glob($month . '/*.{jpg,JPG,gif,GIF}', GLOB_BRACE) ?

[arbitter]

Oh my I'm so sorry,my last reply was in Dutch in stead of english..

 

but that last one does work yes, don't really know why it didn't, perhaps the " or however you call that.

 

Thanks a bunch!

[salathe]

Oh my I'm so sorry,my last reply was in Dutch in stead of english..

Hehe no problem. Glad to see the problem solved.