Question: Default Values of Functions

[Lamez]

I am working on a function that makes a list out of an existing array, this website was pre-made, and I cannot locate the list for the life of me. How can I make a default value in function based off of a variable?

 

<?php
function makeSportList($name = "", $sportList = $sport_list){
$list = '<select name="sport" id="sport">';
$list .= '<option value="-1">All Sports</option>';
for ($i=0;$i<=count($sportList);$i++){
	if(md5(strtolower($name)) == md5(strtolower($sportList[$i]))){
		$sel = "SELECTED";
	}else{
		$sel = "";
	}
	$list .= '<option value="'.$sportList[$i].'" '.$sel.'>'.$sportList[$i].'</option>';
}
return $list.'</select>';
}
?>

 

The manual says nothing of this. :/

 

-thanks!

[taquitosensei]

the default value is in the function definition

function makeSportList($name="Default Value Goes Here", $sportlist=$sport_list)
{

}

 

[Lamez]

Like I mention, I think I mentioned, that returns a error:

 

Parse error: syntax error, unexpected T_VARIABLE in ...

 

Its the $foo = $bar.

 

Wait, I think I figured out how do this.

[trq]

How can I make a default value in function based off of a variable?

 

You can't. Functions are meant to be stand alone reusable bits of code, your logic would break that.

[trq]

Sorry, you could but it is a very poor design choice.

 

<?php
function makeSportList($name = "", $sportList = null) {
   if (is_numm($sportList)) {
     global $sport_list;
     $sportList = $sport_list;
   }
   $list = '<select name="sport" id="sport">';
   $list .= '<option value="-1">All Sports</option>';
   for ($i=0;$i<=count($sportList);$i++){
      if(md5(strtolower($name)) == md5(strtolower($sportList[$i]))){
         $sel = "SELECTED";
      }else{
         $sel = "";
      }
      $list .= '<option value="'.$sportList[$i].'" '.$sel.'>'.$sportList[$i].'</option>';
   }
   return $list.'</select>';
}
?>

 

Terrible idea.

[Lamez]

Thanks for the (not needed) help, I guess I had a brainfart (again), here is how I fixed it:

 

<?php
function makeSportList($sportList, $name = ""){
$list = '<select name="sport" id="sport">';
$list .= '<option value="-1">All Sports</option>';
for ($i=0;$i<=count($sportList);$i++){
	if(md5(strtolower($name)) === md5(strtolower($sportList[$i]))){
		$sel = "SELECTED";
	}else{
		$sel = "";
	}
	$list .= '<option value="'.$sportList[$i].'" '.$sel.'>'.$sportList[$i].'</option>';
}
return $list.'</select>';
}
echo makeSportList($sport_list);
echo "<br />";
echo makeSportList($sport_list, "football");
?>