anything wrong with this?

[seany123]

		$username = $_POST['username'];
	$password = md5($_POST['password']);

	$query = $db->execute("select * from `players` where `username`='". $username ."' & `password`='". $password ."'");
	if ($query->recordcount() <= 0)
	{
		$errormsg .= "You could not login! Please check your username/password!";
		$error = 1;
	}

 

anyone know who even though im putting the same password in correctly it dosnt wanna work?

 

 

edit:

 

i just echoed $password and its different to the one in my database!!! wtf

[PravinS]

Use AND instead of & in SELECT query

$query = $db->execute("select * from `players` where `username`='". $username ."' AND `password`='". $password ."'");

 

[dare87]

Are you doing any type of encryption? If you are then it would need to be something like this

 

$query = "SELECT * FROM players WHERE username='$username' AND password=SHA('$password')";

[oni-kun]

Are you doing any type of encryption? If you are then it would need to be something like this

 

$query = "SELECT * FROM players WHERE username='$username' AND password=SHA('$password')";

 

That is not an encryption, in fact it is the absolute opposite. He's not even using SHA1 (although I would recommend it)

[dare87]

He just said it didn't match when he echoed the password, I was just throwing out something that might help

[oni-kun]

He just said it didn't match when he echoed the password, I was just throwing out something that might help

 

Re-Rehashing a password within query with the wrong encryption wouldn't help.

[seany123]

i was setting

 

$password = md5($_POST['password']);

 

the problem wasnt in the code i gave... in fact it was in the form... i had the value in password set to <?=$_POST['password']?>

 

thanks for the help anyway

 

 

anyway is md5 or sha1 better?

[oni-kun]

i was setting

 

$password = md5($_POST['password']);

 

the problem wasnt in the code i gave... in fact it was in the form... i had the value in password set to <?=$_POST['password']?>

 

thanks for the help anyway

 

 

anyway is md5 or sha1 better?

 

To put it simple, None. But SHA1 is slightly more secure, less rainbow hashes in the wild.