need help with OOP please

[ch1326]

Got some errors from this code. need help please

 

<?php
class MYSQL {
	var $host = "localhost";
	var $user = "root";
	var $pass = "password";
	var $db = "userlist";

	function __construct($host, $user, $pass, $db){
		$this->host = $host;
		$this->user = $user;
		$this->pass = $pass;
		$this->db = $db;
	}

	public function query($sql){
		$this->connDB();
		$result = mysql_query($sql);
		return fetchArray($result);
	}

	public  function fetchArray($result){
		while ($row = mysql_fetch_array($result) ){
			echo "Name is ". $row["name"];
		}
	}

	public function connDB () {
		$conn = mysql_connect($this->host, $this->user, $this->pass);
		mysql_select_db($this->db, $conn);
	}
}

$example = new MYSQL();
echo $example->query("select * from user");
?>

[KevinM1]

Well, first, if you define your constructor to take arguments, you must actually pass arguments to it when you invoke it, unless you define those arguments as default arguments.  In other words, the following will throw an error:

 

class MYSQL 
{
   var $host = "localhost";
   var $user = "root";
   var $pass = "password";
   var $db = "userlist";
      
   function __construct($host, $user, $pass, $db)
   {
      $this->host = $host;
      $this->user = $user;
      $this->pass = $pass;
      $this->db = $db;
   }
}

$db = new MYSQL();

 

Whereas the following will not:

 

class MYSQL
{
   var $host = "localhost";
   var $user = "root";
   var $pass = "password";
   var $db = "userlist";
      
   function __construct($host = '', $user = '', $pass = '', $db = '')
   {
      $this->host = $host;
      $this->user = $user;
      $this->pass = $pass;
      $this->db = $db;
   }
}

$db = new MYSQL();

 

Note, however, that the constructor in this second example is pretty useless as written, as it will merely set all your data members to empty strings.

 

You should also use access modifiers for your data members.  The 'var' keyword works, but is essentially deprecated (it's a remnant of PHP 4), and makes those data members publicly accessible, which is pretty useless.  Data members should be protected or private, with appropriate getter and setter methods.

[Mchl]

Also:

1: 'var' should not be used in PHP5. Use proper visibility modifiers instead (public/protected/private)

2: If you're toying with mysql and OOP, why not give mysqli a try?

[hackalive]

go mysqli

[KevinM1]

  Quote

Also:

1: 'var' should not be used in PHP5. Use proper visibility modifiers instead (public/protected/private)

 

  Quote

You should also use access modifiers for your data members.  The 'var' keyword works, but is essentially deprecated (it's a remnant of PHP 4), and makes those data members publicly accessible, which is pretty useless.  Data members should be protected or private, with appropriate getter and setter methods.

 

[Mchl]

Like you read everything other people write

[KevinM1]

  Quote

Like you read everything other people write

 

I'm offended, sir, offended!  Pistols, at dawn.

[Mchl]

I'm sleeping at dawn. Does noon suit you? Sir?

[ignace]

  Quote

Like you read everything other people write

 

Has this something to do with you thinking everyone else besides you is incapable of helping? Such arrogance

[KevinM1]

  Quote

I'm sleeping at dawn. Does noon suit you? Sir?

 

I'm eating at noon.

 

Is early evening acceptable, sir?

[Mchl]

I think your early evening is close to my midinight, sir.

[ignace]

  Quote

I think your early evening is close to my midinight, sir.

 

Maybe you could both just hire a mercenary and let them duke it out