My code is a bit cumbersome!

[yakoup46]

<title>The Java Project</title>

<?php

 

if(isset($_POST['buttonsumofodds']) || $_POST['inputbox1'])

{

$sql="INSERT INTO Sumofodds (ValueOdds) VALUES ('$_POST[inputbox1]')";

 

if($_POST[inputbox1] != 280)

{

echo "Sorry Wrong!";

session_start(); 

if(isset($_SESSION['views1']))

{

    $_SESSION['views1'] = $_SESSION['views1']+ 1;

}

 

else

{

    $_SESSION['views1'] = 1;

}

}

 

 

else

{

echo "Correct!";

}

 

echo "<br>Number of incorrect answers = ". $_SESSION['views1'];

}

 

if(isset($_POST['buttonsumofchain']) || $_POST['inputbox3'])

{

$sql="INSERT INTO Sumofchain (ValueChain) VALUES ('$_POST[inputbox3]')";

 

if($_POST[inputbox3] != 820)

{

echo "Sorry Wrong!";

session_start();

if(isset($_SESSION['views3']))

{

    $_SESSION['views3'] = $_SESSION['views3']+ 1;

}

else

{

    $_SESSION['views3'] = 1;

}

}

else

{

echo "Correct!";

}

 

echo "<br>Number of incorrect answers = ". $_SESSION['views3'];

}

 

if(isset($_POST['buttonsumofsquares']) || $_POST['inputbox2'])

{

$sql="INSERT INTO Sumofsquares (ValueSquares) VALUES ('$_POST[inputbox2]')";

 

if($_POST[inputbox2] != 2870)

{

echo "Sorry Wrong!";

session_start(); 

if(isset($_SESSION['views2']))

{

    $_SESSION['views2'] = $_SESSION['views2']+ 1;

}

else

{

    $_SESSION['views2'] = 1;

}

 

 

}

else

{

echo "Correct!";

}

 

echo "<br>Number of incorrect answers = ". $_SESSION['views2'];

}

if(isset($_POST['buttonsumofprimes']) || $_POST['inputbox5'])

{

$sql="INSERT INTO Sumofprimes (ValuePrimes) VALUES ('$_POST[inputbox5]')";

 

if($_POST[inputbox5] != 1060)

{

echo "Sorry Wrong!";

session_start(); 

if(isset($_SESSION['views5']))

{

    $_SESSION['views5'] = $_SESSION['views5']+ 1;

}

else

{

    $_SESSION['views5'] = 1;

}

}

else

{

echo "Correct!";

}

 

echo "<br>Number of incorrect answers = ". $_SESSION['views5'];

}

 

if(isset($_POST['buttonsumofdifference']) || $_POST['inputbox4'])

{

$sql="INSERT INTO Diffofsums VALUES ('$_POST[inputbox4]')";

 

if($_POST[inputbox4] != -144)

{

echo "Sorry Wrong!";

session_start(); 

if(isset($_SESSION['views4']))

{

    $_SESSION['views4'] = $_SESSION['views4']+ 1;

}

else

{

    $_SESSION['views4'] = 1;

}

}

else

{

echo "Correct!";

}

 

echo "<br>Number of incorrect answers = ". $_SESSION['views4'];

}

 

echo "<br><a href='http://luta.comuv.com/Easy/easy.html'>Go Back</a>";

 

if (!mysql_query($sql,$con))

  {

  die('Error: ' . mysql_error());

  }

 

mysql_close($con)

?>

[shlumph]

I'd agree with that. There's a rather lot of code duplication here 

[Ken2k7]

Thanks for sharing that, yakoup46.

[yakoup46]

Sharing what?

[yakoup46]

O crap, I meant to ask if there is anyway to shorten it up? LOL

[mattal999]

I just checked the website and noticed that I mis-understood the purpose of your code. This basically encapsulates your checks into a function which is then called 5 times. It will still work the same way however.

 

<title>The Java Project</title>
<?php

function checkAnswer($button, $inputbox, $session, $table, $answer) {
    if(isset($_POST[$button]) || $_POST[$inputbox]) {
        $sql="INSERT INTO $table VALUES ('$_POST[$inputbox]')";
        if($_POST[$inputbox] != $answer) {
            echo "Sorry Wrong!";
            session_start();  
            if(isset($_SESSION[$session])) {
                $_SESSION[$session] = $_SESSION[$session] + 1; // Could use $_SESSION[$session]++;
            } else {
                $_SESSION[$session] = 1;
            }
        } else {
            echo "Correct!";
        }
    echo "<br />Number of incorrect answers = ". $_SESSION[$session];
}

checkAnswer("buttonsumofodds", "inputbox1", "views1", "Sumofodds", "280");
checkAnswer("buttonsumofchain", "inputbox3", "views3", "Sumofchain", "820");
checkAnswer("buttonsumofsquares", "inputbox2", "views2", "Sumofsquares", "2870");
checkAnswer("buttonsumofprimes", "inputbox5", "views5", "Sumofprimes", "1060");
checkAnswer("buttonsumofdifference", "inputbox4", "views4", "Diffofsums", "-144");

echo "<br /><a href='http://luta.comuv.com/Easy/easy.html'>Go Back</a>";

if(!mysql_query($sql,$con)) {
    die('Error: ' . mysql_error());
}

mysql_close($con);

?>

[yakoup46]

Wow thank you so much! That is about 95% less code.

[yakoup46]

I used your code and now I am getting a "Query is Empty" error?

 

 

function checkAnswer($button, $inputbox, $session, $table, $answer) {

    if(isset($_POST[$button]) || $_POST[$inputbox]) {

        $sql="INSERT INTO $table VALUES ('$_POST[$inputbox]')";

        if($_POST[$inputbox] != $answer) {

            echo "Sorry Wrong!";

            session_start(); 

            if(isset($_SESSION[$session])) {

                $_SESSION[$session] = $_SESSION[$session] + 1; // Could use $_SESSION[$session]++;

            } else {

                $_SESSION[$session] = 1;

            }

        } else {

            echo "Correct!";

        }

    echo "<br />Number of incorrect answers = ". $_SESSION[$session];

}

}

 

checkAnswer("buttonsumofodds", "inputbox1", "views1", "Sumofodds", "280");

checkAnswer("buttonsumofchain", "inputbox3", "views3", "Sumofchain", "820");

checkAnswer("buttonsumofsquares", "inputbox2", "views2", "Sumofsquares", "2870");

checkAnswer("buttonsumofprimes", "inputbox5", "views5", "Sumofprimes", "1060");

checkAnswer("buttonsumofdifference", "inputbox4", "views4", "Diffofsums", "-144");

 

echo "<br /><a href='http://luta.comuv.com/Easy/easy.html'>Go Back</a>";

 

if(!mysql_query($sql,$con)) {

    die('Error: ' . mysql_error());

}

 

mysql_close($con);

?>

[mattal999]

Sorry about that. Forgot that last part.

 

<title>The Java Project</title>
<?php

function checkAnswer($button, $inputbox, $session, $table, $answer) {
    if(isset($_POST[$button]) || $_POST[$inputbox]) {
        $sql="INSERT INTO $table VALUES ('$_POST[$inputbox]')";
        if($_POST[$inputbox] != $answer) {
            echo "Sorry Wrong!";
            session_start();  
            if(isset($_SESSION[$session])) {
                $_SESSION[$session] = $_SESSION[$session] + 1; // Could use $_SESSION[$session]++;
            } else {
                $_SESSION[$session] = 1;
            }
        } else {
            echo "Correct!";
        }
    echo "<br />Number of incorrect answers = ". $_SESSION[$session];
    if(!mysql_query($sql, $con)) {
        die("Error: " . mysql_error());
    }
}

checkAnswer("buttonsumofodds", "inputbox1", "views1", "Sumofodds", "280");
checkAnswer("buttonsumofchain", "inputbox3", "views3", "Sumofchain", "820");
checkAnswer("buttonsumofsquares", "inputbox2", "views2", "Sumofsquares", "2870");
checkAnswer("buttonsumofprimes", "inputbox5", "views5", "Sumofprimes", "1060");
checkAnswer("buttonsumofdifference", "inputbox4", "views4", "Diffofsums", "-144");

echo "<br /><a href='http://luta.comuv.com/Easy/easy.html'>Go Back</a>";

mysql_close($con);

?>