PHP validation

fdjason · April 25, 2010

For a class project no alerts are supposed to be shown at first but then after the person hits submit, warnings will show if nothing was entered into a text box.

Here is my code, does anybody know what I'm doing wrong?

<html>

<head>

<title>Validate User Inputs</title>

</head>

<body>

<h2>Validate User Inputs</h2><hr>

<?php

$pageValid = true;

$postback = $_GET['postback'];

if ($pageValid == true && $postback) {

?>

<form>

<?php

$firstname= $_GET['firstName'];

?>

Please enter your first name:<br>

<?php

echo "" . fValidateName($firstname) . "";

?>

<?php

$personAge= $_GET['age'];

?>

Please enter your age (13-99):<br>

<?php

echo "" . fValidateAge($personAge) . "";

?>

<?php

$personEmail= $_GET['email'];

?>

Please enter your email address:<br>

<?php

echo "" . fValidateEmail($personEmail) . "";

?>

<?php

$personState= $_GET['state'];

?>

Please enter your state abbreviation:<br>

<?php

echo "" . fValidateState($personState) . "";

?>

</form>

<?php

echo "Success!";

} else {

//Name Validation

function fValidateName($Name) {

if ($postback && strlen($Name) == 0) {

echo "<font color='red'>Please enter your first name (alpha characters only)</font>";

$pageValid = false;

}

//Age Validation

function fValidateAge($age) {

if ($postback && ($age<13||$age>99)||strlen($age) == 0) {

echo "<font color='red'>Please enter a valid age (13-99) </font>";

$pageValid = false;

}

//Email Validation

function fValidateEmail($email) {

$pattern = "^[\w!#$%*_\-/?|\^\{\}'~\.]+@(\w+\.)+\w{2,4}^";

if ($postback && !(preg_match($pattern, $email))) {

echo "<font color='red'>Please enter a valid email address ([email protected])</font>";

$pageValid = false;

}

//State Validation

function fValidateState($state){

$ValidAbbr = array("AL","AK","AZ","AR","CA","CO","CT","DE","FL","GA","HI","ID","IL",

"IN","IA","KS","KY","LA","ME","MD","MA","MI","MN","MS","MO","MT","NE","NV","NH",

"NJ","NM","NY","NC","ND","OH","OK","OR","PA","RI","SC","SD","TN","TX","UT","VT",

"VA","WA","WV","WI","WY");

$state = strtoupper($state);

//in_array() checks if a value exists in an array.

if (in_array($state, $ValidAbbr)) {

} else {echo "<font color='red'>Please enter a valid state abbreviation</font>";

$pageValid = false;

}

?>

</center>

</body>

</html>

Pikachu2000 · April 25, 2010

Without knowing what's happening, it's hard to say what you're doing wrong. My guess, though is that it's throwing errors as soon as the page loads, is that correct?

fdjason · April 25, 2010

This is what mine is doing: http://yorktown.cbe.wwu.edu/2010Spring/floresj/a04/Validate3.php

This is what it should be doing: http://yorktown.cbe.wwu.edu/sandvig/mis314/assignments/a04/Validate.php

I have that form there in code but something I am doing is hiding everything. What I want to happen is to hide the red warnings (as shown in the second link) and show when the submit button is hit and one of the fields were not filled out.

Pikachu2000 · April 25, 2010

The things that stand out upon a cursory review are:

If the form hasn't been submitted, this: if ($pageValid == true && $postback) will never evaluate as true, and will prevent the form from displaying. Also, you define $pagevalid and assign its value just prior to the conditional, so that will ALWAYS be true, defeating the purpose of the conditional.

You've mixed short open tags '<?' into the fields' value="<? echo $firstname ?>" whereas these will fail on servers that have short open tags disabled. Use the full <?php open tags instead.

This may be the biggest, yet easiest to fix: you can't use a function before it's defined. Move the functions to the head of the script, or copy them to a separate file and include() it at the beginning.

Sign In

PHP validation

Recommended Posts

fdjason

Link to comment

Share on other sites

Pikachu2000

Link to comment

Share on other sites

fdjason

Link to comment

Share on other sites

Pikachu2000

Link to comment

Share on other sites

Archived

Browse

Activity

Important Information