Help WIth An Array

[refiking]

I want to have an array of extension types that are acceptable.  Currently, the method I am using will only allow me to check 1.  What should I do differently?

 

$ext = substr($file_name, strrpos($file_name, '.') + 1);
if($ext != 'jpg'){ 
$exterror++; 
}
if($exterror > 0){
    echo "Error:File type not supported.";
    return;
}

[bluejay002]

try this:

 

$ext_array("jpg", "png"); // so on and so forth
$ext = substr($file_name, strrpos($file_name, '.') + 1);
if(!in_array($ext, $ext_array)){ 
$exterror++; 
}
if($exterror > 0){
    echo "Error:File type not supported.";
    return;
}

 

hope this helps.

 

bluejay,

[JasonLewis]

I do it like this:

 

$allowed = array("jpg","gif","bmp");

if(!in_array(array_pop(explode(".", $file)), $allowed)){
   // not a valid file type
}else{
  // valid file type
}

 

Fairly similar to bluejay002s.

[brianlange]

if you have a large array make the extensions keys and use array_key_exists.

Php can search keys faster than values.

[Alex]

You can also do it like this (using the built in function to get the extension):

 

$allowed = array("jpg", "gif", "bmp");
if(in_array(pathinfo($path, PATHINFO_EXTENSION), $allowed)) {
    // valid
} else {
    // not
}

[bluejay002]

@projectFear:

well, its not entirely my code. I just assume his code were correct and added my code on it. I'm kinda lazy writing a new code over something that the user didn't complained about. 

[JasonLewis]

@projectFear:

well, its not entirely my code. I just assume his code were correct and added my code on it. I'm kinda lazy writing a new code over something that the user didn't complained about. 

 

True enough, but hopefully the OP can look at modified (and cleaned) code and see any improvements (or maybe it got worse).