Jump to content

Can this be improved?


newbtophp

Recommended Posts

Hi,

 

Im currently using the following code, to list 'Todays 5', however can the following be improved im uneasy with using php for the date comparison - perhaps have it within the sql?

 

DB Structure: I have a column named 'flash_date' (and the type is: varchar(32)) which contains a timestamp generated by time()

 

$yesterday = strtotime('-1 day');

$time = time();

$result = mysql_query("SELECT * FROM site_flash WHERE flash_date > '{$yesterday}' AND flash_date < '{$time}' DESC LIMIT 5");

Link to comment
Share on other sites

DB Structure: I have a column named 'flash_date' (and the type is: varchar(32)) which contains a timestamp generated by time()

Why 32 characters? A timestamp is an integer with a length of 10 (INT 10). Convert this.

 

SQL

SELECT * FROM site_flash WHERE flash_date > UNIX_TIMESTAMP(CURDATE() - 1) AND flash_date < UNIX_TIMESTAMP() DESC LIMIT 5

Link to comment
Share on other sites

DB Structure: I have a column named 'flash_date' (and the type is: varchar(32)) which contains a timestamp generated by time()

Why 32 characters? A timestamp is an integer with a length of 10 (INT 10). Convert this.

 

SQL

SELECT * FROM site_flash WHERE flash_date > UNIX_TIMESTAMP(CURDATE() - 1) AND flash_date < UNIX_TIMESTAMP() DESC LIMIT 5

 

I don't know why I did varchar(32), at that time I was a total newby, and every tutorial I read always seemed to mention varchar(32), (so I just used that, never really knowing what it is) - now I know it means 32 chars  8)

 

I changed it to INT(10), cheers for that query I'll use it, but just a thought would this work also?

 

SELECT * FROM site_flash WHERE flash_date > (now() - INTERVAL 1 day) DESC LIMIT 5

Link to comment
Share on other sites

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.