Jump to content

Can i make this more efficient


AdRock

Recommended Posts

I have some code which i think is really inefficient especially as there will be more more conditions to be met.

 

I was thinking about using s switch but don't know if this is possible or if it's best leaving as it is.

 

Any ideas?

 

if($parts[($i-1)]=="forum") {
            		//do some code
            	} 
            	else if($parts[($i-2)]=="forum") {
            		//do code
            	}
            	else if (($parts[($i-1)]=="list-messages") && (isset($parts[($i+1)]))) {
            		//do code
            	}
            	else {
               	 	// do some code
               	}

Link to comment
https://forums.phpfreaks.com/topic/209892-can-i-make-this-more-efficient/
Share on other sites

More along the lines of

<?php
function doStuff($string) {
switch($string) {
	case "forum":
		return "display forum";
	break;
	case "list-messages":
		return "list all messages";
	break;
	default:
		return "don't know what to do";
	break;
}
}


for($x = 0; $x < count($parts); $x++) {
print doStuff($parts[$x]);
}
?>

Archived

This topic is now archived and is closed to further replies.

×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.