Is this the correct way?

[newbtophp]

Hi,

 

Is this the correct way to go by setting cookies for my login 'remember' functionality?, I've posted the relevant login and logout code.

 

Login:

 

<?php
session_start();

//some code...

if (isset($_POST['remember'])) {

$expire = time() + 1728000; // Expire in 20 days

$site_domain = 'phpfreaks.com'; //example

$_SESSION['username'] = $_POST['username']; //don't worry this has been validated 

$username = $_SESSION['username'];

//some sql query to fetch code..

$code = $row['code'];

setcookie('username', $username, $expire, NULL,  ".$site_domain", NULL, TRUE);

setcookie('code', $code, $expire, NULL, ".$site_domain", NULL, TRUE);

}
?>

 

Logout:

 

<?php
session_start();

if (isset($_COOKIE['username'])) {

$expire = time() - 1728000; // Expire in 20 days

$site_domain = 'phpfreaks.com'; //example

$username = $_SESSION['username'];

//some sql query to fetch code..

$code = $row['code'];

setcookie('username', $username, $expire, NULL, ".$site_domain", NULL, TRUE);

setcookie('code', $code, $expire, NULL, ".$site_domain", NULL, TRUE);

}

unset($_SESSION['username']);

$_SESSION = array();

session_destroy();
?>

 

Please tell me if it looks good to go and/or any improvements.

 

PS:

 

I want it accessible on all areas of the domain (including subdomains and paths etc.), and HTTP ONLY (so js can't access it) - I believe I've set the right parems?

[newbtophp]

friendly bump lol