update form with image

[Lisa23]

in english UPDATE SET image='$image'

 

take the content of the variable named $image and place that content into the table field named image

 

what abou this part what does it mean in english

$image = $_FILES['image'];

[Lisa23]

another thing i thought about doing is now i alrady have one file that uploads files perfectly i also have another one that removes file from the directory so i thout setting those up as function so that when user click on modify it would actually call those as fuction one by one is does it sound good or should i just continue wrkin on the whole in one script???

[litebearer]

using functions is great when a process is used by several different scripts or in several different place within the same script

[Lisa23]

ok i starting from scratch a simple update but its failing to update help

 

<?php
define('ROOT_DIR', './');
define('THIS_SCRIPT', 'news');
define('PROPER', TRUE);
/**
* include common files
*/
include_once(ROOT_DIR. 'includes/common.inc.php');

//define a maxim size for the uploaded images
define ("MAX_SIZE","100");
// define the width and height for the thumbnail
// note that theese dimmensions are considered the maximum dimmension and are not fixed,
// because we have to keep the image ratio intact or it will be deformed
define ("WIDTH","150");
define ("HEIGHT","100");

// this is the function that will create the thumbnail image from the uploaded image
// the resize will be done considering the width and height defined, but without deforming the image
function make_thumb($img_name,$filename,$new_w,$new_h)
{
//get image extension.
$ext=getExtension($img_name);
//creates the new image using the appropriate function from gd library
if(!strcmp("jpg",$ext) || !strcmp("jpeg",$ext))
$src_img=imagecreatefromjpeg($img_name);

if(!strcmp("png",$ext))
$src_img=imagecreatefrompng($img_name);

//gets the dimmensions of the image
$old_x=imageSX($src_img);
$old_y=imageSY($src_img);

// next we will calculate the new dimmensions for the thumbnail image
// the next steps will be taken:
// 1. calculate the ratio by dividing the old dimmensions with the new ones
// 2. if the ratio for the width is higher, the width will remain the one define in WIDTH variable
// and the height will be calculated so the image ratio will not change
// 3. otherwise we will use the height ratio for the image
// as a result, only one of the dimmensions will be from the fixed ones
$ratio1=$old_x/$new_w;
$ratio2=$old_y/$new_h;
if($ratio1>$ratio2) {
$thumb_w=$new_w;
$thumb_h=$old_y/$ratio1;
}
else {
$thumb_h=$new_h;
$thumb_w=$old_x/$ratio2;
}

// we create a new image with the new dimmensions
$dst_img=ImageCreateTrueColor($thumb_w,$thumb_h);

// resize the big image to the new created one
imagecopyresampled($dst_img,$src_img,0,0,0,0,$thumb_w,$thumb_h,$old_x,$old_y);

// output the created image to the file. Now we will have the thumbnail into the file named by $filename
if(!strcmp("png",$ext))
imagepng($dst_img,$filename);
else
imagejpeg($dst_img,$filename);

//destroys source and destination images.
imagedestroy($dst_img);
imagedestroy($src_img);
}

// This function reads the extension of the file.
// It is used to determine if the file is an image by checking the extension.
function getExtension($str) {
$i = strrpos($str,".");
if (!$i) { return ""; }
$l = strlen($str) - $i;
$ext = substr($str,$i+1,$l);
return $ext;
}

// This variable is used as a flag. The value is initialized with 0 (meaning no error found)
//and it will be changed to 1 if an errro occures. If the error occures the file will not be uploaded.
$errors=0;
// checks if the form has been submitted
if(isset($_POST['Submit']))
{
//reads the name of the file the user submitted for uploading
$image=$_FILES['image']['name'];
// if it is not empty
if ($image)
{
// get the original name of the file from the clients machine
$filename = stripslashes($_FILES['image']['name']);

// get the extension of the file in a lower case format
$extension = getExtension($filename);
$extension = strtolower($extension);
// if it is not a known extension, we will suppose it is an error, print an error message
//and will not upload the file, otherwise we continue
if (($extension != "jpg") && ($extension != "jpeg") && ($extension != "png"))
{
echo '<h1>Unknown extension!</h1>';
$errors=1;
}
else
{
// get the size of the image in bytes
// $_FILES[\'image\'][\'tmp_name\'] is the temporary filename of the file in which the uploaded file was stored on the server
$size=getimagesize($_FILES['image']['tmp_name']);
$sizekb=filesize($_FILES['image']['tmp_name']);

//compare the size with the maxim size we defined and print error if bigger
if ($sizekb > MAX_SIZE*2024)
{
echo '<h1>You have exceeded the size limit!</h1>';
$errors=1;
}

//we will give an unique name, for example the time in unix time format
$image_name=time().'.'.$extension;
//the new name will be containing the full path where will be stored (images folder)
$newname="images/".$image_name;
$copied = copy($_FILES['image']['tmp_name'], $newname);
//we verify if the image has been uploaded, and print error instead
if (!$copied)
{
echo '<h1>Copy unsuccessfull!</h1>';
$errors=1;
}
else
{
// the new thumbnail image will be placed in images/thumbs/ folder
$thumb_name='images/thumbs/'.$image_name;
// call the function that will create the thumbnail. The function will get as parameters
//the image name, the thumbnail name and the width and height desired for the thumbnail
$thumb=make_thumb($newname,$thumb_name,WIDTH,HEIGHT);
}} }}

//If no errors registred, print the success message and show the thumbnail image created

//If no errors registred, print the success message and show the thumbnail image created


  $id = $_POST['id'] ;
    $name = $_POST['name'];
    $location = $_POST['location'];
    $date_of_birth = $_POST['date_of_birth'];
    $car_number = $_POST['car_number'];
    $favourite_track = $_POST['favourite_track'];
    $least_favourite_track = $_POST['least_favourite_track'];
    $achievements = $_POST['achievements'];
    $sponsors = $_POST['sponsors'];    
    $email = $_POST['email'];    
    $image_name = $_FILES['image_name'];
    
$query = "UPDATE driversnew SET name = '$name', location = '$location', date_of_birth='$date_of_birth', car_number='$car_number', favourite_track='$favourite_track', least_favourite_track='$least_favourite_track', achievements='$achievements', sponsors='$sponsors', email='$email', image_name='$image_name' WHERE id = '$id'";

$result = mysql_query("SELECT * FROM driversnew WHERE id = '$id'");

var_dump($result); 


echo '<pre>';
var_dump($_FILES);
echo '</pre>'; 



echo "<h1>Thumbnail created Successfully!</h1>";
echo '<img src="'.$image_name.'">';
echo ''.$name.''; echo'<br />';
echo ''.$newname.'';




?>

[Lisa23]

hi guys i bk well still here i manag eto get my form to update but now the only problem it doesnt upload the new image i dnt think is much going on bt i just cant crack it help please

 

<?php
define('ROOT_DIR', './');
define('THIS_SCRIPT', 'news');
define('PROPER', TRUE);
/**
* include common files
*/
include_once(ROOT_DIR. 'includes/common.inc.php');

    $id = $_GET['id']; 
    $name = $_GET['name'];
    $location = $_GET['location'];
    $date_of_birth = $_GET['date_of_birth'];
    $car_number = $_GET['car_number'];
    $favourite_track = $_GET['favourite_track'];
    $least_favourite_track = $_GET['least_favourite_track'];
    $achievements = $_GET['achievements'];
    $sponsors = $_GET['sponsors'];    
    $email = $_GET['email'];    
    $image  = $_REQUEST['image'];
    
    
    
/// start uploading process
    define ("MAX_SIZE","100");
// define the width and height for the thumbnail
// note that theese dimmensions are considered the maximum dimmension and are not fixed,
// because we have to keep the image ratio intact or it will be deformed
define ("WIDTH","150");
define ("HEIGHT","100");

// this is the function that will create the thumbnail image from the uploaded image
// the resize will be done considering the width and height defined, but without deforming the image
function make_thumb($img_name,$filename,$new_w,$new_h)
{
//get image extension.
$ext=getExtension($img_name);
//creates the new image using the appropriate function from gd library
if(!strcmp("jpg",$ext) || !strcmp("jpeg",$ext))
$src_img=imagecreatefromjpeg($img_name);

if(!strcmp("png",$ext))
$src_img=imagecreatefrompng($img_name);

//gets the dimmensions of the image
$old_x=imageSX($src_img);
$old_y=imageSY($src_img);

// next we will calculate the new dimmensions for the thumbnail image
// the next steps will be taken:
// 1. calculate the ratio by dividing the old dimmensions with the new ones
// 2. if the ratio for the width is higher, the width will remain the one define in WIDTH variable
// and the height will be calculated so the image ratio will not change
// 3. otherwise we will use the height ratio for the image
// as a result, only one of the dimmensions will be from the fixed ones
$ratio1=$old_x/$new_w;
$ratio2=$old_y/$new_h;
if($ratio1>$ratio2) {
$thumb_w=$new_w;
$thumb_h=$old_y/$ratio1;
}
else {
$thumb_h=$new_h;
$thumb_w=$old_x/$ratio2;
}

// we create a new image with the new dimmensions
$dst_img=ImageCreateTrueColor($thumb_w,$thumb_h);

// resize the big image to the new created one
imagecopyresampled($dst_img,$src_img,0,0,0,0,$thumb_w,$thumb_h,$old_x,$old_y);

// output the created image to the file. Now we will have the thumbnail into the file named by $filename
if(!strcmp("png",$ext))
imagepng($dst_img,$filename);
else
imagejpeg($dst_img,$filename);

//destroys source and destination images.
imagedestroy($dst_img);
imagedestroy($src_img);
}

// This function reads the extension of the file.
// It is used to determine if the file is an image by checking the extension.
function getExtension($str) {
$i = strrpos($str,".");
if (!$i) { return ""; }
$l = strlen($str) - $i;
$ext = substr($str,$i+1,$l);
return $ext;
}

// This variable is used as a flag. The value is initialized with 0 (meaning no error found)
//and it will be changed to 1 if an errro occures. If the error occures the file will not be uploaded.
$errors=0;
// checks if the form has been submitted
if(isset($_GET['Submit']))
{
//reads the name of the file the user submitted for uploading
$image=$_FILES['image']['name'];
// if it is not empty
if ($image)
{
// get the original name of the file from the clients machine
$filename = stripslashes($_FILES['image']['name']);

// get the extension of the file in a lower case format
$extension = getExtension($filename);
$extension = strtolower($extension);
// if it is not a known extension, we will suppose it is an error, print an error message
//and will not upload the file, otherwise we continue
if (($extension != "jpg") && ($extension != "jpeg") && ($extension != "png"))
{
echo '<h1>Unknown extension!</h1>';
$errors=1;
}
else
{
// get the size of the image in bytes
// $_FILES[\'image\'][\'tmp_name\'] is the temporary filename of the file in which the uploaded file was stored on the server
$size=getimagesize($_FILES['image']['tmp_name']);
$sizekb=filesize($_FILES['image']['tmp_name']);

//compare the size with the maxim size we defined and print error if bigger
if ($sizekb > MAX_SIZE*2024)
{
echo '<h1>You have exceeded the size limit!</h1>';
$errors=1;
}

//we will give an unique name, for example the time in unix time format
$image_name=time().'.'.$extension;
//the new name will be containing the full path where will be stored (images folder)
$newname="images/".$image_name;
$copied = copy($_FILES['image']['tmp_name'], $newname);
//we verify if the image has been uploaded, and print error instead
if (!$copied)
{
echo '<h1>Copy unsuccessfull!</h1>';
$errors=1;
}
else
{
// the new thumbnail image will be placed in images/thumbs/ folder
$thumb_name='images/thumbs/'.$image_name;
// call the function that will create the thumbnail. The function will get as parameters
//the image name, the thumbnail name and the width and height desired for the thumbnail
$thumb=make_thumb($newname,$thumb_name,WIDTH,HEIGHT);
}} }}    
    
    

    
$query = "UPDATE driversnew SET name = '$name', location = '$location', date_of_birth='$date_of_birth', car_number='$car_number', favourite_track='$favourite_track', least_favourite_track='$least_favourite_track', achievements='$achievements', sponsors='$sponsors', email='$email', image='$image' WHERE id = '$id'";


mysql_query($query) or die(mysql_error()); 
// execute query 
$result = mysql_query($query) ;
//if there was a problem - get the error message and go back 
if (!$result)
  {
     echo "There were errors :<br>". mysql_error();
  } 
  else //OK, then the insertion was successful
  
  {
    
print "<p>The following records has been updated:  </p>";

    //Create a new query to display the new row in a table
    $query = "SELECT id, name, location, date_of_birth, car_number, favourite_track, least_favourite_track, achievements, sponsors, email, image FROM driversnew WHERE id = '$id' ";    $result = mysql_query($query) or die ("Error in query: $query. ".mysql_error()); 
    echo "<table cellpadding=10 border=1>";  
    while($row = mysql_fetch_array($result)) { 
          echo "<tr>"; 
     echo "<td>".$row["id"]."</td>";
     echo "<td><strong>" .$row["name"]."</strong></td>";
     echo "<td><strong>".$row["location"]."</strong></td>"; 
     echo "<td><strong>" .$row["date_of_birth"]."</strong></td>";
     echo "<td><strong>".$row["car_number"]."</strong></td>";
     echo "<td><strong>" .$row["favourite_track"]."</strong></td>";
     echo "<td><strong>".$row["least_favourite_track"]."</strong></td>"; 
     echo "<td><strong>" .$row["achievements"]."</strong></td>";
     echo "<td><strong>".$row["sponsors"]."</strong></td>";
     echo "<td><strong>" .$row["email"]."</strong></td>";
     echo "<td><strong>".$row["image"]."</strong></td>"; 
     echo "</tr>"; 
    } //End while
    echo "</table>"; 
       } //End Else insertion successful
//End else successful Amendment     

?>

[Lisa23]

ok i finaly manage to get the form to update bt one foul if user doesnt send a new image the form will empty the previous is like it as long it press submit it send data empty if no new image uploaded how can i make so like if user doesnt modify the image to keep same image name on the database???

[Lisa23]

ok i got the file to stop replace the image field if a new image not entered but now the problem is that when new image upload the upload part doesnt wrk now i think i placed the upload part on the wrong part of the if statment can someone just help place on te rite place so it upload if needed and doesnt if not need it

 

<?php
define('ROOT_DIR', './');
define('THIS_SCRIPT', 'news');
define('PROPER', TRUE);
/**
* include common files
*/
include_once(ROOT_DIR. 'includes/common.inc.php');


$id = $_POST['id'];
    $name = $_POST['name'];
    $location = $_POST['location'];
    $date_of_birth = $_POST['date_of_birth'];
    $car_number = $_POST['car_number'];
    $favourite_track = $_POST['favourite_track'];
    $least_favourite_track = $_POST['least_favourite_track'];
    $achievements = $_POST['achievements'];
    $sponsors = $_POST['sponsors'];    
    $email = $_POST['email'];    
    $newname  = $_FILES['image'];
    
$query = "UPDATE driversnew SET name = '$name', location = '$location', date_of_birth='$date_of_birth', car_number='$car_number', favourite_track='$favourite_track', least_favourite_track='$least_favourite_track', achievements='$achievements', sponsors='$sponsors', email='$email'";


if($_FILES['error'] === 0){

   $query .= ", image='$image_name'";
   
   
//define a maxim size for the uploaded images
define ("MAX_SIZE","100");
// define the width and height for the thumbnail
// note that theese dimmensions are considered the maximum dimmension and are not fixed,
// because we have to keep the image ratio intact or it will be deformed
define ("WIDTH","150");
define ("HEIGHT","100");

// this is the function that will create the thumbnail image from the uploaded image
// the resize will be done considering the width and height defined, but without deforming the image
function make_thumb($img_name,$filename,$new_w,$new_h)
{
//get image extension.
$ext=getExtension($img_name);
//creates the new image using the appropriate function from gd library
if(!strcmp("jpg",$ext) || !strcmp("jpeg",$ext))
$src_img=imagecreatefromjpeg($img_name);

if(!strcmp("png",$ext))
$src_img=imagecreatefrompng($img_name);

//gets the dimmensions of the image
$old_x=imageSX($src_img);
$old_y=imageSY($src_img);

// next we will calculate the new dimmensions for the thumbnail image
// the next steps will be taken:
// 1. calculate the ratio by dividing the old dimmensions with the new ones
// 2. if the ratio for the width is higher, the width will remain the one define in WIDTH variable
// and the height will be calculated so the image ratio will not change
// 3. otherwise we will use the height ratio for the image
// as a result, only one of the dimmensions will be from the fixed ones
$ratio1=$old_x/$new_w;
$ratio2=$old_y/$new_h;
if($ratio1>$ratio2) {
$thumb_w=$new_w;
$thumb_h=$old_y/$ratio1;
}
else {
$thumb_h=$new_h;
$thumb_w=$old_x/$ratio2;
}

// we create a new image with the new dimmensions
$dst_img=ImageCreateTrueColor($thumb_w,$thumb_h);

// resize the big image to the new created one
imagecopyresampled($dst_img,$src_img,0,0,0,0,$thumb_w,$thumb_h,$old_x,$old_y);

// output the created image to the file. Now we will have the thumbnail into the file named by $filename
if(!strcmp("png",$ext))
imagepng($dst_img,$filename);
else
imagejpeg($dst_img,$filename);

//destroys source and destination images.
imagedestroy($dst_img);
imagedestroy($src_img);
}

// This function reads the extension of the file.
// It is used to determine if the file is an image by checking the extension.
function getExtension($str) {
$i = strrpos($str,".");
if (!$i) { return ""; }
$l = strlen($str) - $i;
$ext = substr($str,$i+1,$l);
return $ext;
}

// This variable is used as a flag. The value is initialized with 0 (meaning no error found)
//and it will be changed to 1 if an errro occures. If the error occures the file will not be uploaded.
$errors=0;
// checks if the form has been submitted
if(isset($_POST['Submit']))
{
//reads the name of the file the user submitted for uploading
$image=$_FILES['image']['name'];
// if it is not empty
if ($image)
{
// get the original name of the file from the clients machine
$filename = stripslashes($_FILES['image']['name']);

// get the extension of the file in a lower case format
$extension = getExtension($filename);
$extension = strtolower($extension);
// if it is not a known extension, we will suppose it is an error, print an error message
//and will not upload the file, otherwise we continue
if (($extension != "jpg") && ($extension != "jpeg") && ($extension != "png"))
{
echo '<h1>Unknown extension!</h1>';
$errors=1;
}
else
{
// get the size of the image in bytes
// $_FILES[\'image\'][\'tmp_name\'] is the temporary filename of the file in which the uploaded file was stored on the server
$size=getimagesize($_FILES['image']['tmp_name']);
$sizekb=filesize($_FILES['image']['tmp_name']);

//compare the size with the maxim size we defined anuploadd print error if bigger
if ($sizekb > MAX_SIZE*2024)
{
echo '<h1>You have exceeded the size limit!</h1>';
$errors=1;
}

//we will give an unique name, for example the time in unix time format
$image_name=time().'.'.$extension;
//the new name will be containing the full path where will be stored (images folder)
$newname="images/".$image_name;
$copied = copy($_FILES['image']['tmp_name'], $newname);
//we verify if the image has been uploaded, and print error instead
if (!$copied)
{
echo '<h1>Copy unsuccessfull!</h1>';
$errors=1;
}
else
{
// the new thumbnail image will be placed in images/thumbs/ folder
$thumb_name='images/thumbs/'.$image_name;
// call the function that will create the thumbnail. The function will get as parameters
//the image name, the thumbnail name and the width and height desired for the thumbnail
$thumb=make_thumb($newname,$thumb_name,WIDTH,HEIGHT);
}} }}

//If no errors registred, print the success message and show the thumbnail image created

   

}

$query .= " WHERE id = '$id'";



mysql_query($query) or die(mysql_error());


echo "<h1>Thumbnail created Successfully!</h1>";
echo '<img src="'.$thumb_name.'">';
echo ''.$image_name.'';

?> 

[rwwd]

Just a suggestion, but to add security to your hard work add this following bit of code:-

include_once(ROOT_DIR. 'includes/common.inc.php');

//sanitise user inputted data - do the WHOLE array!!
$_POST = array_map('strip_tags', $_POST);
$_POST = array_map('mysql_real_escape_string', $_POST);

//these are noe DB/sql safe
$id = $_POST['id'];
$name = $_POST['name'];

 

Seriously, security - it's worth it...

 

Rw

[Lisa23]

thanks i gt to work but now i am having this problem

ok so after that if no errors i inserted the script that unlink the image from the folder but is giving me error is on the wrong place again??

Delete photo failed. You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 5

 

if($_FILES['image'] ['error'] === 0){

      // remove the image and the thumbnail from the server
      $sql = "SELECT id, image

           FROM drivernew

           WHERE id = {$_GET['image']}";

   $result = mysql_query($sql)

             or die('Delete photo failed. ' . mysql_error());

   if (mysql_num_rows($result) == 1) {

      $row = mysql_fetch_assoc($result);
      
define("GALLERY_IMG_DIR", "./images/");

      // remove the image and the thumbnail from the server
      unlink(GALLERY_IMG_DIR . $row['image']);

      unlink(GALLERY_IMG_DIR . 'thumbs/' . $row['image']);
   
//start upload process
//define a maxim size for the uploaded images
define ("MAX_SIZE","100");

[darkfreaks]

just use $_GET['image'] instead of {$_GET['image']}

SELECT id, image

           FROM drivernew

           WHERE id ='" $_GET['image']"'

[litebearer]

In line with Dark, also should be sanitizing your user supplied data BEFORE you insert into database

 

[darkfreaks]

<?php

if($_FILES['image'] ['error'] === 0){

      // remove the image and the thumbnail from the server
      $sql = "SELECT id, image

           FROM drivernew

           WHERE id = '"mysql_real_escape_string($_GET['image'])"'";

   $result = mysql_query($sql)

             or die('Delete photo failed. ' . mysql_error());

   if (mysql_num_rows($result) == 1) {

      $row = mysql_fetch_assoc($result);
      
define("GALLERY_IMG_DIR", "./images/");

      // remove the image and the thumbnail from the server
      unlink(GALLERY_IMG_DIR . $row['image']);

      unlink(GALLERY_IMG_DIR . 'thumbs/' . $row['image']);
   
//start upload process
//define a maxim size for the uploaded images
define ("MAX_SIZE","100");
?>