Minimeallolla Posted November 12, 2010 Share Posted November 12, 2010 http://www.mysite.giacjr.dino-hosting.net/index.php I also need a sole purpose. idk leave feedback. first website. not really advanced at html or php but im aiming to gain knowledge. please be sure to register and log in. Quote Link to comment https://forums.phpfreaks.com/topic/218476-my-website-need-criticism/ Share on other sites More sharing options...
Adam Posted November 12, 2010 Share Posted November 12, 2010 First and foremost I'd look at how to structure a HTML document correctly. You have no doctype, opening <html> tag, <head> section, or <body> section. These are the basic requirements for a HTML web page. Quote Link to comment https://forums.phpfreaks.com/topic/218476-my-website-need-criticism/#findComment-1133396 Share on other sites More sharing options...
nano Posted November 12, 2010 Share Posted November 12, 2010 This website is best viewed in: Mozilla Firefox Awesome For a first website, it's not too bad but there is a lot to learn. Though my first site was one static image, so you're doing well You need to think about structuring your code, make sure you separate style from content. You need to think about optimisation, don't use a lot of large images and if images are required, use a tool like smushit to optimise them: http://www.smushit.com/ysmush.it/ Check you code is valid and that means both the HTML and CSS. The background is a little off putting so maybe use a natural colour (though I am no designer), and make sure your site advertises your brand and online purpose. And finally - make sure it works with multiple browsers. Test, test and test again with something like Spoon: http://www.spoon.net/browsers Good work though! Quote Link to comment https://forums.phpfreaks.com/topic/218476-my-website-need-criticism/#findComment-1133423 Share on other sites More sharing options...
ManiacDan Posted November 12, 2010 Share Posted November 12, 2010 The first thing that jumped to my mind was usability (entering a bad password doesn't allow you to try again) and copyright concerns. Even though freeOnlineGames.com is free for you to play, that doesn't necessarily mean the games are free for you to take and put on your own site. With the DMCA and ACTA out there, a company can have your internet connection disabled just for looking at them sideways. -Dan Quote Link to comment https://forums.phpfreaks.com/topic/218476-my-website-need-criticism/#findComment-1133434 Share on other sites More sharing options...
Minimeallolla Posted November 12, 2010 Author Share Posted November 12, 2010 Thanks heaps nano, btw, do you have any suggestions for the background? and dan: which file? login or register? Quote Link to comment https://forums.phpfreaks.com/topic/218476-my-website-need-criticism/#findComment-1133438 Share on other sites More sharing options...
ManiacDan Posted November 12, 2010 Share Posted November 12, 2010 Click login, enter random crap in both boxes, and click submit. You're taken to an error document that directs you to register. You should be taken back to the login form with an error message so you can try again. -Dan Quote Link to comment https://forums.phpfreaks.com/topic/218476-my-website-need-criticism/#findComment-1133445 Share on other sites More sharing options...
Minimeallolla Posted November 12, 2010 Author Share Posted November 12, 2010 ok fixed. anything else? Quote Link to comment https://forums.phpfreaks.com/topic/218476-my-website-need-criticism/#findComment-1133448 Share on other sites More sharing options...
ManiacDan Posted November 12, 2010 Share Posted November 12, 2010 The lime green "you are logged in" page did permanent damage to my eyes. Also, you don't verify email addresses, as you can probably tell by the testy@mctesterson.com that's now in your database. I'm unclear what the whole "comments" thing does, I posted comments and nothing happened. Also, you cannot comment on individual games. The whole thing is kind of...ugly. A graphics designer or a cleaner plan for the site's flow would help. The over-wrought graphics (which are nearly impossible to read), the poor background colors, and the low contrast text make the whole thing difficult to use. Also, your navigation is screwy. No reason to have "logout" when you're not logged in, or "login" and "register" when you're already logged in. The left nav for the games should be a true left nav and not just tacked to the left side of the bottom of the page. I tried a couple of script and injection attacks on the site, you seem safe from the basics. You set two cookies, one of which is my username and the other is an md5 of my password. Don't do that, it's obvious to anyone with a modicum of skill what it is. If you're using those cookies for authentication, DON'T. -Dan Quote Link to comment https://forums.phpfreaks.com/topic/218476-my-website-need-criticism/#findComment-1133456 Share on other sites More sharing options...
Minimeallolla Posted November 12, 2010 Author Share Posted November 12, 2010 Dan: you must have got me when I was just experimenting with random stuff. I can assure you the comment thing does work and the background is set as one throughout the whole site. I do need advice one what background to have. I'm no good with backgrounds >.< I also didn't want to add a verification email because it would annoy people and from experience I haven't gone through with some sites because I simply could not be bothered to check my emails. Quote Link to comment https://forums.phpfreaks.com/topic/218476-my-website-need-criticism/#findComment-1133459 Share on other sites More sharing options...
PFMaBiSmAd Posted November 12, 2010 Share Posted November 12, 2010 you must have got me when I was just experimenting with random stuff. You should not be developing, debugging, and experimenting on a live host and also not on a site that you have asked others to review. Quote Link to comment https://forums.phpfreaks.com/topic/218476-my-website-need-criticism/#findComment-1133460 Share on other sites More sharing options...
Minimeallolla Posted November 12, 2010 Author Share Posted November 12, 2010 Well it is 3am and i get no traffic at all only upon request. This site isn't a real legit one, just a free hosting practice one for more experience I guess. So any ideas or feedback on what I should add or edit? Quote Link to comment https://forums.phpfreaks.com/topic/218476-my-website-need-criticism/#findComment-1133461 Share on other sites More sharing options...
ManiacDan Posted November 12, 2010 Share Posted November 12, 2010 http://www.mysite.giacjr.dino-hosting.net/profiles/abc123.php?u=num Warning: include(1) [function.include]: failed to open stream: No such file or directory in /home/giacjrdi/public_html/mysite/profiles/write.php on line 129 Warning: include(1) [function.include]: failed to open stream: No such file or directory in /home/giacjrdi/public_html/mysite/profiles/write.php on line 129 Warning: include() [function.include]: Failed opening '1' for inclusion (include_path='.:/usr/lib/php:/usr/local/lib/php') in /home/giacjrdi/public_html/mysite/profiles/write.php on line 129 Quote Link to comment https://forums.phpfreaks.com/topic/218476-my-website-need-criticism/#findComment-1133462 Share on other sites More sharing options...
Minimeallolla Posted November 12, 2010 Author Share Posted November 12, 2010 mmm it is 3:13am and i really cannot be bothered to fix that, for now anyways.. ill fix it when im rested and well anything i should add. i feel the site is too blank. Quote Link to comment https://forums.phpfreaks.com/topic/218476-my-website-need-criticism/#findComment-1133464 Share on other sites More sharing options...
ManiacDan Posted November 12, 2010 Share Posted November 12, 2010 Well...you know...content. You seem to be wanting to make it a game site. Write stuff about games. Put that stuff on the page. Quote Link to comment https://forums.phpfreaks.com/topic/218476-my-website-need-criticism/#findComment-1133466 Share on other sites More sharing options...
Minimeallolla Posted November 12, 2010 Author Share Posted November 12, 2010 Well it's nowhere near advanced enough for a gaming community or a gaming forum? Quote Link to comment https://forums.phpfreaks.com/topic/218476-my-website-need-criticism/#findComment-1133467 Share on other sites More sharing options...
wigpip Posted November 13, 2010 Share Posted November 13, 2010 the HTML is not quite valid, use a structure like this with no HTML above the DOCTYPE: <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <head> <title>Untitled Document</title> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" /> </head> <body> </body> </html> Quote Link to comment https://forums.phpfreaks.com/topic/218476-my-website-need-criticism/#findComment-1133670 Share on other sites More sharing options...
Minimeallolla Posted November 13, 2010 Author Share Posted November 13, 2010 wigpip: Is this write, or does the doc type have to be dead first? cause if i dont put the include ("background.php"): at the very top it, for some reason gets a tiny breakline and looks different to what i want it to. well here is what i changed it to. <center> <a href="/index.php"><img border="0" src="/1.png"></a><a href="/login.php"><img border="0" src="/2.png"></a><a href="/logout.php"><img border="0" src="/3.png"></a><a href="register.php"><img border="0" src="/4.png"></a><a href="/games.php"><img border="0" src="/6.png"></a><style type="text/css"> <!-- body { background-image:url('homebackground.jpg'); background-repeat:no-repeat; background-attachment:fixed; } --> </style> <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd"> <HTML> <HEAD> <link rel="favicon.ico" href="http://www.rohan.giacjr.dino-hosting.net/favicon.ico"> <title> MySite </title> <style type="text/css"> <!-- A:link { COLOR: black; TEXT-DECORATION: none; font-weight: normal } A:visited { COLOR: black; TEXT-DECORATION: none; font-weight: normal } A:active { COLOR: green; TEXT-DECORATION: none } A:hover { COLOR: blue; TEXT-DECORATION: none; font-weight: none } --> </style> </HEAD> <BODY> <h4><font color="yellow"><DIV ALIGN=CENTER> Number of website views:</font><font color="white"> 010029</h4> Quote Link to comment https://forums.phpfreaks.com/topic/218476-my-website-need-criticism/#findComment-1133687 Share on other sites More sharing options...
Adam Posted November 13, 2010 Share Posted November 13, 2010 If you read the article I posted you'd know. Quote Link to comment https://forums.phpfreaks.com/topic/218476-my-website-need-criticism/#findComment-1133827 Share on other sites More sharing options...
Minimeallolla Posted November 14, 2010 Author Share Posted November 14, 2010 which article? Quote Link to comment https://forums.phpfreaks.com/topic/218476-my-website-need-criticism/#findComment-1134015 Share on other sites More sharing options...
Adam Posted November 14, 2010 Share Posted November 14, 2010 First and foremost I'd look at how to structure a HTML document correctly. You have no doctype, opening <html> tag, <head> section, or <body> section. These are the basic requirements for a HTML web page. Quote Link to comment https://forums.phpfreaks.com/topic/218476-my-website-need-criticism/#findComment-1134016 Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.