URL trimming function

[TheEvilMonkeyMan]

Hi,

I have a function using preg_replace_callback to go through a string replacing all instances of URLs with a link to that URL. It works, but not when the link is at the end of the string, since it uses white space to mark the end of the URL. I'm sure it can't be that hard. Could somebody help me out?

 

function trim_urls_callback($matches)
{
$temp = substr($matches[0], 0, 15);
$final = "<a href=\"$matches[0]\" title=\"$matches[0]\">$temp…</a> ";
return $final;
}

function trim_urls($string)
{
$string = preg_replace_callback('/(ht|f)tps?:\/\/[A-Za-z0-9_.-]{3,}\/?\s/', 'trim_urls_callback', $string);
return $string;
}

[sasa]

try

'/(ht|f)tps?:\/\/[A-Za-z0-9_.-]{3,}\/?\s|$/'

not tested

[JAY6390]

try \b instead of \s at the end

[TheEvilMonkeyMan]

The \b made it cut the URL off after the .com leaving out the /file.htm etc and not too much luck with the \s|$ - not sure why. And there's still a strange thing happening where a random <a will show up, breaking my website layout.  :-\

[JAY6390]

can you post some sample data

[TheEvilMonkeyMan]

http://www.ultimateglobes.com/Illuminated-World-Globes-s/4.htm you should find some nice ones there

 

You can find a variety of styles of gemstone world globes here: http://www.onlyglobes.com/ http://www.1worldglobes.com/1WorldGlobes/GemstoneGlobes/gemstoneglobes.htm http://www.worldglobes.com/ Or

 

[JAY6390]

Try this

$string = preg_replace_callback('/(ht|f)tps?:\/\/\S+/', 'trim_urls_callback', $string);

[TheEvilMonkeyMan]

Jay, you da man. That seems to be working for all my links. Thanks 

[JAY6390]

no problem