My user class

[ttocskcaj]

What do you think of my user class so far?

Room to improve, things to change etc.

I'm still getting the hang of this oop thing.

http://pastebin.com/fPFk21k4

[necken18]

Don't mix the var and the public keyword. they have the same functionality.

[lastkarrde]

Move the instantiation of the settings class into the constructor and make it available for all methods to use.

 

eg (in the class)

 

public $settings;

function __construct()
{
    $this->settings = new settings();
}

 

Then in your methods (isBanned, login, register) you can refer to the settings object as $this->settings, rather than repeating code to instantiate. This leaves your code cleaner, less lines and more maintainable.

[ttocskcaj]

Cool thanks for the advise 

necken18 I'm not sure what you mean? What line have I mixed them?

[lastkarrde]

You declared your class variables with var and some of your methods with public. I advise putting them all as public (or private/protected). var is PHP4-ish.

[ttocskcaj]

Ah ok, It's just something from a tutorial, probably old lol.

[KevinM1]

Don't use die for error handling.  Throw exceptions and catch them gracefully.

[ttocskcaj]

Yea, It's not finished yet lol, I haven't done any error catching or string cleaning etc. I just have the die's there so I know my query's fail, which they quite often do