Jump to content

The page isn't redirecting properly

tjverge

By tjverge
in PHP Coding Help

 Share

Recommended Posts

tjverge Member

tjverge

Posted
Posted

There seems to be something wrong with my code when run in Firefox I get an error, the full code is:

<head>
<script type="text/javascript" src="tabber.js"></script>
<link rel="stylesheet" href="example.css" TYPE="text/css" MEDIA="screen">
<link rel="stylesheet" href="example-print.css" TYPE="text/css" MEDIA="print">
<script type="text/javascript">
</script>
</head>
<div class="tabber">
<?php
if (!isset($_GET["name"]) || empty($_GET["name"])) 
{
$corpname = rawurlencode(stripslashes($_POST['corpname']));	
}
else
{
$corpname = rawurlencode(stripslashes($_GET['name']));
}

//Check if Corp is in DataBase
$sql = "SELECT * FROM `corps` where `name` = '$corpname'";
$result = mysql_query($sql);
$num = mysql_num_rows($result);


// If Corp Is In DB
if ($num > 0)
{
While ($row = mysql_fetch_array($result))
{
?>
<div class="tabbertab">
<h2>Corp Info</h2>
<table width ="700" border="0" cellspacing="0" cellpadding="0">
  <tr>
    <td width="128" rowspan="7"><?php echo "<img src=http://image.eveonline.com/Corporation/".$row['id']."_128.png width=128 height=128 />"; ?></td>
    <td width="128">Corp Name</td>
    <td><?php echo "<a href= http://eve.battleclinic.com/killboard/combat_record.php?type=corp&name=".rawurlencode($row['name'])." target=_blank>".$row['name']."</a>"; ?></td>
  </tr>
  <tr>
    <td width="128">Ticker</td>
    <td><?php echo $row['ticker']; ?></td>
  </tr>
  <tr>
    <td width="128">Allance</td>
     <td><?php
$alliance = $row['alliance'];
if($alliance =="0")
{
$alliance0 = "No Alliance";	
echo $alliance0;
}
Else
{
$sql = "SELECT * FROM `alliance` WHERE `id` = '$alliance'";
$result = mysql_query($sql);
$num=mysql_numrows($result);
$i=0;
while ($i < $num) {
$alliance0=mysql_result($result,$i,"name");	
$i++;
}
echo $alliance0;
}
?></td>
  </tr>
  <tr>
    <td width="128">CEO Name</td>
    <td><?php echo "<a href=main.php?id=pilotsearch.php&name=".$row['ceo'].">".$row['ceo']."</a>"; ?></td>
  </tr>
  <tr>
    <td width="128">Headquarters</td>
    <td><?php echo $row['hq']; ?></td>
  </tr>
  <tr>
    <td width="128">Tax Rate</td>
    <td><?php echo $row['tax']; ?> %</td>
  </tr>
  <tr>
    <td width="128">Member Count</td>
    <td><?php echo $row['members']; ?></td>
  </tr>
</table>
</div>
<div class="tabbertab">
<?php
  $query=mysql_query("SELECT DISTINCT(name) FROM `characters` WHERE `corporation` = '$corpname' ORDER BY name ASC") or die("Error Occured,plz try again");
$numm = mysql_num_rows($query);

      echo "<h2>Known Members (".$numm."/".$row['members'].") </h2>";

echo "<table border='0' width='100%' cellspacing='0' cellpadding='0'>";

$left = true;
while($row=mysql_fetch_array($query))
{
if ($left)
{
echo "<tr>";
}
echo "<td align='left' width='50%' cellspacing='0' cellpadding='0' >";
echo "<a href=main.php?id=pilotsearch.php&name=".rawurlencode($row['name']).">".$row['name']."</a>";
echo"</td>";
if (!$left)
{
echo"</tr>";
}
$left = !$left;
}

echo"</table>";
?>
</div>
<div class="tabbertab">
    <?php
 $sql = "SELECT * FROM `corpwhsystems` WHERE `corpname` = '$corpname'";
$result = mysql_query($sql);
$num_rows = mysql_num_rows($result);
echo"<h2>WH Locations (".$num_rows.")</h2>";


$i=0;
?>
<table width="728" border="0">
  <tr>
    <td><strong>System Name</strong></td>
    <td><strong>System Class</strong></td>
    <td><strong>Effect</strong></td>
    <td><strong>Date Added</strong></td>
    <td><strong>Added By</strong></td>
  </tr>
<?php  
while ($i <= $num_rows) {

$sname=mysql_result($result,$i,"systemname");
$sclass=mysql_result($result,$i,"systemtype");
$anomaly=mysql_result($result,$i,"anomaly");
$addedby=mysql_result($result,$i,"updatedby");
$dateupdated=mysql_result($result,$i,"dateupdated");

?> 
  <tr>
    <td>
    <?php echo $sname; ?></td>
    <td>
    <?php echo $sclass; ?></td>
    <td>
        <?php echo $anomaly; ?></td>
    <td>
    <?php echo $dateupdated; ?></td>
    <td>
    <?php echo $addedby; ?></td>
<?php
$i++;
}
?>
  </tr>
</table>
<hr />
<form action="main.php?id=addwh.php" method="post">
Add WH Location: <input name="location" type="text" />
<select name="systemtype">
<option value="Class 1">Class 1</option>
<option value="Class 2">Class 2</option>
<option value="Class 3">Class 3</option>
<option value="Class 4">Class 4</option>
<option value="Class 5">Class 5</option>
<option value="Class 6">Class 6</option>
</select>
<select name="anomaly">
<option value="None">None</option>
<option value="Magnetar">Magnetar</option>
<option value="Red Giant">Red Giant</option>
<option value="Pulsar">Pulsar</option>
<option value="Wolf Rayet">Wolf Rayet</option>
<option value="Cataclysmic Variable">Cataclysmic Variable</option>
<option value="Black Hole">Black Hole</option>
</select>
<input name="corpname" type="hidden" value="<?php echo $cnamedb; ?>" />
<input name="addwh" type="submit" value="Add" />
</form>
</div>
<div class="tabbertab">
<?php
$sql = "SELECT * FROM `corps` WHERE `name` = '$corpname' AND `notedate` != '0000-00-00'";
$result = mysql_query($sql);
$num_rows = mysql_num_rows($result);
 echo"<h2>Notes(".$num_rows.")</h2>";


$i=0;
?>
<table width="700" border="0" cellspacing="0" cellpadding="0">
  <tr>
    <td width="480"><strong>Note</strong></td>
    <td width="119"><strong>Note Date</strong></td>
    <td width="101"><strong>Added By</strong></td>
  </tr>
<?php
while ($i <= $num_rows) {

$notes=mysql_result($result,$i,"notes");
$notedate=mysql_result($result,$i,"notedate");
$updatedby=mysql_result($result,$i,"updatedby");

?>
  <tr>
  <td><br />
    <?php echo $notes; ?></td>
  <td width="136"><br />
    <?php echo $notedate; ?></td>
  <td width="105"><br />
   <?php echo $updatedby; ?></td>
  </tr>
<?php
$i++;
}
?>
  </table>
<hr />
<form action="main.php?id=updatecorptint.php" method="post">
<strong>Add Notes:</strong>
<textarea name="notes" cols="50" rows="10"></textarea>
<input name="cname" type="hidden" value="<?php echo $cnamedb; ?>" />
<input name="add" type="submit" value="Add Notes" />
</form>
</div>
<div class="tabbertab">
<?php  
$sql = "SELECT * FROM `pos` WHERE `corp` = '$corpname'";
$result = mysql_query($sql);
$num_rows = mysql_num_rows($result);
  echo"<h2>POS (".$num_rows.")</h2>";


$i=0;
?>
POS:
<table width="700" border="0" cellspacing="0" cellpadding="0">
  <tr>
    <td><strong>Location</strong></td>
    <td><strong>Type</strong></td>
    <td><strong>Size</strong></td>
    <td><strong>Corp Hangars</strong></td>
    <td><strong>Ship Hangars</strong></td>
    <td><strong>Notes</strong></td>
    
  </tr>
<?php
while ($i <= $num_rows) {

$location=mysql_result($result,$i,"location");
$type=mysql_result($result,$i,"type");
$size=mysql_result($result,$i,"size");
$changar=mysql_result($result,$i,"changar");
$shangar=mysql_result($result,$i,"shangar");
$notes=mysql_result($result,$i,"notes");

?>
  <tr>
  <td><br /><?php echo $location; ?></td>
  <td><br /><?php echo $type; ?></td>
  <td><br /><?php echo $size; ?></td>
  <td><br /><?php echo $changar; ?></td>
  <td><br /><?php echo $shangar; ?></td>
  <td><br /><?php echo $notes; ?></td>
  </tr>
<?php
$i++;
}
?>
</table>
<hr />
<form action="main.php?id=addpos.php" method="post">
<table width="350" border="0" cellspacing="0" cellpadding="0">
  <tr>
    <td>Location:</td>
    <td><label for="location"></label>
      <input type="text" name="location" id="location" /></td>
    <td>Type:</td>
    <td><select name="type">
    <option value="Amarr">Amarr</option>
    <option value="Angel">Angel</option>
    <option value="Blood">Blood</option>
    <option value="Caldari">Caldari</option>
    <option value="Dark Blood">Dark Blood</option>
    <option value="Domination">Domination</option>
    <option value="Dread Guristas">Dread Guristas</option>
    <option value="Gallente">Gallente</option>
    <option value="Gurstas">Gurstas</option>
    <option value="Minmatar">Minmatar</option>
    <option value="Sansha">Sansha</option>
    <option value="Serpentis">Serpentis</option>
    <option value="Shadow">Shadow</option>
    <option value="True Sansha">True Sansha</option>
    </select></td>
    <td>Size:</td>
    <td><select name="size">
    <option value="Large">Large</option>
    <option value="Medium">Medium</option>
    <option value="Small">Small</option>
    </select></td>
  </tr>
  <tr>
    <td>Corp Hangars:</td>
    <td><input name="changar" type="text" size="10" /></td>
    <td>Ship Hangars:</td>
    <td><input name="shangar" type="text" size="10" /></td>
    <td>Notes:</td>
    <td><textarea name="notes"></textarea></td>
  </tr>
</table>
<input name="cname" type="hidden" value="<?php echo $cnamedb; ?>" />
<input name="submit1" type="submit" value="Add POS" />
</form>
</div>
</div>
<?php
}}
// IF Corp Is Not In DB
ELSE
{
$url = 'http://api.eve-dev.com/eve/CharacterID.xml.aspx?names='.$corpname.'';
$xml = simpleXML_load_file($url,"SimpleXMLElement",LIBXML_NOCDATA);
$url = 'http://api.eve-dev.com/eve/CharacterID.xml.aspx?names='.$corpname.'';
$xml = simpleXML_load_file($url,"SimpleXMLElement",LIBXML_NOCDATA);
$corpid = $xml->result->rowset->row['characterID'];
$url1 = 'http://api.eve-dev.com/corp/CorporationSheet.xml.aspx?CorporationID='.$corpid.'';
$xml1 = simpleXML_load_file($url1,"SimpleXMLElement");
$cname = $xml1->result->corporationName;
if($corpid == 0 OR $cname =="")
{
Echo $corpname."<br>No Corp Found In EVE Database";	
}
ELSE
{
$url1 = 'http://api.eve-dev.com/corp/CorporationSheet.xml.aspx?CorporationID='.$corpid.'';
$xml1 = simpleXML_load_file($url1,"SimpleXMLElement");
$cname = $xml1->result->corporationName;
$url1 = 'http://api.eve-dev.com/corp/CorporationSheet.xml.aspx?CorporationID='.$corpid.'';
$xml1 = simpleXML_load_file($url1,"SimpleXMLElement");
$cname = $xml1->result->corporationName;
$ticker = $xml1->result->ticker;
$ceo = $xml1->result->ceoName;
$station = $xml1->result->stationName;
$descrption = $xml1->result->description;
$alliance = $xml1->result->allianceID;
$tax = $xml1->result->taxRate;
$members = $xml1->result->memberCount;
$username = $_SESSION['username'];
mysql_query("INSERT INTO `corps` (`editid` , `id` , `name` , `ticker` , `alliance` , `ceo` , `tax` , `members` , `hq` , `apidate` , `notes` , `notedate` , `updatedby`) VALUES ( '' , '$corpid', '$cname', '$ticker', '$alliance', '$ceo', '$tax', '$members', '$station', NOW(), '', '', '$username')");
header('Location: main.php?id=corpsearch.php&name='.$corpname);
exit;
}
}
?>

 

The problem area is somewhere in here (I think):

// IF Corp Is Not In DB
ELSE
{
$url = 'http://api.eve-dev.com/eve/CharacterID.xml.aspx?names='.$corpname.'';
$xml = simpleXML_load_file($url,"SimpleXMLElement",LIBXML_NOCDATA);
$url = 'http://api.eve-dev.com/eve/CharacterID.xml.aspx?names='.$corpname.'';
$xml = simpleXML_load_file($url,"SimpleXMLElement",LIBXML_NOCDATA);
$corpid = $xml->result->rowset->row['characterID'];
$url1 = 'http://api.eve-dev.com/corp/CorporationSheet.xml.aspx?CorporationID='.$corpid.'';
$xml1 = simpleXML_load_file($url1,"SimpleXMLElement");
$cname = $xml1->result->corporationName;
if($corpid == 0 OR $cname =="")
{
Echo $corpname."<br>No Corp Found In EVE Database";	
}
ELSE
{
$url1 = 'http://api.eve-dev.com/corp/CorporationSheet.xml.aspx?CorporationID='.$corpid.'';
$xml1 = simpleXML_load_file($url1,"SimpleXMLElement");
$cname = $xml1->result->corporationName;
$url1 = 'http://api.eve-dev.com/corp/CorporationSheet.xml.aspx?CorporationID='.$corpid.'';
$xml1 = simpleXML_load_file($url1,"SimpleXMLElement");
$cname = $xml1->result->corporationName;
$ticker = $xml1->result->ticker;
$ceo = $xml1->result->ceoName;
$station = $xml1->result->stationName;
$descrption = $xml1->result->description;
$alliance = $xml1->result->allianceID;
$tax = $xml1->result->taxRate;
$members = $xml1->result->memberCount;
$username = $_SESSION['username'];
mysql_query("INSERT INTO `corps` (`editid` , `id` , `name` , `ticker` , `alliance` , `ceo` , `tax` , `members` , `hq` , `apidate` , `notes` , `notedate` , `updatedby`) VALUES ( '' , '$corpid', '$cname', '$ticker', '$alliance', '$ceo', '$tax', '$members', '$station', NOW(), '', '', '$username')");
header('Location: main.php?id=corpsearch.php&name='.$corpname);
exit;
}
}
?>

 

Any one with any ideas?

Link to comment
https://forums.phpfreaks.com/topic/234612-the-page-isnt-redirecting-properly/
Share on other sites
tjverge Member

tjverge

Posted
  • Author
Posted

There can be nothing whatsoever output to the browser before header().

I'm guessing your talking about this line header('Location: main.php?id=corpsearch.php&name='.$corpname); as it's the last thing in my script where would it be better placed and still work?

Pikachu2000 Prolific Member

Pikachu2000

Posted
Posted

If you're going to use header() to redirect, you need to perform all processing logic and send the header() before anything else is sent. As it's written at the moment, the very first line in your file is output to the browser. You should also be developing with error_reporting = -1 and display_errors = On in your php.ini file so these errors are reported to you as they occur. There's a sticky topic in this forum on header errors. You should have a read of it and restructure your code.

 

Also, when you use header() to redirect, it should be immediately followed by exit(); to stop any further execution of the script.

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing
×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.