Undefined index: action

[Dexlin]

Hi all,

 

I my making a site which to be easier i have  made a querystring statement, but the issue is that when accessing /?action= shows index and ?action=register shows register great!, when accessing root / of the site or index.php and displays Undefined index: action , when clearly i have defined action with $id, so why is php saying it is not. I know there is the option for error_reporting(0), but i want to know why this is happening.

 

Edit: the script is, and runs fine other than the error!

 

<?php 
$id = "action";
$string = $_GET["$id"];

	if ($string == "register") {
		echo 'register';
	} else {
		echo 'index';
}


?>

 

Many Thanks

 

 

 

[fugix]

your $id var might be returning empty...hard to say without seeing some code

[QuickOldCar]

You should post your code.

 

But are you doing a check if action is set or not?

 

if(isset($_GET['action'])) {
//execute the query
}

//or even
if(!isset($_GET['action']) || $_GET['action'] == "") {
//do not execute the query
} else {
//execute the query
}

[spiderwell]

$id = "action";
$string = $_GET["$id"];

god know what you are trying to do there.

 

use this

$string = isset($_GET['action']) ? $_GET['action'] : 'index';

that says if there is an 'action' variable, pass its value to $string, else $string = 'index'

[fugix]

$id = "action";
$string = $_GET["$id"];

what is the logic behind this?

[Dexlin]

Thanks for the reply. When i put the isset statement in the error still appeared but after moving the $string = $_GET["id"] into the isset statement and outside of it, the error has gone away sorted code follows:

 

<?php 
$id = "action";

	if (isset($_GET["$id"])) {

	    $string = $_GET["$id"];

	if ($string == "register") {
		echo 'register';
	} 
}


?>

Many thanks for your help  

[teynon]

Holy code injection, Batman! That's ugly. You should validate all variables that can be set via post or get.

[fugix]

Thanks for the reply. When i put the isset statement in the error still appeared but after moving the $string = $_GET["id"] into the isset statement and outside of it, the error has gone away sorted code follows:

 

<?php 
$id = "action";

	if (isset($_GET["$id"])) {

	    $string = $_GET["$id"];

	if ($string == "register") {
		echo 'register';
	} 
}


?>

Many thanks for your help  

excellent...please mark this thread as solved..lower left of the thread..and as a side note..if you are retrieving a variable useing $_GET, you do not need quotes

$_GET[$id]

[Dexlin]

sorry, i trying to get to grips with php

 

 

 

 

[Dexlin]

Thanks for the tip , i will clean the code up