How to avoid empty line

[fireballchad]

After a lot of googling yesterday I managed to get a text area to import data into a database for every new line.

 

I noticed today that it imports an extra empty line at the very end of the list in the text area.

 

Here is my code that does the importing:

    $area = array_map('trim', explode("\n", $_POST['area']));
    foreach($area as $line) {
$query = "INSERT INTO QuotationsTBL(Quotation)VALUES('$line')";
if(mysql_query($query)){
}else{
echo "Fail, please try again";}
}

 

Like I said I googled (had to use several different websites including here )a lot to figure this out so I don't quite understand how it works ie the array_map('trim' ..ect part

 

Any advice to get rid of that empty line would be wonderful!

 

[monkeytooth]

if(!empty(trim($line))){/*do stuff*/}else{/*error*/}

 

maybe.. not sure though..

[fireballchad]

Also cant seem to get it to work... I googled empty() and you cant do emtpy(trim($var))

 

Well after looking at it closer it appers when I would copy&paste my data I would get an empty line at the end, I can delete it and it will not import a blank entry.

 

My question still stands though it would be nice to be able to avoid this on accident.

[Pikachu2000]

This will remove explode the textarea on the line breaks, and unset any elements that consist of nothing but a line break. Don't run queries in a loop when it's avoidable, and in this case it is avoidable. After the loop has cleaned up the array, implode it with )', (' as the glue, and then execute the query once with the imploded values. Echo $query to see what the query string looks like . . .

 

$area = explode("\n", $_POST['area']);
foreach( $area as $k => $v ) {
   $v = trim($v);
   if( empty($v) ) {
      unset($area[$k]);
   }
}
$values = implode("'), ('", $area);
$query = "INSERT INTO QuotationsTBL (Quotation) VALUES ('$values')";

 

I prefer to use string functions like above when possible, but another way would be with preg_replace . . .

 

$_POST['area'] = preg_replace("~\n{2,}~", "\n", $_POST['area']);
$area = explode("\n", trim($_POST['area']));
$values = implode("'), ('", $area);
$query = "INSERT INTO QuotationsTBL (Quotation) VALUES ('$values')";

[fireballchad]

Thank you so much for the help and better coding edict!

 

Solved!