select field echo selected

[fife]

hi

 

Im trying to make this select drop down echo selected but with no joy.  Please help

 

$qGetCounty = "SELECT * FROM Counties ORDER BY FIELD(country,'England','Wales','Scotland'), county ";
$rGetCounty = mysql_query($qGetCounty);

echo "<select name=\"county\">";
$PrevCountry = "";
while ($county = mysql_fetch_assoc($rGetCounty))
{
	if ($county['country'] != $PrevCountry)
	{
		$PrevCountry = $county['country'];
		echo "<optgroup label='$PrevCountry'>";
	}
//MyDetails is the array

	echo " <option " . ($selected ? "selected=\"selected\"$MyDetails['county']" : "") . " value= '{$county['county']}'>{$county['county']}</option>";
}
echo "</select>" ;

[fife]

correction

code change but still not working

$qGetCounty = "SELECT * FROM Counties ORDER BY FIELD(country,'England','Wales','Scotland'), county ";
$rGetCounty = mysql_query($qGetCounty);

echo "<select name=\"county\">";
$PrevCountry = "";
while ($county = mysql_fetch_assoc($rGetCounty))
{
	if ($county['country'] != $PrevCountry)
	{
		$PrevCountry = $county['country'];
		echo "<optgroup label='$PrevCountry'>";
	}
	$selected = ($row_ClubDetails['county']) ? ' selected="selected"' : '';
	echo " <option value= '\"$i\"$selected'>{$county['county']}</option>";
}
echo "</select>" ;

 

[fife]

oh and the $i was removed. sorry

[AyKay47]

have you debugged your mysql query?

what are your actual results?

[fife]

yes the query works fine as i am displaying other information from the same query.  With the current code however if I click update it insert into county....

 

""

 

 

[Pikachu2000]

You're treating $row_ClubDetails['county'] as a boolean. You should be comparing it to whatever's in the value= attribute of the tag. You also have included the $selected variable within the quotes for the value= attribute, which it should not be. And where is the value of $i coming from?

 

	$selected = ($row_ClubDetails['county']) ? ' selected="selected"' : ''; // No comparison to another value?