Alternative to foreach Mysql help

[MDanz]

I have a large array. Is there an alternate method to check if $value in the array is present in the MySql table vote and if not then insert $value into vote. This is what i am doing currently. Is there a better method?

 

foreach($rowids as $value) {


        $select = mysql_query("SELECT voteid FROM vote WHERE username='$username' AND voteid='$value' LIMIT 1",$this->connect);

            if(mysql_num_rows($select)==0) {

        $insert = mysql_query("INSERT INTO vote VALUES ('','$value','$username')",$this->connect);

            }
        }

 

 

[fenway]

Why do you need to insert blank?

[MDanz]

blank is the auto incremented primary key id of the mysql table vote.

[fenway]

You should never do that.

 

First, you should always explicitly list your column names.

Two, you should leave out the auto-increment column.

Three, why are you copying data?

[MDanz]

so you mean like this

 

foreach($rowids as $value) {


        $select = mysql_query("SELECT voteid FROM vote WHERE username='$username' AND voteid='$value' LIMIT 1",$this->connect);

            if(mysql_num_rows($select)==0) {

        $insert = mysql_query("INSERT INTO vote (id,voteid,username) VALUES ('','$value','$username')",$this->connect);

            }
        }

 

i still need another method rather than a foreach loop.  Could unique index or insert ignore work?  voteid is the id of a row from a different table btw.

[fenway]

And INSERT INTO... SELECT WHERE would work.

 

But, again, why are you duplicating data?

[MDanz]

what data am i duplicating?  $rowids is an array with different values.  Could i have an example of this

 

And INSERT INTO... SELECT WHERE would work.

[fenway]

You're copying value & username from table1 to table2.