Test if string ends in -[number]

[John_A]

I've got a string which is usually abc-def-0123 but it sometimes has an additional dash and then a single digit (e.g. ghi-jkl-4567-1).

 

It's always the same pattern and length, (three letters, a dash, three letters, a dash, 4 digits then the possibility of a dash followed by a single digit).

 

What's the best way to test if the string ends in a dash followed by a single digit?

 

Any help much appreciated!

[scootstah]

Regular expressions.

$str = 'ghi-jkl-4567-1';

if (preg_match('/-[0-9]{1}$/', $str)) {
echo 'match';
}

[John_A]

Many thanks!

 

What's the best way to then remove the offending -[digit] from the string (sorry, I should have included this in my original question)?

[scootstah]

Still regular expressions. 

$str = 'ghi-jkl-4567-1';

preg_replace('/-[0-9]{1}$/', '', $str);

[John_A]

Excellent, just what I needed. Thanks 

[Psycho]

Still regular expressions. 

$str = 'ghi-jkl-4567-1';

preg_replace('/-[0-9]{1}$/', '', $str);

Why the {1}? You already have the dollar sign to indicate only the end of the string so no repetition criteria is necessary.

 

@John_A: It may not be clear, but with scootstah's replacement solution you do not need to test if there is a -[digit] before trying to remove it. Just run the preg_replace() to remove the -[digit]. If it does not exist it won't be replaced. So, testing for it is a waste of code. For what it's worth, I would use this expression:

$str = preg_replace('/-\d$/', '', $str);

 

The \d is a character class for digit.

 

[John_A]

Thanks again 

[scootstah]

Still regular expressions. 

$str = 'ghi-jkl-4567-1';

preg_replace('/-[0-9]{1}$/', '', $str);

Why the {1}? You already have the dollar sign to indicate only the end of the string so no repetition criteria is necessary.

 

@John_A: It may not be clear, but with scootstah's replacement solution you do not need to test if there is a -[digit] before trying to remove it. Just run the preg_replace() to remove the -[digit]. If it does not exist it won't be replaced. So, testing for it is a waste of code. For what it's worth, I would use this expression:

$str = preg_replace('/-\d$/', '', $str);

 

The \d is a character class for digit.

 

 

My regex is mediocre at best. Thanks for the optimization.