Nesting operators

[fife]

I have a query that is very messy.  I have tried using () to seperate everything and when I do it just all goes wrong.

 

here is the query

 

SELECT posts.*, users.*, countries.countryID, countries.country FROM posts 
INNER JOIN users ON users.userID = posts.postUserID INNER JOIN countries ON countries.countryID = users.userCountry WHERE posts.cityID = '".$row_rs_city['cityID']."'  AND posts.type = 'sightseeing' OR posts.cityID = '".$row_rs_city['cityID']."' AND posts.type = 'Inner city sightseeing' OR posts.cityID = '".$row_rs_city['cityID']."' AND posts.type = 'Outer city sightseeing'  ORDER BY posts.postID DESC

 

Is there a way of re-writing this so that it has brackets seperating everything and it will still work.  It works for the minute but re- writing posts.cityID = '".$row_rs_city['cityID']."' inbetween every OR just seems wrong.

 

Thanks for your help guys

[Adam]

Your WHERE condition doesn't make much sense:

 

SELECT posts.*,
       users.*,
       countries.countryID,
       countries.country
FROM posts 
INNER JOIN users ON (users.userID = posts.postUserID)
INNER JOIN countries ON (countries.countryID = users.userCountry)
WHERE posts.cityID = '".$row_rs_city['cityID']."'
  AND posts.type = 'sightseeing'
   OR posts.cityID = '".$row_rs_city['cityID']."'
  AND posts.type = 'Inner city sightseeing'
   OR posts.cityID = '".$row_rs_city['cityID']."'
  AND posts.type = 'Outer city sightseeing'
ORDER BY posts.postID DESC

 

What's the logic behind it, in English? That very much dictates where the parentheses should go.

[fife]

Ive solved it with a new operator I'd never used or seen before. Here is the fixed query

 

SELECT posts.*, users.*, countries.countryID, countries.country FROM posts 
INNER JOIN users ON users.userID = posts.postUserID 
INNER JOIN countries ON countries.countryID = users.userCountry 
WHERE posts.cityID = '".$row_rs_city['cityID']."'
AND 
posts.type IN ('sightseeing', 'Inner city sightseeing', 'Outer city sightseeing') 
ORDER BY posts.postID DESC

 

Thanks anyway guys