Display data from MySQL

[microbert]

I am managing a shop website which is using php and mysql for data.

 

The website has a section that will display the related products with the one that you are watching. Now my problem is that if there are more than 5 items it will continue to display all the items in one row with the consequent that the page will not display well.

 

I need to find a way to begin a new row after the 5th item so it will display 5 items in each row.

 

this is my current code that is responsible for showing the related items. There is also a picture attached with the problem.

 

while ($row = mysql_fetch_array($retd))

{

$code = $row["code"];

$name = $row["name"];

 

echo("<td width=150 align=center>");

echo ("<a href=../products/info.php?scode=$code><img src=pictures/$code.gif border=0 alt=Item $name</a>");

echo ("<br><a href=../products/info.php?scode=$code><span class=fs13>$name</span></a>");

echo("</td>");

}

 

 

 

Does anyone know how can I do this?

[scootstah]

Basically, you'll need to use a little logic to end rows and create new ones. One way to do that is to increment a counter and then just test the counter's value.

 

My code is a little different than yours, just for simplicity but it's the same concept.

// create an array to loop through
$array = range(1,20);

// set number of columns per row
$cols = 5;

// start our counter
$i = 0;

echo '<table>';
foreach($array as $arr)
{
// check the modulus of our counter
// if it is 0 we have to start a new row
if ($i % $cols == 0) {
	if ($i > 0) {
		// end the current row if it isnt the first row
		echo '</tr>';
	}

	echo '<tr>';	
}

echo '<td>' . $arr . '</td>';

// increment the counter
// this is important, dont forget this
$i++;
}
echo '</tr>';
echo '</table>';

[microbert]

I have tried your code and it worked fine with the numbers, but I am finding a problem to get the data from the mysql database and then display it that way.

 

Can you tell me how can I fill the array from the database field?

[litebearer]

http://www.phpfreaks.com/forums/index.php?topic=95426.0

[scootstah]

Do the same thing only in the while loop.

// define the number of columns per row
$cols = 5;

// start the counter
$i = 0;

while ($row = mysql_fetch_array($retd))
{
$code = $row["code"];
$name = $row["name"];

if ($i % $cols == 0) {
	if ($i > 0) {
		echo '</tr>';
	}
	echo '<tr>';
}

echo("<td width=150 align=center>");
echo ("<a href=../products/info.php?scode=$code><img src=pictures/$code.gif border=0 alt=Item $name</a>");
echo ("<br><a href=../products/info.php?scode=$code><span class=fs13>$name</span></a>");
echo("</td>");

// increment the counter
$i++;
}

[microbert]

Hi,

 

I have tried applying your code into my website and now I have another problem now it is only displaying 2 items instead of 8.

here is a link to the problem.

 

http://bitsandbytesmalta.host56.com/products/info.php?scode=UDPT1010

[scootstah]

I need your code, not a link.

[microbert]

I have managed to solve the problem that was showing only two items,

 

now I'd like to make it to show 5 items on 1 line and then continue on another line.

 

this the code:

 

 

// define the number of columns per row
$cols = 5;
// start the counter
$count = 0;										
while ($row = mysql_fetch_array($retd)) 
{ 
$code = $row["code"];
$name = $row["name"];

if ($count % $cols == 0)
 {
	if ($c > 0) 
	{
		echo '</tr>';
	}
	echo '<tr>';
}
echo("<td width=150 align=center>");
	echo ("<a href=../products/info.php?scode=$code><img src=pictures/$code.gif border=0 alt=Item $name</a>");
	echo ("<br><a href=../products/info.php?scode=$code><span class=fs13>$name</span></a>");
echo("</td>");

//increment the counter
$count++;
}

 

[scootstah]

I think your problem is here: if ($c > 0). It should be if ($count > 0).

[microbert]

I have changed that before your reply because I too thought that it was the problem but still the same problem.

[microbert]

Hi, does anyone have an idea of what should I try now?

 

this is my final updated code:

// define the number of columns per row
$cols = 5;
// start the counter
$counter = 0;										
while ($row = mysql_fetch_array($retd)) 
{ 
$code = $row["code"];
$name = $row["name"];

if ($counter % $cols == 0)
{
	if ($counter > 0) 
	{
		echo '</tr>';
	}
	echo '<tr>';
}
echo("<td width=150 align=center>");
	echo ("<a href=../products/info.php?scode=$code><img src=pictures/$code.gif border=0 alt=Item $name</a>");
	echo ("<br><a href=../products/info.php?scode=$code><span class=fs13>$name</span></a>");
echo("</td>");

//increment the counter
$counter++;

[ras1986]

I don't see a problem.. I've tried your code and it generates 5 columns just like you wanted..

[microbert]

On my end it is generating this:

http://bitsandbytesmalta.host56.com/products/info.php?scode=UDPT1010

[ras1986]

Is your $counter incremented inside the while loop? Because I can't see a closing for the while loop. Make sure its inside the loop.

[microbert]

sorry about that I had the } missing, but in my original code it is there and yes the $counter++ is in the while loop.

[ras1986]

Would you mind posting the code for the full page? I tried the code you posted before and it works fine for me.

[microbert]

Hi,

 

I am still trying to solve this problem, so if there are someone out there that have an idea of how can I solve it, please let me know i really need this.

 

this is my latest version of the code:

// define the number of columns per row
$cols = 5;
// start the counter
$counter = 0;										
while ($row = mysql_fetch_array($retd)) 
{ 
$code = $row["code"];
$name = $row["name"];

if ($counter % $cols == 0)
{
	if ($counter > 0) 
	{
		echo '</tr>';
	}
	echo '<tr>';
}
echo("<td width=150 align=center>");
	echo ("<a href=../products/info.php?scode=$code><img src=pictures/$code.gif border=0 alt=Item $name</a>");
	echo ("<br><a href=../products/info.php?scode=$code><span class=fs13>$name</span></a>");
echo("</td>");

//increment the counter
$counter++;
}

 

This is a link to the problem that I have:

http://bitsandbytesmalta.host56.com/products/info.php?scode=UDPT1010

The related items need to be 5 in every line.

 

thanks in advance for your help.

[scootstah]

I find it hard to believe that that is the code on your link; because there's no error with that snippet. It should be creating a new row every 5th iteration but your live example creates one on every iteration, which is not possible given the above snippet.

 

I've tested it again and it works without issue for me. You need to give us the exact code for the link you have provided.

[microbert]

I am attaching the php file of that page.

18047_.php

[scootstah]

That code is a nightmare.

 

I suspect your problem is here:

$SQL = " SELECT * FROM list ";
$SQL = $SQL . " WHERE code = '$pieces[$i]' ";
$retd = mysql_db_query($db, $SQL, $cid);

if (!$retd) 
{ 
echo( mysql_error()); 
}
else 
{
// define the number of columns per row
$cols = 5;
// start the counter
$counter = 0;										
while ($row = mysql_fetch_array($retd)) 
{ 
	$code = $row["code"];
	$name = $row["name"];

	/*if ($counter % $cols == 0)
	{
		if ($counter > 0) 
		{
			echo '</tr>';
		}
		echo '<tr>';
	}*/
	if ($counter % $cols == 0)
	{
		if ($counter > 0) 
		{
			echo '</tr>';
		}
		echo '<tr>';
	}
	echo("<td width=150 align=center>");
		echo ("<a href=../products/info.php?scode=$code><img src=pictures/$code.gif border=0 alt=Item $name</a>");
		echo ("<br><a href=../products/info.php?scode=$code><span class=fs13>$name</span></a>");
	echo("</td>");

	//increment the counter
	$counter++;
}
}

 

I didn't dig too deeply but I would venture a guess that you are only returning one row at a time.

 

You need to clean up this code a lot. Running queries in nested loops like that is a bad, bad thing. You can most likely gather the same data in a single query.

[microbert]

I thought so that the problem is somewhere there but could not find the problem.

 

About the code I know that it is a nightmare but it was not written by me and I am not that good in coding php, so it is taking me a lot of time to figure what to change and how to change it.

[scootstah]

How many rows are returned with that query each time?

[microbert]

it is diplaying them 1 in each row I wanted to make 5 columns and then a new row.

here you can see the result:

http://bitsandbytesmalta.host56.com/products/info.php?scode=UDPT1010

[scootstah]

That's not what I meant.

 

Put this

echo 'Rows returned: ' . mysql_num_rows($retd) . '<br />';

after this

$SQL = " SELECT * FROM list ";
$SQL = $SQL . " WHERE code = '$pieces[$i]' ";
$retd = mysql_db_query($db, $SQL, $cid);

 

And then post the output.

[microbert]

Sorry about that.

 

This is the result:

 

Rows returned: 1

Rows returned: 1

Rows returned: 1

Rows returned: 1

Rows returned: 1

Rows returned: 1

Rows returned: 1

Rows returned: 1

Rows returned: 0

 

there is a picture also attached