While Loop Error

[sws]

Hi,

I've written a query to pull all of my data and sort it by a column in descending order.

I'm getting the following error: [b]parse error, unexpected '=' in hockey_contests.php on line 47[/b]

Can anybody spot the error ?

Thanks in advance !


[code]  <table>
<?
$standings_sql = "SELECT * FROM nhl_teams ORDERBY points DESC";
$standings_query = mysql_query($standings_sql);

while(mysql_fetch_array($standings_query) = $table_rows)
{
  ?>

<tr>
  <td colspan="2">
  <h3>League Leaders</h3>
  </td>
</tr>
<tr>
  <td>
  <?=$table_row[name]?>
  </td>
  <td>
  <?=$table_row[points]?>
  </td>
</tr>
<?
}

?>

</table>[/code]

[Kano]

<?php echo "$table_row[name]" ?>

[Zane]

This is backwards
mysql_fetch_array($standings_query) = $table_rows

it should be

$table_rows = mysql_fetch_array($standings_query)

Furthermore, you need to call it $table_row instead so it will work.
seeing as how you're calling $table_row[points] and such

also the word points need to be in quotes
same for name too

i.e.
$table_row['points']

[Kano]

does <? work the same as <?php

[Zane]

[quote author=Kano link=topic=114272.msg464894#msg464894 date=1163000588]
does <? work the same as <?php
[/quote]

yes, as long as you have short_tags turned on

the only real difference is that you can do echo statements on the fly with short tags

for instance
<?="stuff" ?>
is the equivalent of
<?php echo 'stuff" ?>

[Kano]

What and how is short tags turned on ? thanks

[sws]

Excellent. Thanks for your help. Problem solved !!

[Zane]

in your php.ini file
look for the first occurance of short_tags
and set it to on, or true or whatever the positive value is supposed to be

[cmazur]

Just one more thing concerning your while loop.
Although I'm not sure if it will make any difference to your problems or not.

In your conditional statement, you are using an assignment operator = as opposed to a
comparison operator such as ==. Thus, if I'm not mistaking, (i'm new to PHP), this will
always cause the conditional to be true.


[code]
while(mysql_fetch_array($standings_query) == $table_rows)
{
  ?>

<tr>
  <td colspan="2">
  <h3>League Leaders</h3>
  </td>
</tr>
<tr>
  <td>
  <?=$table_row[name]?>
  </td>
  <td>
  <?=$table_row[points]?>
  </td>
</tr>
<?
}
[/code]

[Zane]

that mostly concerns IF statements

it won't always return true because by the time it gets to the last record
of your query
mysql_fetch_array will return FALSE.
stopping the loop