Hit Counter Code giving ERROR

[vishalonne]

Hi All

I am getting an warning on my web page when I uploaded the page on server I just writing a PHP PAge Hit Counter-

 

Warning: session_start() [function.session-start]: Cannot send session cookie - headers already sent by (output started at /home/cbsecpsn/public_html/csnip/form_453570.php:7) in /home/cbsecpsn/public_html/csnip/counter.php on line 2

 

Warning: session_start() [function.session-start]: Cannot send session cache limiter - headers already sent (output started at /home/cbsecpsn/public_html/csnip/form_453570.php:7) in /home/cbsecpsn/public_html/csnip/counter.php on line 2

 

This is the output - Total page views = 1

 

 

Here is the Code -

Counter.php

<?PHP
session_start();
if(isset($_SESSION['views'])){
$_SESSION['views'] = $_SESSION['views']+ 1;
}else{
$_SESSION['views'] = 1;
}
echo "Total page views = ". $_SESSION['views'];
?>

 

And I used it like this in Survey_Form.php

 

<div class='sfm_cr_box' style='padding:3px; width:350px'>
<?php
echo "<hr><div align=\"center\">";
include_once "counter.php"; // this will include the counter.
echo "</div>";
?>
</div>

 

What is the problem with the code?

[jazzman1]

Have you ever read this topic -> http://forums.phpfreaks.com/index.php?topic=37442.0

 

 

[vishalonne]

Hi

Thank you for looking in my problem, actually I want to display hit counter at the bottom of the page. Do I need session...?????

I just want to keep track how many of visitors came to this page.

 

Is it possible without session??

 

My problem is simple for you but for new one like me it confusing

[scootstah]

Sessions are unique to the user, so they would only ever see their page views, but nobody else's.

 

So, you would need to save the page views to a database, or a flat file or something.

[vishalonne]

I found this code from Google

<?php

$filename = 'hitcount.txt';
$handle = fopen($filename, 'r');
$hits = trim(fgets($handle)) + 1;
fclose($handle);

$handle = fopen($filename, 'w');
fwrite($handle, $hits);
fclose($handle);

// Uncomment the next line (remove //) to display the number of hits on your page.
//echo $hits;

?>

 

And I have to put this code where I want to display the counter like this

 

<p>This web site has had <b><?php include("counter.php"); ?></b> hits since January 1st, 2007.</p>

 

This will open a txt file and write in it. Is this OK?

[scootstah]

Sure that will work, but you can simplify it a bit using file_get_contents and file_put_contents.

 

<?php
file_put_contents('hitcount.txt', ((int) file_get_contents('hitcount.txt')) + 1);

[vishalonne]

Thanx

Do you mena this

My Code

$hits = trim(fgets($handle)) + 1;

Your Code

file_put_contents('hitcount.txt', ((int) file_get_contents('hitcount.txt')) + 1);

 

Am I correct

[scootstah]

You don't need any of your code, just the one line I wrote. I mean, either way works fine, but file_get_contents() and file_put_contents() is the preferred method.

[vishalonne]

Well Thank you. I done with my old code because I don't know what is benefit of using the way to suggested, as I am a learner, but I will obliviously try to know what is the difference.

 

Thanx once again for cooperation

[scootstah]

You get the same result either way, but the benefit is less code. For example to write data to a file you don't have to call fopen(), fwrite(), and fclose() - you simply call file_put_contents(). It's just a bit easier, is all.

[vishalonne]

Thank you Scootstah for clearing my doubt.