Help needed please

[liro]

Hi,
I'm working with a cms called phpwcms and I'm stuck with a php script that I cannot seem to get working.
Please check my site [url=http://www.rklisse.nl]http://www.rklisse.nl[/url]. You will see part of the script on top of the page and what I have understand that it is a 'selfmade' problem. Only problem is I do not know how I did this and how to solve it.

Can you explain in simple english how this is caused and perhaps how to solve it.
More information on the script can be found at [url=http://www.phpwcms.de/forum/viewtopic.php?t=7261&highlight=artread]http://www.phpwcms.de/forum/viewtopic.php?t=7261&highlight=artread[/url]

Thanks.

[JasonLewis]

well it would help if you posted a bit of the script above that. i have a feeling you are either echoing it by mistake or you are closing your php tag.

[liro]

This would be the script:
[code]<?PHP
// AUTHOR: Jens Zetterström {ART_READ}
// DESCRIPTION: Returns the number of times an article has been read.
// REQUIREMENTS: {MOST_READ} enhancement: phpwcms_article_read_count table, etc
// USAGE: {ART_READ:article_id:category_id}
//        I put it in my article template file so that
//        it appears for each article:
//        {ART_READ:<?php echo $GLOBALS["content"]["article_id"];?>:<?php echo $GLOBALS["content"]["cat_id"];?>}


function get_article_read_cnt($art_id, $cat_id, $dbcon)
{
  $count = 0;
   
  $sql ="SELECT count( article_id ) as art_cnt
          FROM ".DB_PREPEND."phpwcms_article_read_count
          WHERE article_id = $art_id
          AND cat_id = $cat_id ";

  if($result = mysql_query($sql, $dbcon))
  {
      $row = mysql_fetch_assoc($result);
      $count = $row["art_cnt"];
      mysql_free_result($result);
  }
  return $count;
}


// {ART_READ}
if( ! ( strpos($content["all"],'{ART_READ:')===false ) )
{
  $content["all"] = preg_replace('/\{ART_READ:(\d+):(\d+)\}/e','get_article_read_cnt($1,$2,$db);',$content["all"]);
}
?>
[/code]

[FSGr33n]

[quote]
// {ART_READ}
if( ! ( strpos($content["all"],'{ART_READ:')===false ) )
{
  $content["all"] = preg_replace('/\{ART_READ:(\d+):(\d+)\}/e','get_article_read_cnt($1,$2,$db);',$content["all"]);
}
[/quote]

I believe it is because of the single quotes around the 2nd param of the preg_replace function, also remove the semi-colon replace it with this

[code]
// {ART_READ}
if( ! ( strpos($content["all"],'{ART_READ:')===false ) )
{
  $content["all"] = preg_replace('/\{ART_READ:(\d+):(\d+)\}/e',get_article_read_cnt($1,$2,$db),$content["all"]);
}
[/code]

Hopefully thats it

[liro]

Nope, sorry. Still the code is on top of my page.

[JasonLewis]

OMG! lol. try replacing all of the code with this:

[code]
<?PHP
// AUTHOR: Jens Zetterström {ART_READ}
// DESCRIPTION: Returns the number of times an article has been read.
// REQUIREMENTS: {MOST_READ} enhancement: phpwcms_article_read_count table, etc
// USAGE: {ART_READ:article_id:category_id}
//        I put it in my article template file so that
//        it appears for each article:

function get_article_read_cnt($art_id, $cat_id, $dbcon)
{
  $count = 0;
   
  $sql ="SELECT count( article_id ) as art_cnt
          FROM ".DB_PREPEND."phpwcms_article_read_count
          WHERE article_id = $art_id
          AND cat_id = $cat_id ";

  if($result = mysql_query($sql, $dbcon))
  {
      $row = mysql_fetch_assoc($result);
      $count = $row["art_cnt"];
      mysql_free_result($result);
  }
  return $count;
}


// {ART_READ}
if( ! ( strpos($content["all"],'{ART_READ:')===false ) )
{
  $content["all"] = preg_replace('/\{ART_READ:(\d+):(\d+)\}/e',get_article_read_cnt($1,$2,$db),$content["all"]);
}
?>
[/code]

i removed that comment. i think it was screwing up your code.

[liro]

No sorry again, site went blank completely now!!!!!! :'(

[liro]

Hi, solved!!!!!!

From the original code the following line needed to be removed to get it work!
//        {ART_READ:<?php echo $GLOBALS["content"]["article_id"];?>:<?php echo $GLOBALS["content"]["cat_id"];?>}

Thanks to you all!

[JasonLewis]

but thats the comment that i removed. and i added that bit in that FSGrr3n added.