Displaying Pages In A Drop Down Menu Via Page Types

[White_Lily]

Hi, I have a page that allows you to select pages that you want have related pages on. The problem I'm having is that its not displaying anything, not even the types of pages that I want it to display and have specified.

 

<?php
$getCategories = select("pages", "id, name", "page_switch = 1");
while ($categories = mysql_fetch_array($getCategories))
{
//if(!isset($usedCats[$categories['id']])){
if($categories["type"] == 2 && $categories["type"] == 4 && $categories["type"] == 5){
echo "<option value='".$categories['id']."'>".$categories['name']."</option>";
}
//}
}
?>

 

I can't seem to figure out why it's not displaying anything

 

Any help would be appreciated.

[Barand]

How can a value equal 2, 4 and 5 all at the same time?

 

Try using "||" instead of "&&"

[White_Lily]

Got a point there lol guess i didn't see it like that - will try the ||

[White_Lily]

No it didnt work, and error reporting isnt showing any errors either.

 

php,ini id set to:

display_errors = on
error_reporting = -1

[Barand]

No it didnt work, ...

 

 

I think you've read enough posts on this board to know that statement needs more explanation

[White_Lily]

A friend managed to fix it for me.

[Barand]

White_Lily,

 

Have you ever searched the internet with a problem only to find many posts all asking similar questions but no-one actually posting a solution. Don't you find it frustrating and annoying?

[White_Lily]

I will post the solution tomorrow when I am back at work. Sorry.

[White_Lily]

<label>Page:</label>
<select name="catSel" style="width: 300px;">
<?
$getCategories = select("pages", "id, name", "(page_switch = 1) AND (type = 2 OR type = 4 OR type = 5)"); // this line is the fix
while ($categories = mysql_fetch_array($getCategories))
{
echo "<option value='".$categories['id']."'>".$categories['name']."</option>";
}
?>
</select>

[Christian F.]

You should use the full PHP tags instead of the short tags, and you need to/should use htmlspecialchars () to ensure that there are no problems with (accidental) HTML injections.

 

Also, labels without a for attribute, pointing to a identically named id attribute of an input element, is quite useless.

 

Lastly, you could have solved this using MySQL's IN() function. Allows for a much cleaner solution, especially if you have many IDs you want to match.

[White_Lily]

I didnt write the code for any of this, I'm merely adding to it/fixing errors. The way it was written wasn't really my choice unfortunately.

 

You have confused me with the whole labels thing... sorry

[Christian F.]

<label for="inp_name">Name:</label>
<input id="inp_name" type="text" name="name">

Click on the label, and the associated input field gains focus.

[White_Lily]

Ah that! Yeah I know about that sorry. If there are any id's (or classes for that matter) then it's because we are using TinyMCE to display text fields etc.