Delete Table-Row By Pressing The Delete-Button

jepperask · November 7, 2012

Hello!

I'm making a blog and I'm almost done with it. I'm at the point, where i have a page and I've created a while-loop, that shows every post on the page. I even asigned the delete-button, but for some reason it doesn't work. Could you take a look at my code and help me out? Thanks in advance.

<?php
session_start();
if(!isset($_SESSION['user_id'])){
header('location: index.php');
exit();
}
if (isset($_POST['post_id'])) {
$post_id = $_POST['post_id'];
if (isset($_POST['delete_id'])) {
mysql_query("DELETE FROM posts WHERE post_id = " . $post_id);
}
}
?>
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8"/>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<style>
#delete-post {
width: 100%;
margin: auto;
background-color: #999;
}
</style>
<script src="http://code.jquery.com/jquery-1.5.min.js"></script>
</head>
<body>
<div>
<table border cellpadding="3">
<?php
mysql_connect("localhost", "root", "hejmeddig") or die(mysql_error());
mysql_select_db("pentakill_dk_db") or die(mysql_error());
$data = mysql_query("SELECT * FROM posts") or die(mysql_error());
while($info = mysql_fetch_array($data)){ ?>
<tr>
<th>
<form method="post" action="">
<input type="hidden" name="post_id" value="<?php echo $info['post_id']; ?>" />
<input type="submit" name="delete_id" value="Delete" />
</form>
</th>
<th>
Post-Title:
</th>
<td>
<?php echo $info['title']; ?>
</td>
<th>
Body:
</th>
<td>
<?php echo $info['body']; ?>
</td>
</tr>
<?php } ?>
</table>
</div>
</body>
</html>

Muddy_Funster · November 8, 2012

try this as a basic debugging step :

if (isset($_POST['delete_id'])) {
$qry = "DELETE FROM posts WHERE post_id = " . $post_id;
die ($qry);
//mysql_query($qry);
}

make sure the query looks right, if it does, run it directly in the database as a test, if that works then there is nothing wrong with the query, and there is an issue with some other part of the code.

p.s. when developing you should always have an or die attached to every query :

mysql_query($qry) or die (mysql_error(). "<br /> Error occured during :<br /> $sql");

These should be removed from the code before it goes live and be replaces with generic error displays, while the actual helpfull stuff is store securely in a log file or even emailed to yourself.

jepperask · November 8, 2012

try this as a basic debugging step :
if (isset($_POST['delete_id'])) {
$qry = "DELETE FROM posts WHERE post_id = " . $post_id;
die ($qry);
//mysql_query($qry);
} 
make sure the query looks right, if it does, run it directly in the database as a test, if that works then there is nothing wrong with the query, and there is an issue with some other part of the code.

p.s. when developing you should always have an or die attached to every query :
mysql_query($qry) or die (mysql_error(). "<br /> Error occured during :<br /> $sql");
These should be removed from the code before it goes live and be replaces with generic error displays, while the actual helpfull stuff is store securely in a log file or even emailed to yourself.

Hi, thanks for the reply. But i actually got another answer from a friend, who showed me that it could be the alignment of all my code. So he changed it a bit, and this worked:


<?php
    session_start();
    mysql_connect("localhost", "root", "hejmeddig") or die(mysql_error());          
    mysql_select_db("pentakill_dk_db") or die(mysql_error());
    include 'config.php';
    if (isset($_POST['post_id'])) {
        $post_id = $_POST['post_id'];
        if (isset($_POST['delete_id'])) {
            mysql_query("DELETE FROM posts WHERE post_id = " . $post_id);
        }
    }
?>
<!DOCTYPE html>
<html lang="en">
    <head>
        <meta charset="utf-8"/>
        <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
        <style>
            #delete-post {
                width: 100%;
                margin: auto;
                background-color: #999;
            }
        </style>
        <script src="http://code.jquery.com/jquery-1.5.min.js"></script>
    </head>
    <body>
        <div>
            <table border cellpadding="3">
                <?php
                $data = mysql_query("SELECT * FROM posts") or die(mysql_error());
                while($info = mysql_fetch_array($data)){ ?>
                    <tr>
                        <th>
                            <form method="post" action="">
                                <input type="hidden" name="post_id" value="<?php echo $info['post_id']; ?>" />
                                <input type="submit" name="delete_id" value="Delete" />
                            </form>
                        </th>
                        <th>
                            Post-Title:
                        </th>
                        <td>
                            <?php echo $info['title']; ?>
                        </td>
                        <th>
                            Body:
                        </th>
                        <td>
                            <?php echo $info['body']; ?>
                        </td>
                   </tr>
                <?php }    ?>
            </table>
        </div>
    </body>
</html>

The thing that changed it all, was moving the database connection, to right after the session-start.

Sign In

Delete Table-Row By Pressing The Delete-Button

Recommended Posts

jepperask

Link to comment

Share on other sites

Muddy_Funster

Link to comment

Share on other sites

jepperask

Link to comment

Share on other sites

Archived

Browse

Activity

Important Information