Is This Right $Act==Del?

[lovephp]

guys im trying to add up a action to delete all table if needed else delete row according to id.

 

 

i added

 

if($act==del){

mysql_query("DROP TABLE survey") or die(mysql_error());

}

 

this should execute only if i make the url like del.php?act=del else only the DELETE FROM survey WHERE id = '$id' should work. tell me if its the right way

 

 

<?php
$id =$_REQUEST['id'];    
$user = $login->username;
if($user =='administrator'){
   // sending query
   mysql_query("DELETE FROM survey WHERE id = '$id'")
   or die(mysql_error());    
   header("Location: status.php");
}else{
    header("Location: logout.php");
}
if($act==del){
mysql_query("DROP TABLE survey") or die(mysql_error());    
}

?>

[AyKay47]

1. Check that $_REQUEST['id'] is set and is an integer before using it, right now your code is open to SQL injection.

 

2. Where is $act coming from?

 

3. del is assumed to be a constant value without the value wrapped in quotes.

[Pikachu2000]

Why do you need to dynamically drop a table?

[PFMaBiSmAd]

^^^ Especially since your user level check code lets the rest of the code on your page run and anyone could drop the table.

[lovephp]

im tryin to make it available for me to drop all table if needed without deing the user=administrator but it does not seem to work and the $act=del i want to manually add it on url

[Pikachu2000]

If you need to drop tables dynamically, chances are your database structure is wrong. Even so, trying to allow it without being logged in as administrator is dangerous.

[lovephp]

yes you are right i better drp this idea, thanks all

[PFMaBiSmAd]

lol, drop this idea, very punny.

[AyKay47]

Please mark this as solved.

[lovephp]

done.