Code String Cleanup Help

[monkeybidz]

I keep getting an error message on my site that points to this line of code. It is from OSCommerece. Can someone help me clean this line up a bit. Just does not look right to me. I played with it a bit and I get some good results, just not 100Y%.

 

eval('$keys .= ' . $value['set_function'] . "'" . $value['value'] . "', '" . $key . "');");

 

Thanks in advance!

[twistedvengeance]

eval("$keys .= " . $value['set_function'] . "'" . $value['value'] . "','" . $key . "');");

[monkeybidz]

You are in the right direction, it displayed more results than before, but I now get this error:

 

Parse error: syntax error, unexpected '<'

[twistedvengeance]

Then you have an error somewhere else in your code, post 5-10 more lines on either side of the code so we can see what might be causing errors.

 

Or even the entire script if it's not huge.

[Christian F.]

If you do a var_dump () on the three variables for me, I can rewrite it to something proper for you.

 

eval () is evil and should never be used, and using it in the above manner is just bad on all levels. Unfortunately, the OSCommerce code is full of bad stuff.