Trim last values

[seran128]

OK I have my code

that displays a dynamic menu like

item1 | item2 | item3 |

the problem is the last | i need to trim it off

so i should get

item1 | item2 | item3

[code]function getmenu(){
global $connection;

$sql=mysql_query("SELECT * from menu order by sort_order") or die(mysql_error());


$getmenu .= "<table width='100%' border='0'><tr><td><span class='copy'>&nbsp;&nbsp;&nbsp;&nbsp;";

while($row=mysql_fetch_array($sql)) {
$getmenu .= "<a href=javascript:menulink(" . $row['ID'] . ")>" . stripslashes($row['title']) . "&nbsp;|&nbsp;&nbsp;";
}

$getmenu .= "</span></td></table>";


return $getmenu;
}[/code]

[Jenk]

reading the manual for trim, or rtrim may help. Especially the optional argument..

[SharkBait]

I dont know if there is a better way but I do it like this:

[code]

$links = "item1 | item2 | item3 |";

substr($links, 0, strlen($links)-2);

[/code]

I'm sure there is an easier way but I just knock of  the last few chacters if you know there will always be 1 or 2 characters after the string.

[kenrbnsn]

You can use the [url=http://www.php.net/rtrim]rtrim()[/url] function:
[code]<?php
$str = 'item1 | item2 | item3 |';
$str = rtrim($str,' |');
?>[/code]
or you could build the menu slightly differently:
[code]<?php
function getmenu(){
global $connection;
$sql=mysql_query("SELECT * from menu order by sort_order") or die(mysql_error());
$getmenu = "<table width='100%' border='0'><tr><td><span class='copy'>&nbsp;&nbsp;&nbsp;&nbsp;";
$tmp = array();
while($row=mysql_fetch_assoc($sql)) {
$tmp[] = '<a href="javascript:menulink(' . $row['ID'] . ')">' . stripslashes($row['title']);
}
$getmenu .= "&nbsp;" . implode("&nbsp;|&nbsp;",$tmp) . "&nbsp;";
$getmenu .= "</span></td></table>";
        return($getmenu);
}?>[/code]

Ken

[printf]

one way...

[code]function getmenu()
{
global $connection;

$sql = mysql_query ( "SELECT * from menu order by sort_order" ) or die ( mysql_error () );

$hold = array ();

while ( $row = mysql_fetch_array ( $sql, MYSQL_ASSOC ) )
{
$hold[] = "<a href='javascript:menulink(" . $row['ID'] . ");'>" . stripslashes ( $row['title'] ) . "</a>";
}

return "<table width='100%' border='0'><tr><td><span class='copy'>&nbsp;&nbsp;" . implode ( '&nbsp;&nbsp;|&nbsp;&nbsp;', $hold ) . "&nbsp;&nbsp;</span></td></table>";
}[/code]