cant open zip

[ecabrera]

why does it not download it says its invalid i thought this would work

        if($type == "application/x-zip-compressed"){

            header("Content-Type: application/x-zip-compressed");
            header('Content-Disposition: attachment; filename="'.$name.'"');
            header("Content-Transfer-Encoding: binary");
            header('Pragma: no-cache');
            header('Expires: 0');
            readfile("myfiles/$name");

        }

[jazzman1]

Try,

if($type == "application/x-zip-compressed"){

            header("Content-Type: application/x-zip-compressed");
            header('Content-Disposition: attachment; filename='.  basename("myfiles/$name"));
            header("Content-Transfer-Encoding: binary");
            header('Pragma: no-cache');
            header('Expires: 0');
            header('Content-Length: ' . filesize("myfiles/$name"));
            readfile("myfiles/$name");

        }

[ecabrera]

jazzman1

 

It downloads it now but when its down downloading it still says invalid

[jazzman1]

Can I see the output of:

echo myfiles/$name

[ecabrera]

i get this myfiles/2.0 (5).zip

[jazzman1]

Is there a real zip file with this name - 2.0 (5).zip?

[ecabrera]

yes and the same name to 2.0 (5).zip

[jazzman1]

Try to replace the empty character with underscore(_) using str_replace() php function.

[ecabrera]

ok but i have other zips that don't have empty space like for example file.zip and its still says invalid

[jazzman1]

Attach this file.zip here I wanna test it on my local server. 

 

Don't attach anything I tried with another zip file and the result was like yours. I will try later again. There is something wrong.

[ecabrera]

here you go

file.zip

[jazzman1]

When I moved the zip file in the same directory where the script is - it works.

 

The script is:

<?php

$name = "test.zip";

header("Content-Type: application/x-zip-compressed");
header('Content-Disposition: attachment; filename='.  basename("$name"));
header("Content-Transfer-Encoding: base64");
header('Pragma: no-cache');
header('Expires: 0');
header('Content-Length: ' . filesize("$name"));
readfile("$name");

I will try later on to see where the problem is b/s don't have the time to get into it

[ecabrera]

thanks for the help i will see if i can figure it out

[bashy]

Have you tried checking where it's looking or tried setting the full dir?

[ecabrera]

bashy 

 

thats what i tired doing and it downloads it but its saying invalid when it opens i feel the the readfile() maybe the problem i dont know 

[bashy]

Looking on PHP manual, try adding

header('Content-Length: ' . filesize($name));

Or looking at PHP readfile, there's some added functions by users, found something you might want to change and take a look at

$filename = 'dummy.zip';
            $filename = realpath($filename);

            $file_extension = strtolower(substr(strrchr($filename,"."),1));

            switch ($file_extension) {
                case "pdf": $ctype="application/pdf"; break;
                case "exe": $ctype="application/octet-stream"; break;
                case "zip": $ctype="application/zip"; break;
                case "doc": $ctype="application/msword"; break;
                case "xls": $ctype="application/vnd.ms-excel"; break;
                case "ppt": $ctype="application/vnd.ms-powerpoint"; break;
                case "gif": $ctype="image/gif"; break;
                case "png": $ctype="image/png"; break;
                case "jpe": case "jpeg":
                case "jpg": $ctype="image/jpg"; break;
                default: $ctype="application/force-download";
            }

            if (!file_exists($filename)) {
                die("NO FILE HERE");
            }

            header("Pragma: public");
            header("Expires: 0");
            header("Cache-Control: must-revalidate, post-check=0, pre-check=0");
            header("Cache-Control: private",false);
            header("Content-Type: $ctype");
            header("Content-Disposition: attachment; filename=\"".basename($filename)."\";");
            header("Content-Transfer-Encoding: binary");
            header("Content-Length: ".@filesize($filename));
            set_time_limit(0);
            @readfile("$filename") or die("File not found.");

[ecabrera]

Most of that stuff is already being implement in the file but it when it opens its says invalid file

[bashy]

Well you best show all of the code being used for this...?

 

So you have

header('Content-Length: ' . filesize($name));

added?

[ecabrera]

ok i solved it i added 

           header("Content-Type: application/x-zip-compressed");
           header('Content-Disposition: attachment; filename='.  basename("myfiles/$name"));
            header("Content-Transfer-Encoding: binary");
            header('Pragma: no-cache');
            header('Expires: 0');
            header('Content-Length: ' . filesize("myfiles/$name"));
//added this below
ob_clean();
flush();
            readfile("myfiles/$name");
exit;

[jazzman1]

ob_clean() and flush() functions have nothing to do unless the output buffering being enabled in the php configuration script or you called ob_start() somewhere on your own script manualy starting this buffer. So, my advise is to avoid using it here.

 

Try again without any buffering.

 

Here it is:

<?php

// get the current working directory
//echo __DIR__; exit;

// define the name of the zip file
$fileName = 'file.zip';

// set the path to zip directory and file name
$path = __DIR__ . '/downloads/zip/'.$fileName;

header("Content-Type: application/x-zip-compressed");
header('Content-Disposition: attachment; filename=' . basename($path));
header("Content-Transfer-Encoding: binary");
header('Pragma: no-cache');
header('Expires: 0');
header('Content-Length: ' . filesize($path));
readfile($path);

Here, my working directory on my local machine is named - /var/www/html/public_html/pdo/

The path to the zip directory is - /var/www/html/public_html/pdo/downloads/zip/

[mac_gyver]

your php code in the download file is either intentionally (i.e. your previous thread for this subject) or accidentally outputting characters to the browser that become part of the downloaded file, corrupting it.

 

if you open the downloaded file that is failing in a programming editor, you will be able to see either what is being added to the start of the file. it's either some specific content, a php error message, or byte order mark characters.