Jump to content

Is this segment of code a vulnerability ?

Go to solution Solved by Barand,

Recommended Posts


Quickl easy question. :)

	    $stmt = $pdo->prepare("SELECT *, count(*) FROM users WHERE forgotten_code=? LIMIT 1");
		$check = $stmt->fetch();
		if($check['count(*)'] > 0)


My thinking was that as its a PDO its not.

Edited by oz11
Link to comment
Share on other sites

  • Solution

It's poor SQL code.

  • Any data returned by the "*" in the select will be meaningless.
  • Because you are using an aggregation function the LIMIT is redundant - there will only be a single row containing the count.
  • It is better to use a column alias for functions
$stmt = $pdo->prepare("SELECT count(*) as total FROM users WHERE forgotten_code=?");
        $check = $stmt->fetch();
        if ($check['total'] > 0)


Link to comment
Share on other sites

This thread is more than a year old. Please don't revive it unless you have something important to add.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.