PHP Bad Practice Question

[theandersen]

Good evening, everyone.

 

Would you consider the "echo '<a href= ..." line in the follow function bad practice?

 

function listTopicsAsLinks() {

connectToDB();

$query = 'select * from tblTopic order by tblTopic.topicName';

$result = mysql_query($query) or die (mysql_error());

while($row = mysql_fetch_array($result, MYSQL_ASSOC)) {

$topicName = $row['topicName'];

$topicID = $row['topicID'];

echo '<li>';

echo '<a href="messageBrowse.php?topicID=' . $topicID . '&messageID=0&messagesPerPage=5">' . $topicName . '</a>';

echo '</li>' . "\n";

}

}

 

I appreciate your input.

[fert]

doesn't look like bad practice at all

[ToonMariner]

I prefer where possible to break out of php for html.  This is purely down to preference but I find it helps in various editors to distinguish code.

 

That said there is nothing wrong with what you have.  Its all down to preference - pick one style and stick to it; the best option is one that makes your code easy to read for other people...