[SOLVED] Image Resizing Not Working

[cmgmyr]

Hey Guys,

This is my script that I use for image resizing. I have a client on php5 and now i'm just getting those little red x's. He does have GD library and it is running. What do I need to change in order for it to work?

 

<?php

   header("Content-type: image/jpeg");
   $source = imagecreatefromjpeg($src);
   $orig_w=imagesx($source);
   $orig_h=imagesy($source);
   
   //See if there is a different height and width
   
   if(!$_GET['wmax']){
   		$wmax=100;
   }
   if(!$_GET['hmax']){
   		$hmax=100;
   }
   $quality=90;
   $bgcol=000000;
   
   if ($orig_w>$wmax || $orig_h>$hmax)
   {
       $thumb_w=$wmax;
       $thumb_h=$hmax;
       if ($thumb_w/$orig_w*$orig_h>$thumb_h) 
           $thumb_w=round($thumb_h*$orig_w/$orig_h); 
       else 
           $thumb_h=round($thumb_w*$orig_h/$orig_w);
   } else
   {
       $thumb_w=$orig_w;
       $thumb_h=$orig_h;
   }
   if (!@$bgcol)
   {
       $thumb=imagecreatetruecolor($thumb_w,$thumb_h);
       imagecopyresampled($thumb,$source,
                           0,0,0,0,$thumb_w,$thumb_h,$orig_w,$orig_h);
   }
   else
   {
       $thumb=imagecreatetruecolor($wmax,$hmax);
       imagefilledrectangle($thumb,0,0,$wmax-1,$hmax-1,intval($bgcol,16));
       imagecopyresampled($thumb,$source,
                           round(($wmax-$thumb_w)/2),round(($hmax-$thumb_h)/2),
                           0,0,$thumb_w,$thumb_h,$orig_w,$orig_h);
   }
   if (!@$quality) $quality=90;
   imagejpeg($thumb,"",$quality);
   imagedestroy($thumb);
?> 

 

Thanks,

-Chris

[MadTechie]

i assume you are setting

$src somewhere!

[MadTechie]

Works fine!

 

test.php?scr=test.jpg

<?php
   header("Content-type: image/jpeg");
   $source = imagecreatefromjpeg($_GET['scr']); //<--updated
   $orig_w=imagesx($source);
   $orig_h=imagesy($source);
   
   //See if there is a different height and width
   
   if(!$_GET['wmax']){
   		$wmax=100;
   }
   if(!$_GET['hmax']){
   		$hmax=100;
   }
   $quality=90;
   $bgcol=000000;
   
   if ($orig_w>$wmax || $orig_h>$hmax)
   {
       $thumb_w=$wmax;
       $thumb_h=$hmax;
       if ($thumb_w/$orig_w*$orig_h>$thumb_h) 
           $thumb_w=round($thumb_h*$orig_w/$orig_h); 
       else 
           $thumb_h=round($thumb_w*$orig_h/$orig_w);
   } else
   {
       $thumb_w=$orig_w;
       $thumb_h=$orig_h;
   }
   if (!@$bgcol)
   {
       $thumb=imagecreatetruecolor($thumb_w,$thumb_h);
       imagecopyresampled($thumb,$source,
                           0,0,0,0,$thumb_w,$thumb_h,$orig_w,$orig_h);
   }
   else
   {
       $thumb=imagecreatetruecolor($wmax,$hmax);
       imagefilledrectangle($thumb,0,0,$wmax-1,$hmax-1,intval($bgcol,16));
       imagecopyresampled($thumb,$source,
                           round(($wmax-$thumb_w)/2),round(($hmax-$thumb_h)/2),
                           0,0,$thumb_w,$thumb_h,$orig_w,$orig_h);
   }
   if (!@$quality) $quality=90;
   imagejpeg($thumb,"",$quality);
   imagedestroy($thumb);
?> 

 

 

NOTE THE CHANGE $source = imagecreatefromjpeg($_GET['scr']);

[cmgmyr]

...yes

 

It's something like this: <img src="thumb.php?src=images/cms_images/<?php echo $image ?>" />

 

The script works in php4 and not php5

[MadTechie]

i run it on PHP Version 5.2.1, seams OK

 

GD Version bundled (2.0.28 compatible)

[MadTechie]

as a note in the code you posted you were not pulling in src..

[cmgmyr]

hmmm, the gd library looks like it's working...any other ideas?

[MadTechie]

is your page live ?

 

ie can i view it online ?

[cmgmyr]

Link

[MadTechie]

the path to the image is

http://rainbowjewelersinc.com/new/thumb.php?src=images/cms_images/6iuf5uxcbheczb0z.jpg&wmax=500&hmax=500

 

is the code you are using

$source = imagecreatefromjpeg($_GET['scr']); //<--updated

 

or

 

$source = imagecreatefromjpeg($src);

[cmgmyr]

i just updated it...still didn't work

[MadTechie]

test the script from.

 

Works fine!

 

test.php?scr=test.jpg

<?php
   header("Content-type: image/jpeg");
   $source = imagecreatefromjpeg($_GET['scr']); //<--updated
   $orig_w=imagesx($source);
   $orig_h=imagesy($source);
   
   //See if there is a different height and width
   
   if(!$_GET['wmax']){
   		$wmax=100;
   }
   if(!$_GET['hmax']){
   		$hmax=100;
   }
   $quality=90;
   $bgcol=000000;
   
   if ($orig_w>$wmax || $orig_h>$hmax)
   {
       $thumb_w=$wmax;
       $thumb_h=$hmax;
       if ($thumb_w/$orig_w*$orig_h>$thumb_h) 
           $thumb_w=round($thumb_h*$orig_w/$orig_h); 
       else 
           $thumb_h=round($thumb_w*$orig_h/$orig_w);
   } else
   {
       $thumb_w=$orig_w;
       $thumb_h=$orig_h;
   }
   if (!@$bgcol)
   {
       $thumb=imagecreatetruecolor($thumb_w,$thumb_h);
       imagecopyresampled($thumb,$source,
                           0,0,0,0,$thumb_w,$thumb_h,$orig_w,$orig_h);
   }
   else
   {
       $thumb=imagecreatetruecolor($wmax,$hmax);
       imagefilledrectangle($thumb,0,0,$wmax-1,$hmax-1,intval($bgcol,16));
       imagecopyresampled($thumb,$source,
                           round(($wmax-$thumb_w)/2),round(($hmax-$thumb_h)/2),
                           0,0,$thumb_w,$thumb_h,$orig_w,$orig_h);
   }
   if (!@$quality) $quality=90;
   imagejpeg($thumb,"",$quality);
   imagedestroy($thumb);
?> 

 

 

NOTE THE CHANGE $source = imagecreatefromjpeg($_GET['scr']);

[cmgmyr]

yes i already change it to _get and it still didn't work...I copied the whole code over again and it still didn't work

[MadTechie]

oooow something wired

 

i linked my test script to your page

 

this WORKED

TEST.php?scr=http://rainbowjewelersinc.com/new/images/top.jpg

 

This FAILED

TEST.php?scr=http://rainbowjewelersinc.com/new/images/cms_images/6iuf5uxcbheczb0z.jpg

 

error Allowed memory size of 16777216 bytes exhausted

on this line

  $source = imagecreatefromjpeg($_GET['scr']);

 

[cmgmyr]

hmm...i'll resize them in photoshop and re-upload them with a lower file size and see if it works...

[MadTechie]

could be a formatting issule.. i had a problem with that before.. anyways i hope it resolved the problem..

 

 

PS Nice looking site

[cmgmyr]

thanks for the help and thank about the site

[MadTechie]

Happy to Help 

 

please click solved

[cmgmyr]

re-uploaded a few images to a smaller file size...still nothing

[cmgmyr]

I just made a new thumb code with a few less things and it worked...o well